* [PATCH v2 1/2] dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ hardware
2026-11-16 21:25 [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P) Stanislav Aleksandrov
@ 2026-11-16 21:25 ` Stanislav Aleksandrov
2026-11-16 21:25 ` [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist Stanislav Aleksandrov
2026-11-17 5:41 ` [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P) Viresh Kumar
2 siblings, 0 replies; 6+ messages in thread
From: Stanislav Aleksandrov @ 2026-11-16 21:25 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam
Cc: Zhongqiu Han, linux-pm, linux-arm-msm, devicetree, linux-kernel,
Stanislav Aleksandrov
Document the CPUFREQ hardware (EPSS) on the Qualcomm Halliday SoC.
Signed-off-by: Stanislav Aleksandrov <lightofmysoul@gmail.com>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index 98eb36bff172..d6040cd293f9 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -36,6 +36,7 @@ properties:
items:
- enum:
- qcom,eliza-cpufreq-epss
+ - qcom,halliday-cpufreq-epss
- qcom,milos-cpufreq-epss
- qcom,qcs8300-cpufreq-epss
- qcom,qdu1000-cpufreq-epss
@@ -135,6 +136,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,halliday-cpufreq-epss
- qcom,qcs615-cpufreq-hw
- qcom,qdu1000-cpufreq-epss
- qcom,sa8255p-cpufreq-epss
--
2.55.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist
2026-11-16 21:25 [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P) Stanislav Aleksandrov
2026-11-16 21:25 ` [PATCH v2 1/2] dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ hardware Stanislav Aleksandrov
@ 2026-11-16 21:25 ` Stanislav Aleksandrov
2026-11-16 21:32 ` sashiko-bot
2026-11-17 5:41 ` [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P) Viresh Kumar
2 siblings, 1 reply; 6+ messages in thread
From: Stanislav Aleksandrov @ 2026-11-16 21:25 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam
Cc: Zhongqiu Han, linux-pm, linux-arm-msm, devicetree, linux-kernel,
Stanislav Aleksandrov
The Qualcomm Halliday platform uses the qcom-cpufreq-hw driver, so add
it to the cpufreq-dt-platdev driver's blocklist.
Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Signed-off-by: Stanislav Aleksandrov <lightofmysoul@gmail.com>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index bce4c87573a1..3d5709eaa08f 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -155,6 +155,7 @@ static const struct of_device_id blocklist[] __initconst = {
{ .compatible = "nvidia,tegra234", },
{ .compatible = "qcom,apq8096", },
+ { .compatible = "qcom,halliday", },
{ .compatible = "qcom,milos", },
{ .compatible = "qcom,msm8909", },
{ .compatible = "qcom,msm8996", },
--
2.55.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist
2026-11-16 21:25 ` [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist Stanislav Aleksandrov
@ 2026-11-16 21:32 ` sashiko-bot
2026-11-16 21:37 ` Stanislav Aleksandrov
0 siblings, 1 reply; 6+ messages in thread
From: sashiko-bot @ 2026-11-16 21:32 UTC (permalink / raw)
To: Stanislav Aleksandrov; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] cpufreq: dt-platdev: undocumented DT compatible string
qcom,halliday
--
commit 4e273fe3306a2bb3a253890da522236eca532a54
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>
cpufreq: dt-platdev: Add Halliday to blocklist
This commit adds "qcom,halliday" to the cpufreq-dt-platdev blocklist so
that the platform uses the qcom-cpufreq-hw driver instead.
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index bce4c87573a18..3d5709eaa08fe 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -155,6 +155,7 @@ static const struct of_device_id blocklist[] __initconst = {
> { .compatible = "nvidia,tegra234", },
>
> { .compatible = "qcom,apq8096", },
> + { .compatible = "qcom,halliday", },
[Severity: Low]
Should "qcom,halliday" be documented in
Documentation/devicetree/bindings/arm/qcom.yaml before adding it to
blocklist[]?
Commit "dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ
hardware" documents "qcom,halliday-cpufreq-epss", but the root SoC
compatible string "qcom,halliday" is not yet documented in the
Devicetree bindings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-halliday-cpufreq-v2-0-e518cc055457@gmail.com?part=2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist
2026-11-16 21:32 ` sashiko-bot
@ 2026-11-16 21:37 ` Stanislav Aleksandrov
0 siblings, 0 replies; 6+ messages in thread
From: Stanislav Aleksandrov @ 2026-11-16 21:37 UTC (permalink / raw)
To: sashiko-reviews
Cc: Rafael J. Wysocki, Viresh Kumar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, Zhongqiu Han, linux-pm,
linux-arm-msm, devicetree, linux-kernel
On 16/11/2026 21:32, sashiko-bot@kernel.org wrote:
> Should "qcom,halliday" be documented in
> Documentation/devicetree/bindings/arm/qcom.yaml before adding it to
> blocklist[]?
It is documented in the DT series:
https://lore.kernel.org/r/20261116-halliday-dts-v2-12-2c92438c6c46@gmail.com
Stanislav
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P)
2026-11-16 21:25 [PATCH v2 0/2] Add cpufreq support for Qualcomm Halliday (SXR2250P) Stanislav Aleksandrov
2026-11-16 21:25 ` [PATCH v2 1/2] dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ hardware Stanislav Aleksandrov
2026-11-16 21:25 ` [PATCH v2 2/2] cpufreq: dt-platdev: Add Halliday to blocklist Stanislav Aleksandrov
@ 2026-11-17 5:41 ` Viresh Kumar
2 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2026-11-17 5:41 UTC (permalink / raw)
To: Stanislav Aleksandrov
Cc: Rafael J. Wysocki, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam, Zhongqiu Han, linux-pm, linux-arm-msm,
devicetree, linux-kernel
On 16-11-26, 21:25, Stanislav Aleksandrov wrote:
> Document the CPUFREQ hardware (EPSS) of the Qualcomm Halliday SoC and
> keep cpufreq-dt from probing on it.
>
> This is part of the bring-up of the Qualcomm Halliday SoC (SXR2250P)
> in the Samsung Galaxy XR. The DT changes follow in a separate series.
>
> This work was made together with Claude, ChatGPT and Gemini.
> Reviewed and tested on my Galaxy XR, where cpufreq runs through
> qcom-cpufreq-hw.
>
> Signed-off-by: Stanislav Aleksandrov <lightofmysoul@gmail.com>
> ---
> Changes in v2:
> - Add the qcom-hw binding from the DT series (12/17 there), so that
> the cpufreq patches are in one series:
> https://patch.msgid.link/20261109-halliday-dts-v1-12-289114ab8197@gmail.com
> - Use the "cpufreq: dt-platdev:" subject prefix (Zhongqiu)
> - Link to v1: https://patch.msgid.link/20261109-halliday-cpufreq-v1-1-d87a397396fd@gmail.com
>
> ---
> Stanislav Aleksandrov (2):
> dt-bindings: cpufreq: qcom-hw: Document Halliday CPUFREQ hardware
> cpufreq: dt-platdev: Add Halliday to blocklist
>
> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 2 ++
> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> 2 files changed, 3 insertions(+)
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread