From: sashiko-bot@kernel.org
To: "Stanislav Aleksandrov" <lightofmysoul@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Robert Marko" <robimarko@gmail.com>,
"Guru Das Srinagesh" <linux@gurudas.dev>,
"Thomas Gleixner" <tglx@kernel.org>,
"Radu Rendec" <radu@rendec.net>, "Lee Jones" <lee@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Wesley Cheng" <wesley.cheng@oss.qualcomm.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Bean Huo" <beanhuo@micron.com>,
"Stanley Jhu" <stanleyjhu@google.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Thara Gopinath" <thara.gopinath@gmail.com>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Georgi Djakov" <djakov@kernel.org>,
"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
"Ulf Hansson" <ulfh@kernel.org>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev,
linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org,
olteanv@gmail.com
Subject: Re: [PATCH v2 16/16] arm64: dts: qcom: Add Samsung Galaxy XR
Date: Mon, 16 Nov 2026 21:40:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-217738@kernel.org> (raw)
In-Reply-To: <20261116-halliday-dts-v2-16-2c92438c6c46@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: halliday-samsung-xrvst2: invalid chassis-type
value headset
--
commit a88ca65d1f6d17d4cfe0ce907c523f8698e465a8
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>
arm64: dts: qcom: Add Samsung Galaxy XR
This commit adds the device tree for the Qualcomm Halliday-based Samsung
Galaxy XR headset, with initial support for PMICs, keys, USB peripheral mode,
and UFS storage.
> diff --git a/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> new file mode 100644
> index 0000000000000..6fcc1aaafd59c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> @@ -0,0 +1,218 @@
[ ... ]
> +/ {
> + model = "Samsung Galaxy XR";
> + compatible = "samsung,xrvst2", "qcom,halliday";
> + chassis-type = "headset";
[Severity: Low]
Does chassis-type = "headset" fail dtbs_check validation?
The Devicetree Specification and dtschema (schemas/root-node.yaml) restrict
chassis-type to desktop, laptop, convertible, server, tablet, handset, watch,
embedded, television, and all-in-one. Other Qualcomm headset device trees
either omit chassis-type (sm8650-valve-deckard.dts) or use "embedded"
(sar2130p-qar2130p.dts).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-halliday-dts-v2-0-2c92438c6c46@gmail.com?part=16
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Stanislav Aleksandrov" <lightofmysoul@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Robert Marko" <robimarko@gmail.com>,
"Guru Das Srinagesh" <linux@gurudas.dev>,
"Thomas Gleixner" <tglx@kernel.org>,
"Radu Rendec" <radu@rendec.net>, "Lee Jones" <lee@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Wesley Cheng" <wesley.cheng@oss.qualcomm.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Bart Van Assche" <bvanassche@acm.org>,
"Bean Huo" <beanhuo@micron.com>,
"Stanley Jhu" <stanleyjhu@google.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Thara Gopinath" <thara.gopinath@gmail.com>,
"Daniel Lezcano" <daniel.lezcano@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
"Georgi Djakov" <djakov@kernel.org>,
"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>,
"Ulf Hansson" <ulfh@kernel.org>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev,
linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org,
olteanv@gmail.com
Subject: Re: [PATCH v2 16/16] arm64: dts: qcom: Add Samsung Galaxy XR
Date: Mon, 16 Nov 2026 21:40:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-217738@kernel.org> (raw)
In-Reply-To: <20261116-halliday-dts-v2-16-2c92438c6c46@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: halliday-samsung-xrvst2: invalid chassis-type
value headset
--
commit a88ca65d1f6d17d4cfe0ce907c523f8698e465a8
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>
arm64: dts: qcom: Add Samsung Galaxy XR
This commit adds the device tree for the Qualcomm Halliday-based Samsung
Galaxy XR headset, with initial support for PMICs, keys, USB peripheral mode,
and UFS storage.
> diff --git a/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> new file mode 100644
> index 0000000000000..6fcc1aaafd59c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> @@ -0,0 +1,218 @@
[ ... ]
> +/ {
> + model = "Samsung Galaxy XR";
> + compatible = "samsung,xrvst2", "qcom,halliday";
> + chassis-type = "headset";
[Severity: Low]
Does chassis-type = "headset" fail dtbs_check validation?
The Devicetree Specification and dtschema (schemas/root-node.yaml) restrict
chassis-type to desktop, laptop, convertible, server, tablet, handset, watch,
embedded, television, and all-in-one. Other Qualcomm headset device trees
either omit chassis-type (sm8650-valve-deckard.dts) or use "embedded"
(sar2130p-qar2130p.dts).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-halliday-dts-v2-0-2c92438c6c46@gmail.com?part=16
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-16 21:40 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:26 [PATCH v2 00/16] Add initial support for Qualcomm Halliday and Samsung Galaxy XR Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:26 ` [PATCH v2 01/16] dt-bindings: interrupt-controller: qcom,pdc: Document Halliday PDC Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:29 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 02/16] dt-bindings: power: qcom,rpmpd: document the Halliday RPMh Power Domains Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:30 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 03/16] dt-bindings: mfd: qcom,tcsr: Add Halliday TCSR Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:29 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 04/16] dt-bindings: arm-smmu: Add Halliday SMMU Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:30 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 05/16] dt-bindings: usb: qcom,snps-dwc3: Add Halliday Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:33 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 06/16] dt-bindings: phy: qcom,usb-snps-femto-v2: Add Halliday HS PHY Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:32 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 07/16] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Add Halliday Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:32 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 08/16] dt-bindings: ufs: qcom,sc7180-ufshc: Add Halliday UFS Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:33 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 09/16] dt-bindings: crypto: qcom,inline-crypto-engine: Add Halliday Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:31 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 10/16] dt-bindings: thermal: qcom-tsens: Document the Halliday Temperature Sensor Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:29 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 11/16] dt-bindings: firmware: qcom,scm: Document Halliday SCM Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:31 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 12/16] dt-bindings: arm: qcom: Add Samsung Galaxy XR Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:31 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 13/16] dt-bindings: arm: qcom,ids: Add SoC ID for SXR2250P Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:31 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 14/16] soc: qcom: socinfo: Add SXR2250P SoC ID Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:31 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 15/16] arm64: dts: qcom: Add initial Halliday dtsi Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:41 ` sashiko-bot
2026-11-16 21:26 ` [PATCH v2 16/16] arm64: dts: qcom: Add Samsung Galaxy XR Stanislav Aleksandrov
2026-11-16 21:26 ` Stanislav Aleksandrov
2026-11-16 21:40 ` sashiko-bot [this message]
2026-11-16 21:40 ` sashiko-bot
2026-11-16 21:59 ` Stanislav Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-217738@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abelvesa@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lightofmysoul@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@gurudas.dev \
--cc=lukasz.luba@arm.com \
--cc=mani@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=radu@rendec.net \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robimarko@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rui.zhang@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=stanleyjhu@google.com \
--cc=tglx@kernel.org \
--cc=thara.gopinath@gmail.com \
--cc=ulfh@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vkoul@kernel.org \
--cc=wesley.cheng@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.