All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v2 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver
Date: Tue, 17 Nov 2026 00:53:15 +0000	[thread overview]
Message-ID: <sashiko-outbox-218030@kernel.org> (raw)
In-Reply-To: <20261116-sf19a2890-usb-phy-v2-2-df3ce9d23f5a@telaak.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] phy: siflower: undefined Kconfig dependency
  MACH_SIFLOWER_MIPS
--

commit 202f638a2bcc34b802f82ced18e112090e99c627
Author: Chuanhong Guo <gch981213@gmail.com>

phy: siflower: Add SF19A2890 USB 2.0 PHY driver

This commit adds a driver and Kconfig entry for the Siflower SF19A2890
USB 2.0 PHY.

> diff --git a/drivers/phy/siflower/Kconfig b/drivers/phy/siflower/Kconfig
> new file mode 100644
> index 0000000000000..5ae1f83d14494
> --- /dev/null
> +++ b/drivers/phy/siflower/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config PHY_SF19A2890_USB
> +	tristate "Siflower SF19A2890 USB 2.0 PHY driver"
> +	depends on MACH_SIFLOWER_MIPS || COMPILE_TEST

[Severity: Medium]
Is MACH_SIFLOWER_MIPS defined anywhere in the tree?  Because that Kconfig
symbol does not exist, it evaluates to n and prevents PHY_SF19A2890_USB
from being enabled unless COMPILE_TEST is set.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-sf19a2890-usb-phy-v2-0-df3ce9d23f5a@telaak.dev?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v2 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver
Date: Tue, 17 Nov 2026 00:53:15 +0000	[thread overview]
Message-ID: <sashiko-outbox-218030@kernel.org> (raw)
In-Reply-To: <20261116-sf19a2890-usb-phy-v2-2-df3ce9d23f5a@telaak.dev>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] phy: siflower: undefined Kconfig dependency
  MACH_SIFLOWER_MIPS
--

commit 202f638a2bcc34b802f82ced18e112090e99c627
Author: Chuanhong Guo <gch981213@gmail.com>

phy: siflower: Add SF19A2890 USB 2.0 PHY driver

This commit adds a driver and Kconfig entry for the Siflower SF19A2890
USB 2.0 PHY.

> diff --git a/drivers/phy/siflower/Kconfig b/drivers/phy/siflower/Kconfig
> new file mode 100644
> index 0000000000000..5ae1f83d14494
> --- /dev/null
> +++ b/drivers/phy/siflower/Kconfig
> @@ -0,0 +1,12 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config PHY_SF19A2890_USB
> +	tristate "Siflower SF19A2890 USB 2.0 PHY driver"
> +	depends on MACH_SIFLOWER_MIPS || COMPILE_TEST

[Severity: Medium]
Is MACH_SIFLOWER_MIPS defined anywhere in the tree?  Because that Kconfig
symbol does not exist, it evaluates to n and prevents PHY_SF19A2890_USB
from being enabled unless COMPILE_TEST is set.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-sf19a2890-usb-phy-v2-0-df3ce9d23f5a@telaak.dev?part=2

  reply	other threads:[~2026-11-17  0:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  0:31 [PATCH v2 0/2] phy: Add the Siflower SF19A2890 USB 2.0 PHY Joseph Telaak
2026-11-17  0:31 ` Joseph Telaak via B4 Relay
2026-11-17  0:31 ` Joseph Telaak via B4 Relay
2026-11-17  0:31 ` [PATCH v2 1/2] dt-bindings: phy: Add " Joseph Telaak
2026-11-17  0:31   ` Joseph Telaak via B4 Relay
2026-11-17  0:31   ` Joseph Telaak via B4 Relay
2026-11-17  0:31 ` [PATCH v2 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver Joseph Telaak
2026-11-17  0:31   ` Joseph Telaak via B4 Relay
2026-11-17  0:31   ` Joseph Telaak via B4 Relay
2026-11-17  0:53   ` sashiko-bot [this message]
2026-11-17  0:53     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218030@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joseph@telaak.dev \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.