From: sashiko-bot@kernel.org
To: "Xue Haolin" <xuehaolin@uniontech.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbdev: sstfb: Error out if pixclock equals zero
Date: Tue, 17 Nov 2026 02:32:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-218089@kernel.org> (raw)
In-Reply-To: <20261117022031.252357-1-xuehaolin@uniontech.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] fbdev: sstfb: single-word username in Signed-off-by trailer
- [Low] fbdev: sstfb: unresolvable commit SHA in Fixes trailer
--
commit e66c7f16c1f32c41672200f2d9995e82c7ac0132
Author: xuehaolin <xuehaolin@uniontech.com>
> fbdev: sstfb: Error out if pixclock equals zero
>
> The userspace program could pass any values to the driver through
> ioctl() interface. If the driver doesn't check the value of pixclock,
> it may cause divide-by-zero error.
>
> sstfb_check_var() calls PICOS2KHZ(var->pixclock) which expands to
> 1000000000UL / var->pixclock. If var->pixclock is zero, this causes
> a divide-by-zero exception.
>
> Fix this by checking whether pixclock is zero at the beginning of
> sstfb_check_var(), before it is used as a divisor.
>
> This is similar to CVE-2022-3061 in i740fb which was fixed by
> commit 15cf0b82271b ("video: fbdev: i740fb: Error out if
> 'pixclock' equals zero"), and the fix in savagefb by
> commit 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero").
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
[Severity: Low]
Commit 1da177e4c3f4 ("Linux-2.6.12-rc2") cannot be resolved in the
repository (or only exists in an unfetched historical tree).
> Cc: stable@vger.kernel.org
> Signed-off-by: xuehaolin <xuehaolin@uniontech.com>
[Severity: High]
The Author and Signed-off-by lines use a single-word username (xuehaolin)
rather than a full legal human name, which does not meet the Developer's
Certificate of Origin sign-off requirements in
Documentation/process/submitting-patches.rst.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117022031.252357-1-xuehaolin@uniontech.com?part=1
next prev parent reply other threads:[~2026-11-17 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 2:20 [PATCH] fbdev: sstfb: Error out if pixclock equals zero Xue Haolin
2026-11-17 2:32 ` sashiko-bot [this message]
2026-11-17 3:17 ` [PATCH v2] " Xue Haolin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218089@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xuehaolin@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.