* [PATCH] fbdev: sstfb: Error out if pixclock equals zero
@ 2026-11-17 2:20 Xue Haolin
2026-11-17 2:32 ` sashiko-bot
2026-11-17 3:17 ` [PATCH v2] " Xue Haolin
0 siblings, 2 replies; 3+ messages in thread
From: Xue Haolin @ 2026-11-17 2:20 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, dri-devel, stable, linux-kernel
From: xuehaolin <xuehaolin@uniontech.com>
The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of pixclock,
it may cause divide-by-zero error.
sstfb_check_var() calls PICOS2KHZ(var->pixclock) which expands to
1000000000UL / var->pixclock. If var->pixclock is zero, this causes
a divide-by-zero exception.
Fix this by checking whether pixclock is zero at the beginning of
sstfb_check_var(), before it is used as a divisor.
This is similar to CVE-2022-3061 in i740fb which was fixed by
commit 15cf0b82271b ("video: fbdev: i740fb: Error out if
'pixclock' equals zero"), and the fix in savagefb by
commit 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero").
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: xuehaolin <xuehaolin@uniontech.com>
---
drivers/video/fbdev/sstfb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c
index 8e2c2421028d..de0769eb4a2f 100644
--- a/drivers/video/fbdev/sstfb.c
+++ b/drivers/video/fbdev/sstfb.c
@@ -359,6 +359,9 @@ static int sstfb_check_var(struct fb_var_screeninfo *var,
int tiles_in_X, real_length;
unsigned int freq;
+ if (!var->pixclock)
+ return -EINVAL;
+
if (sst_calc_pll(PICOS2KHZ(var->pixclock), &freq, &par->pll)) {
printk(KERN_ERR "sstfb: Pixclock at %ld KHZ out of range\n",
PICOS2KHZ(var->pixclock));
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fbdev: sstfb: Error out if pixclock equals zero
2026-11-17 2:20 [PATCH] fbdev: sstfb: Error out if pixclock equals zero Xue Haolin
@ 2026-11-17 2:32 ` sashiko-bot
2026-11-17 3:17 ` [PATCH v2] " Xue Haolin
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-17 2:32 UTC (permalink / raw)
To: Xue Haolin; +Cc: dri-devel
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] fbdev: sstfb: single-word username in Signed-off-by trailer
- [Low] fbdev: sstfb: unresolvable commit SHA in Fixes trailer
--
commit e66c7f16c1f32c41672200f2d9995e82c7ac0132
Author: xuehaolin <xuehaolin@uniontech.com>
> fbdev: sstfb: Error out if pixclock equals zero
>
> The userspace program could pass any values to the driver through
> ioctl() interface. If the driver doesn't check the value of pixclock,
> it may cause divide-by-zero error.
>
> sstfb_check_var() calls PICOS2KHZ(var->pixclock) which expands to
> 1000000000UL / var->pixclock. If var->pixclock is zero, this causes
> a divide-by-zero exception.
>
> Fix this by checking whether pixclock is zero at the beginning of
> sstfb_check_var(), before it is used as a divisor.
>
> This is similar to CVE-2022-3061 in i740fb which was fixed by
> commit 15cf0b82271b ("video: fbdev: i740fb: Error out if
> 'pixclock' equals zero"), and the fix in savagefb by
> commit 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero").
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
[Severity: Low]
Commit 1da177e4c3f4 ("Linux-2.6.12-rc2") cannot be resolved in the
repository (or only exists in an unfetched historical tree).
> Cc: stable@vger.kernel.org
> Signed-off-by: xuehaolin <xuehaolin@uniontech.com>
[Severity: High]
The Author and Signed-off-by lines use a single-word username (xuehaolin)
rather than a full legal human name, which does not meet the Developer's
Certificate of Origin sign-off requirements in
Documentation/process/submitting-patches.rst.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117022031.252357-1-xuehaolin@uniontech.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] fbdev: sstfb: Error out if pixclock equals zero
2026-11-17 2:20 [PATCH] fbdev: sstfb: Error out if pixclock equals zero Xue Haolin
2026-11-17 2:32 ` sashiko-bot
@ 2026-11-17 3:17 ` Xue Haolin
1 sibling, 0 replies; 3+ messages in thread
From: Xue Haolin @ 2026-11-17 3:17 UTC (permalink / raw)
To: deller; +Cc: linux-fbdev, dri-devel, stable, linux-kernel
The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of pixclock,
it may cause divide-by-zero error.
sstfb_check_var() calls PICOS2KHZ(var->pixclock) which expands to
1000000000UL / var->pixclock. If var->pixclock is zero, this causes
a divide-by-zero exception.
Fix this by checking whether pixclock is zero at the beginning of
sstfb_check_var(), before it is used as a divisor.
This is similar to CVE-2022-3061 in i740fb which was fixed by
commit 15cf0b82271b ("video: fbdev: i740fb: Error out if
'pixclock' equals zero"), and the fix in savagefb by
commit 04e5eac8f3ab ("fbdev: savage: Error out if pixclock equals zero").
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Xue Haolin <xuehaolin@uniontech.com>
---
Changes in v2:
- Fix sign-off to use real name "Xue Haolin" to satisfy DCO.
drivers/video/fbdev/sstfb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/fbdev/sstfb.c b/drivers/video/fbdev/sstfb.c
index 8e2c2421028d..de0769eb4a2f 100644
--- a/drivers/video/fbdev/sstfb.c
+++ b/drivers/video/fbdev/sstfb.c
@@ -359,6 +359,9 @@ static int sstfb_check_var(struct fb_var_screeninfo *var,
int tiles_in_X, real_length;
unsigned int freq;
+ if (!var->pixclock)
+ return -EINVAL;
+
if (sst_calc_pll(PICOS2KHZ(var->pixclock), &freq, &par->pll)) {
printk(KERN_ERR "sstfb: Pixclock at %ld KHZ out of range\n",
PICOS2KHZ(var->pixclock));
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-17 3:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 2:20 [PATCH] fbdev: sstfb: Error out if pixclock equals zero Xue Haolin
2026-11-17 2:32 ` sashiko-bot
2026-11-17 3:17 ` [PATCH v2] " Xue Haolin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.