All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hongliang Yang" <hongliang.yang@cixtech.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v8 1/2] dt-bindings: phy: Add CIX Sky1 USB3 PHY
Date: Tue, 17 Nov 2026 02:52:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-218097@kernel.org> (raw)
In-Reply-To: <20261117022858.2210212-2-hongliang.yang@cixtech.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: phy: cix,sky1-usb3-phy uses #phy-cells = 0 for
  two-lane PHY
--

commit c8a29919e01294d52dd3eac0bc1ce8854b5d00a0
Author: Hongliang Yang <hongliang.yang@cixtech.com>

dt-bindings: phy: Add CIX Sky1 USB3 PHY

This commit adds the Device Tree binding schema for the CIX Sky1 USB3
SuperSpeedPlus PHY and updates MAINTAINERS.

> diff --git a/Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml
> new file mode 100644
> index 0000000000000..205140bf84e7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/cix,sky1-usb3-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CIX Sky1 USB3 PHY
> +
> +maintainers:
> +  - Hongliang Yang <hongliang.yang@cixtech.com>
> +
> +description: |
> +  The CIX Sky1 USB3 PHY provides the SuperSpeed lanes of the USB3 Type-A
> +  ports of the SoC.
> +
> +  Both lanes are programmed through one register block and share the
> +  same clocks and resets, so the node is a single PHY provider with
> +  #phy-cells = <0> that all consumers reference. The driver reference
> +  counts phy_init() and phy_exit(), so the block is set up once for all
> +  its consumers.
> +
> +properties:
> +  compatible:
> +    const: cix,sky1-usb3-phy
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#phy-cells":
> +    const: 0

[Severity: Low]
As reported by Krzysztof Kozlowski on v6 [1], shouldn't #phy-cells be 1
instead of 0 so that each USB3 controller consumer node can specify which
of the two PHY lanes it is connected to?

The hardware block has two distinct lanes with separate per-lane register
sets serving two independent USB3 controllers. Locking #phy-cells to 0
omits the per-lane routing from the Device Tree ABI and prevents any
future per-lane control or tuning without breaking the binding. Also, the
description references Linux driver internals (phy_init() and phy_exit()
reference counting) rather than strictly describing the hardware.

[1] https://lore.kernel.org/r/20261105-kind-macaque-of-enhancement-ee0365@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117022858.2210212-1-hongliang.yang@cixtech.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Hongliang Yang" <hongliang.yang@cixtech.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v8 1/2] dt-bindings: phy: Add CIX Sky1 USB3 PHY
Date: Tue, 17 Nov 2026 02:52:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-218097@kernel.org> (raw)
In-Reply-To: <20261117022858.2210212-2-hongliang.yang@cixtech.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: phy: cix,sky1-usb3-phy uses #phy-cells = 0 for
  two-lane PHY
--

commit c8a29919e01294d52dd3eac0bc1ce8854b5d00a0
Author: Hongliang Yang <hongliang.yang@cixtech.com>

dt-bindings: phy: Add CIX Sky1 USB3 PHY

This commit adds the Device Tree binding schema for the CIX Sky1 USB3
SuperSpeedPlus PHY and updates MAINTAINERS.

> diff --git a/Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml b/Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml
> new file mode 100644
> index 0000000000000..205140bf84e7c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/cix,sky1-usb3-phy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: CIX Sky1 USB3 PHY
> +
> +maintainers:
> +  - Hongliang Yang <hongliang.yang@cixtech.com>
> +
> +description: |
> +  The CIX Sky1 USB3 PHY provides the SuperSpeed lanes of the USB3 Type-A
> +  ports of the SoC.
> +
> +  Both lanes are programmed through one register block and share the
> +  same clocks and resets, so the node is a single PHY provider with
> +  #phy-cells = <0> that all consumers reference. The driver reference
> +  counts phy_init() and phy_exit(), so the block is set up once for all
> +  its consumers.
> +
> +properties:
> +  compatible:
> +    const: cix,sky1-usb3-phy
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#phy-cells":
> +    const: 0

[Severity: Low]
As reported by Krzysztof Kozlowski on v6 [1], shouldn't #phy-cells be 1
instead of 0 so that each USB3 controller consumer node can specify which
of the two PHY lanes it is connected to?

The hardware block has two distinct lanes with separate per-lane register
sets serving two independent USB3 controllers. Locking #phy-cells to 0
omits the per-lane routing from the Device Tree ABI and prevents any
future per-lane control or tuning without breaking the binding. Also, the
description references Linux driver internals (phy_init() and phy_exit()
reference counting) rather than strictly describing the hardware.

[1] https://lore.kernel.org/r/20261105-kind-macaque-of-enhancement-ee0365@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117022858.2210212-1-hongliang.yang@cixtech.com?part=1

  reply	other threads:[~2026-11-17  2:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:28 [PATCH v8 0/2] phy: Add CIX Sky1 USB3 PHY support Hongliang Yang
2026-11-17  2:28 ` Hongliang Yang
2026-11-17  2:28 ` [PATCH v8 1/2] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang
2026-11-17  2:28   ` Hongliang Yang
2026-11-17  2:52   ` sashiko-bot [this message]
2026-11-17  2:52     ` sashiko-bot
2026-11-17  2:28 ` [PATCH v8 2/2] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-11-17  2:28   ` Hongliang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218097@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hongliang.yang@cixtech.com \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.