From: sashiko-bot@kernel.org
To: "Peng Fan" <peng.fan@linux.dev>
Cc: imx@lists.linux.dev, Frank.Li@kernel.org
Subject: Re: [PATCH 5/8] irqchip/imx-intmux: Mark input interrupts as level-triggered
Date: Tue, 17 Nov 2026 07:22:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-218320@kernel.org> (raw)
In-Reply-To: <20261117-imx-intmux-v1-5-189e7e0ad98d@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] irqchip/imx-intmux: missing Fixes trailer for IRQ_LEVEL fix
--
commit 16ad01e929ba768146f616b1aa477818ab9093de
Author: Peng Fan <peng.fan@nxp.com>
> irqchip/imx-intmux: Mark input interrupts as level-triggered
>
> The child interrupts are handled by handle_level_irq() and xlate()
> advertises IRQ_TYPE_LEVEL_HIGH, but the descriptors are not marked
> IRQ_LEVEL. Apart from the inconsistency, the flag feeds IRQD_LEVEL,
> which makes check_irq_resend() skip replaying level interrupts.
>
> Set IRQ_LEVEL in the map callback.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
[Severity: Low]
Since this fixes the missing level trigger flag present since the driver was
introduced, should it include a Fixes tag?
Fixes: 2fbb13961e74 ("irqchip: Add NXP INTMUX interrupt multiplexer support")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-imx-intmux-v1-0-189e7e0ad98d@nxp.com?part=5
next prev parent reply other threads:[~2026-11-17 7:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:14 [PATCH 0/8] irqchip/imx-intmux: Fix and modernize resource management Peng Fan
2026-11-17 7:14 ` [PATCH 1/8] irqchip/imx-intmux: Fix probe error path Peng Fan
2026-11-17 7:26 ` sashiko-bot
2026-11-17 7:14 ` [PATCH 2/8] irqchip/imx-intmux: Dispose IRQ mappings on remove Peng Fan
2026-11-17 7:14 ` [PATCH 3/8] irqchip/imx-intmux: Handle platform_irq_count() errors Peng Fan
2026-11-17 7:26 ` sashiko-bot
2026-11-17 7:14 ` [PATCH 4/8] irqchip/imx-intmux: Don't WARN on malformed interrupt specifiers Peng Fan
2026-11-17 7:14 ` [PATCH 5/8] irqchip/imx-intmux: Mark input interrupts as level-triggered Peng Fan
2026-11-17 7:22 ` sashiko-bot [this message]
2026-11-17 7:14 ` [PATCH 6/8] irqchip/imx-intmux: Use devm_clk_get_enabled() Peng Fan
2026-11-17 7:28 ` sashiko-bot
2026-11-17 7:14 ` [PATCH 7/8] irqchip/imx-intmux: Use devm_irq_domain_create_linear() Peng Fan
2026-11-17 7:14 ` [PATCH 8/8] irqchip/imx-intmux: Use devm_pm_runtime_set_active_enabled() Peng Fan
2026-11-17 7:38 ` sashiko-bot
2026-11-17 13:27 ` [PATCH 0/8] irqchip/imx-intmux: Fix and modernize resource management Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218320@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=imx@lists.linux.dev \
--cc=peng.fan@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.