From: sashiko-bot@kernel.org
To: "Peng Fan" <peng.fan@linux.dev>
Cc: imx@lists.linux.dev, Frank.Li@kernel.org
Subject: Re: [PATCH 1/8] irqchip/imx-intmux: Fix probe error path
Date: Tue, 17 Nov 2026 07:26:54 +0000 [thread overview]
Message-ID: <sashiko-outbox-218340@kernel.org> (raw)
In-Reply-To: <20261117-imx-intmux-v1-1-189e7e0ad98d@nxp.com>
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] irqchip/imx-intmux: missing irq_dispose_mapping() in
imx_intmux_remove() [1]
--
commit 86b73ac3be694b14f9c6ebf1c3858d6acbcde2d7
Author: Peng Fan <peng.fan@nxp.com>
irqchip/imx-intmux: Fix probe error path
This commit unwinds initialized channels, IRQ mappings, and runtime PM on
probe failure in imx_intmux_probe(), and enables the IPG clock before
enabling runtime PM.
> diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c
> index c7914fea3d1f9..a9eda7646e2fe 100644
> --- a/drivers/irqchip/irq-imx-intmux.c
> +++ b/drivers/irqchip/irq-imx-intmux.c
[ ... ]
> @@ -281,6 +282,17 @@ static int imx_intmux_probe(struct platform_device *pdev)
>
> return 0;
> out:
> + while (i--) {
> + irq_set_chained_handler_and_data(data->irqchip_data[i].irq,
> + NULL, NULL);
> + for (unsigned int hwirq = 0; hwirq < 32; hwirq++)
> + irq_dispose_mapping(irq_find_mapping(data->irqchip_data[i].domain,
> + hwirq));
> + irq_domain_remove(data->irqchip_data[i].domain);
> + irq_dispose_mapping(data->irqchip_data[i].irq);
> + }
[Severity: Medium]
This problem wasn't introduced by this patch, but does imx_intmux_remove()
also leak the parent IRQ mappings [1]? imx_intmux_remove() clears
the chained handlers and removes the child domains, but never calls
irq_dispose_mapping(data->irqchip_data[i].irq) for the parent IRQs mapped
by irq_of_parse_and_map() during probe.
[1] https://sashiko.dev/#/bug/linux-1cb10b02-3764-4fe8-975c-f222a75eec4b
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-imx-intmux-v1-0-189e7e0ad98d@nxp.com?part=1
next prev parent reply other threads:[~2026-11-17 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:14 [PATCH 0/8] irqchip/imx-intmux: Fix and modernize resource management Peng Fan
2026-11-17 7:14 ` [PATCH 1/8] irqchip/imx-intmux: Fix probe error path Peng Fan
2026-11-17 7:26 ` sashiko-bot [this message]
2026-11-17 7:14 ` [PATCH 2/8] irqchip/imx-intmux: Dispose IRQ mappings on remove Peng Fan
2026-11-17 7:14 ` [PATCH 3/8] irqchip/imx-intmux: Handle platform_irq_count() errors Peng Fan
2026-11-17 7:26 ` sashiko-bot
2026-11-17 7:14 ` [PATCH 4/8] irqchip/imx-intmux: Don't WARN on malformed interrupt specifiers Peng Fan
2026-11-17 7:14 ` [PATCH 5/8] irqchip/imx-intmux: Mark input interrupts as level-triggered Peng Fan
2026-11-17 7:22 ` sashiko-bot
2026-11-17 7:14 ` [PATCH 6/8] irqchip/imx-intmux: Use devm_clk_get_enabled() Peng Fan
2026-11-17 7:28 ` sashiko-bot
2026-11-17 7:14 ` [PATCH 7/8] irqchip/imx-intmux: Use devm_irq_domain_create_linear() Peng Fan
2026-11-17 7:14 ` [PATCH 8/8] irqchip/imx-intmux: Use devm_pm_runtime_set_active_enabled() Peng Fan
2026-11-17 7:38 ` sashiko-bot
2026-11-17 13:27 ` [PATCH 0/8] irqchip/imx-intmux: Fix and modernize resource management Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218340@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=imx@lists.linux.dev \
--cc=peng.fan@linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.