From: sashiko-bot@kernel.org
To: "Vijendar Mukunda" <Vijendar.Mukunda@amd.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH v6 07/23] soundwire: amd: remove STATUS_8TO11 clear from amd_sdw_process_wake_event()
Date: Tue, 17 Nov 2026 07:26:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-218337@kernel.org> (raw)
In-Reply-To: <20261117070906.803139-8-Vijendar.Mukunda@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] soundwire: amd: inaccurate Fixes trailer in
amd_sdw_process_wake_event() change
--
commit 37e17ac67e68c6f83de067cdc5e343eec8f2c9c9
Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> soundwire: amd: remove STATUS_8TO11 clear from amd_sdw_process_wake_event()
>
> amd_sdw_irq_thread() falls through after handling a wake event to
> process any coalesced PREQ or peripheral status events, rather than
> returning early. With the fall-through in place, both
> amd_sdw_process_wake_event() and the tail of amd_sdw_irq_thread() write
> 0x00 to ACP_SW_STATE_CHANGE_STATUS_8TO11 in the same invocation.
> Any status bit asserted by hardware between those two writes would be
> lost before the next invocation reads the register.
>
> Remove the writel() from amd_sdw_process_wake_event() so that
> ACP_SW_STATE_CHANGE_STATUS_8TO11 is cleared exactly once per invocation
> by the tail of amd_sdw_irq_thread().
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> Fixes: 66c878838f37 ("soundwire: amd: handle SoundWire wake enable interrupt")
[Severity: Low]
Is the Fixes tag pointing at the right commit?
In 66c878838f37 ("soundwire: amd: handle SoundWire wake enable interrupt"),
amd_sdw_irq_thread() returned early via amd_sdw_process_wake_event(), so
ACP_SW_STATE_CHANGE_STATUS_8TO11 was only cleared once. The fall-through
that causes the duplicate write was introduced by the preceding patch in
this series, commit "soundwire: amd: fix IRQ thread dropping STATUS_0TO7
on simultaneous wake".
If this patch is backported to a tree with 66c878838f37 ("soundwire: amd:
handle SoundWire wake enable interrupt") without that preceding commit,
amd_sdw_irq_thread() will return early on a wake event without clearing
ACP_SW_STATE_CHANGE_STATUS_8TO11 at all. Should the Fixes tag be dropped
or this change squashed into the preceding patch?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117070906.803139-1-Vijendar.Mukunda@amd.com?part=7
next prev parent reply other threads:[~2026-11-17 7:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:05 [PATCH v6 00/23] soundwire: amd: SoundWire manager driver bug fixes Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 01/23] soundwire: amd: consolidate pad register macros into amd_init.h Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 02/23] soundwire: amd: program pad SCHMEN and OE control for ACP 7.0/7.1/7.2 Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 03/23] soundwire: amd: add pad ctrl helpers for D0/D3 PM transitions Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 04/23] soundwire: amd: track full pad teardown across suspend/resume Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 05/23] soundwire: amd: fix missing wake interrupt and group wake-arming calls in runtime suspend Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 06/23] soundwire: amd: fix IRQ thread dropping STATUS_0TO7 on simultaneous wake Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 07/23] soundwire: amd: remove STATUS_8TO11 clear from amd_sdw_process_wake_event() Vijendar Mukunda
2026-11-17 7:26 ` sashiko-bot [this message]
2026-11-17 9:33 ` Mukunda,Vijendar
2026-11-17 7:05 ` [PATCH v6 08/23] soundwire: amd: fix missing wake interrupt for ACP6.3 in POWER_OFF suspend Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 09/23] soundwire: amd: fix SDW command timeout return value handling Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 10/23] soundwire: amd: cache ping slave status to avoid spurious disconnect on timeout Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 11/23] soundwire: amd: assert msg_lock is held in amd_sdw_read_ping_status() Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 12/23] soundwire: amd: fix work drain ordering in remove path Vijendar Mukunda
2026-11-17 7:30 ` sashiko-bot
2026-11-17 10:03 ` Mukunda,Vijendar
2026-11-17 7:05 ` [PATCH v6 13/23] soundwire: amd: defer dev_set_drvdata() until after INIT_WORK() Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 14/23] soundwire: amd: pm_runtime guard in remove path Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 15/23] soundwire: amd: use interrupt_enabled flag to guard IRQ work scheduling Vijendar Mukunda
2026-11-17 7:37 ` sashiko-bot
2026-11-17 10:23 ` Mukunda,Vijendar
2026-11-17 7:05 ` [PATCH v6 16/23] soundwire: amd: delay *sdw_ctx publication until after startup succeeds Vijendar Mukunda
2026-11-17 7:31 ` sashiko-bot
2026-11-17 13:14 ` Mukunda,Vijendar
2026-11-17 7:05 ` [PATCH v6 17/23] soundwire: amd: propagate amd_init_sdw_manager() error on resume Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 18/23] soundwire: amd: drop amd_deinit_sdw_manager() in POWER_OFF suspend Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 19/23] soundwire: amd: replace >= ACP70 with explicit switch/case in PM paths Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 20/23] soundwire: amd: fix interrupt gate and work drain ordering in PM ops Vijendar Mukunda
2026-11-17 7:48 ` sashiko-bot
2026-11-17 12:29 ` Mukunda,Vijendar
2026-11-17 7:05 ` [PATCH v6 21/23] soundwire: amd: check for NULL manager drvdata in sdw_amd_startup() Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 22/23] soundwire: amd: fix shared-register RMW race in amd_sdw_set_device_state() Vijendar Mukunda
2026-11-17 7:05 ` [PATCH v6 23/23] soundwire: amd: fix shared-register RMW race in amd_sdw_host_wake_enable() Vijendar Mukunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218337@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Vijendar.Mukunda@amd.com \
--cc=linux-sound@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.