All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vijendar Mukunda" <Vijendar.Mukunda@amd.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH v6 12/23] soundwire: amd: fix work drain ordering in remove path
Date: Tue, 17 Nov 2026 07:30:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-218350@kernel.org> (raw)
In-Reply-To: <20261117070906.803139-13-Vijendar.Mukunda@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] soundwire: amd: unsynchronized in-flight IRQ in
  amd_sdw_manager_remove()
--

commit 3506edf69d0fb093063647130bfc49c4745d7c81
Author: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

soundwire: amd: fix work drain ordering in remove path

This commit masks SoundWire interrupts before cancelling amd_sdw_irq_thread
and amd_sdw_work in amd_sdw_manager_remove().

> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> index 9715e2eb22498..44ef45ba943bc 100644
> --- a/drivers/soundwire/amd_manager.c
> +++ b/drivers/soundwire/amd_manager.c
> @@ -1265,8 +1265,9 @@ static void amd_sdw_manager_remove(struct platform_device *pdev)
>  	int ret;
>  
>  	pm_runtime_disable(&pdev->dev);
> -	cancel_work_sync(&amd_manager->amd_sdw_work);
>  	amd_disable_sdw_interrupts(amd_manager);
> +	cancel_work_sync(&amd_manager->amd_sdw_irq_thread);
> +	cancel_work_sync(&amd_manager->amd_sdw_work);
>  	sdw_bus_master_delete(&amd_manager->bus);
>  	ret = amd_disable_sdw_manager(amd_manager);
>  	if (ret)

[Severity: Medium]
Can an in-flight parent hard IRQ handler queue amd_sdw_irq_thread after
cancel_work_sync() returns?

The commit message notes that an IRQ handler already in flight may still
queue amd_sdw_irq_thread and relies on cancel_work_sync() to drain it
without synchronize_irq().  However, cancel_work_sync() only cancels or
waits for work that is already pending or running when checked, and leaves
the work item enabled on return.  When the amd_sdw_manager platform device
is unbound via sysfs while the parent ACP PCI IRQ remains active, an IRQ
that fired just before amd_disable_sdw_interrupts() can still schedule the
work item after both cancel_work_sync() calls finish:

sound/soc/amd/ps/pci-ps.c:acp63_irq_handler() {
	...
	if (ext_intr_stat & ACP_SDW0_STAT) {
		writel(ACP_SDW0_STAT, adata->acp63_base + ACP_EXTERNAL_INTR_STAT);
		if (adata->sdw) {
			amd_manager = dev_get_drvdata(&adata->sdw->pdev[0]->dev);
			if (amd_manager)
				schedule_work(&amd_manager->amd_sdw_irq_thread);
		}
		irq_flag = 1;
	}
	...
}

CPU0                                    CPU1
amd_sdw_manager_remove()                acp63_irq_handler()
                                          ext_intr_stat & ACP_SDW0_STAT
                                          amd_manager = dev_get_drvdata(...)
  amd_disable_sdw_interrupts()
  cancel_work_sync(...irq_thread)
  cancel_work_sync(...amd_sdw_work)
                                          schedule_work(...irq_thread)
  sdw_bus_master_delete()
  ...
devres_release_all()
  /* frees amd_manager */
                                        amd_sdw_irq_thread()
                                          readl(amd_manager->mmio + ...)
                                          <-- use-after-free

Even with commit "soundwire: amd: use interrupt_enabled flag to guard IRQ
work scheduling" later in the series, acp63_irq_handler() and
acp_irq_handler() still call schedule_work(&amd_manager->amd_sdw_irq_thread)
unconditionally.  Using disable_work_sync() in amd_sdw_manager_remove() (or
synchronizing with the parent IRQ after masking) would prevent the work
items from being queued again during teardown.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117070906.803139-1-Vijendar.Mukunda@amd.com?part=12

  reply	other threads:[~2026-11-17  7:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  7:05 [PATCH v6 00/23] soundwire: amd: SoundWire manager driver bug fixes Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 01/23] soundwire: amd: consolidate pad register macros into amd_init.h Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 02/23] soundwire: amd: program pad SCHMEN and OE control for ACP 7.0/7.1/7.2 Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 03/23] soundwire: amd: add pad ctrl helpers for D0/D3 PM transitions Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 04/23] soundwire: amd: track full pad teardown across suspend/resume Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 05/23] soundwire: amd: fix missing wake interrupt and group wake-arming calls in runtime suspend Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 06/23] soundwire: amd: fix IRQ thread dropping STATUS_0TO7 on simultaneous wake Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 07/23] soundwire: amd: remove STATUS_8TO11 clear from amd_sdw_process_wake_event() Vijendar Mukunda
2026-11-17  7:26   ` sashiko-bot
2026-11-17  9:33     ` Mukunda,Vijendar
2026-11-17  7:05 ` [PATCH v6 08/23] soundwire: amd: fix missing wake interrupt for ACP6.3 in POWER_OFF suspend Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 09/23] soundwire: amd: fix SDW command timeout return value handling Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 10/23] soundwire: amd: cache ping slave status to avoid spurious disconnect on timeout Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 11/23] soundwire: amd: assert msg_lock is held in amd_sdw_read_ping_status() Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 12/23] soundwire: amd: fix work drain ordering in remove path Vijendar Mukunda
2026-11-17  7:30   ` sashiko-bot [this message]
2026-11-17 10:03     ` Mukunda,Vijendar
2026-11-17  7:05 ` [PATCH v6 13/23] soundwire: amd: defer dev_set_drvdata() until after INIT_WORK() Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 14/23] soundwire: amd: pm_runtime guard in remove path Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 15/23] soundwire: amd: use interrupt_enabled flag to guard IRQ work scheduling Vijendar Mukunda
2026-11-17  7:37   ` sashiko-bot
2026-11-17 10:23     ` Mukunda,Vijendar
2026-11-17  7:05 ` [PATCH v6 16/23] soundwire: amd: delay *sdw_ctx publication until after startup succeeds Vijendar Mukunda
2026-11-17  7:31   ` sashiko-bot
2026-11-17 13:14     ` Mukunda,Vijendar
2026-11-17  7:05 ` [PATCH v6 17/23] soundwire: amd: propagate amd_init_sdw_manager() error on resume Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 18/23] soundwire: amd: drop amd_deinit_sdw_manager() in POWER_OFF suspend Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 19/23] soundwire: amd: replace >= ACP70 with explicit switch/case in PM paths Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 20/23] soundwire: amd: fix interrupt gate and work drain ordering in PM ops Vijendar Mukunda
2026-11-17  7:48   ` sashiko-bot
2026-11-17 12:29     ` Mukunda,Vijendar
2026-11-17  7:05 ` [PATCH v6 21/23] soundwire: amd: check for NULL manager drvdata in sdw_amd_startup() Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 22/23] soundwire: amd: fix shared-register RMW race in amd_sdw_set_device_state() Vijendar Mukunda
2026-11-17  7:05 ` [PATCH v6 23/23] soundwire: amd: fix shared-register RMW race in amd_sdw_host_wake_enable() Vijendar Mukunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218350@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.