From: sashiko-bot@kernel.org
To: "Christian Brauner" <brauner@kernel.org>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH 3/3] jfs: refuse inodes with a negative size
Date: Tue, 17 Nov 2026 09:51:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-218536@kernel.org> (raw)
In-Reply-To: <20261116-work-fs-sb_rdonly-fixes-v1-3-95a25ce917ad@kernel.org>
> copy_from_dinode() takes di_size as is and a crafted image can store a
> size that is negative as a loff_t. For a symlink that passes the signed
> i_size >= IDATASIZE test in jfs_iget(), so it's treated as a fast
> symlink and i_link[i_size] = '\0' writes out of bounds. Refuse a
> negative size when reading the inode like a corrupt dtroot.
>
> Fixes: d69e83d99cf8 ("jfs: ensure symlinks are NUL-terminated")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-work-fs-sb_rdonly-fixes-v1-0-95a25ce917ad@kernel.org?part=3
prev parent reply other threads:[~2026-11-17 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 9:28 [PATCH 0/3] fs: pre-existing fixes for the SB_RDONLY series Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-16 9:28 ` [PATCH 1/3] gfs2: don't BUG when remounting read-only after a withdraw during mount Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-17 9:51 ` sashiko-bot
2026-11-17 9:51 ` sashiko-bot
2026-11-16 9:28 ` [PATCH 2/3] exfat: keep the volume marked dirty after a shutdown Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-17 9:51 ` sashiko-bot
2026-11-17 9:51 ` sashiko-bot
2026-11-16 9:28 ` [PATCH 3/3] jfs: refuse inodes with a negative size Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-17 9:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218536@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=brauner@kernel.org \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.