From: sashiko-bot@kernel.org
To: "Christian Brauner" <brauner@kernel.org>
Cc: "Jan Kara" <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org,
dsterba@suse.cz, tytso@mit.edu, "Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH 2/3] exfat: keep the volume marked dirty after a shutdown
Date: Tue, 17 Nov 2026 09:51:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-218535@kernel.org> (raw)
In-Reply-To: <20261116-work-fs-sb_rdonly-fixes-v1-2-95a25ce917ad@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] exfat: Fixes trailer cites f761fcdd289d instead of 46a557694b46
--
commit a1d3dffdfc2b9385cf2e9ba0e7b99bd916f22ffa
Author: Christian Brauner <brauner@kernel.org>
> exfat: keep the volume marked dirty after a shutdown
>
> After a shutdown exfat_write_inode() and exfat_writepages() drop
> whatever is still dirty. But exfat_put_super() and a remount to
> read-only still clear VOLUME_DIRTY through exfat_set_vol_flags() which
> only leaves the boot sector alone on a read-only superblock. So after a
> shutdown with EXFAT_GOING_DOWN_NOSYNC the volume ends up marked clean
> although it may be inconsistent. Leave the boot sector alone after a
> shutdown too.
>
> Fixes: f761fcdd289d ("exfat: Implement sops->shutdown and ioctl")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
[Severity: Low]
Should the Fixes tag reference 46a557694b46 ("exfat: do not clear volume
dirty flag during sync") instead?
In f761fcdd289d ("exfat: Implement sops->shutdown and ioctl"),
exfat_clear_volume_dirty() was only called from exfat_sync_fs(), which
returned early on exfat_forced_shutdown(sb). It was 46a557694b46
("exfat: do not clear volume dirty flag during sync") that removed
exfat_sync_fs() along with its shutdown check and moved the
exfat_clear_volume_dirty() calls into exfat_put_super() and
exfat_reconfigure().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-work-fs-sb_rdonly-fixes-v1-0-95a25ce917ad@kernel.org?part=2
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Christian Brauner" <brauner@kernel.org>
Cc: "Jan Kara" <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-mm@kvack.org,
linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org,
dsterba@suse.cz, tytso@mit.edu, "Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH 2/3] exfat: keep the volume marked dirty after a shutdown
Date: Tue, 17 Nov 2026 09:51:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-218535@kernel.org> (raw)
In-Reply-To: <20261116-work-fs-sb_rdonly-fixes-v1-2-95a25ce917ad@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] exfat: Fixes trailer cites f761fcdd289d instead of 46a557694b46
--
commit a1d3dffdfc2b9385cf2e9ba0e7b99bd916f22ffa
Author: Christian Brauner <brauner@kernel.org>
> exfat: keep the volume marked dirty after a shutdown
>
> After a shutdown exfat_write_inode() and exfat_writepages() drop
> whatever is still dirty. But exfat_put_super() and a remount to
> read-only still clear VOLUME_DIRTY through exfat_set_vol_flags() which
> only leaves the boot sector alone on a read-only superblock. So after a
> shutdown with EXFAT_GOING_DOWN_NOSYNC the volume ends up marked clean
> although it may be inconsistent. Leave the boot sector alone after a
> shutdown too.
>
> Fixes: f761fcdd289d ("exfat: Implement sops->shutdown and ioctl")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
[Severity: Low]
Should the Fixes tag reference 46a557694b46 ("exfat: do not clear volume
dirty flag during sync") instead?
In f761fcdd289d ("exfat: Implement sops->shutdown and ioctl"),
exfat_clear_volume_dirty() was only called from exfat_sync_fs(), which
returned early on exfat_forced_shutdown(sb). It was 46a557694b46
("exfat: do not clear volume dirty flag during sync") that removed
exfat_sync_fs() along with its shutdown check and moved the
exfat_clear_volume_dirty() calls into exfat_put_super() and
exfat_reconfigure().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-work-fs-sb_rdonly-fixes-v1-0-95a25ce917ad@kernel.org?part=2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-11-17 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 9:28 [PATCH 0/3] fs: pre-existing fixes for the SB_RDONLY series Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-16 9:28 ` [PATCH 1/3] gfs2: don't BUG when remounting read-only after a withdraw during mount Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-17 9:51 ` sashiko-bot
2026-11-17 9:51 ` sashiko-bot
2026-11-16 9:28 ` [PATCH 2/3] exfat: keep the volume marked dirty after a shutdown Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-17 9:51 ` sashiko-bot [this message]
2026-11-17 9:51 ` sashiko-bot
2026-11-16 9:28 ` [PATCH 3/3] jfs: refuse inodes with a negative size Christian Brauner
2026-11-16 9:28 ` Christian Brauner
2026-11-17 9:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218535@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=brauner@kernel.org \
--cc=dsterba@suse.cz \
--cc=jack@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark@fasheh.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.