* [PATCH v4 0/2] perf/core: Fix sigtrap task_work races @ 2026-11-17 11:28 Tengda Wu 2026-11-17 11:28 ` [PATCH v4 1/2] perf/core: Prevent duplicate sigtrap task work enqueue Tengda Wu 2026-11-17 11:28 ` [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events Tengda Wu 0 siblings, 2 replies; 6+ messages in thread From: Tengda Wu @ 2026-11-17 11:28 UTC (permalink / raw) To: Peter Zijlstra, Sebastian Andrzej Siewior Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark, linux-perf-users, linux-kernel, Tengda Wu Two fixes for sigtrap task_work handling since the switch to always enqueue SIGTRAP via task_work. The warning splats and PoCs for both patches are too long to inline in the commit messages, so they are provided as separate replies at the following links: Patch 1: https://lore.kernel.org/all/29aa123c-36a2-460f-b76b-a8dfe1eb542f@huaweicloud.com/ Patch 2: https://lore.kernel.org/all/d1b24bbf-9111-4766-87c8-ff97adcac727@huaweicloud.com/ Patch 1 fixes a re-entrancy race in __perf_event_overflow(): pending_work was set only after task_work_add(), so an NMI could re-enter and enqueue the same pending_task twice, creating a cycle in the task work list and unbalancing the event refcount. Claim pending_work before enqueuing, and clear it if the enqueue fails. Patch 2 fixes a WARN_ON_ONCE() in perf_sigtrap() triggered by the context fast-swap path swapping ctx->task while a sigtrap event has pending task work. SIGTRAP is targeted at ctx->task, so exclude sigtrap events from fast-swap alongside inherit+sample-read events. Changelog ========= v3 -> v4: - v3: https://lore.kernel.org/all/cover.1793870900.git.wutengda@huaweicloud.com/ - Patch 1: Use acquire/release pairs for pending_work updates (Sebastian) - Patch 2: Remove redundant nr_no_switch_fast updates (Sebastian) v2 -> v3: - v2: https://lore.kernel.org/all/20261102021355.650671-1-wutengda@huaweicloud.com/ - Added Patch 2 to fix WARN_ON_ONCE() in perf_sigtrap() v1 -> v2: - v1: https://lore.kernel.org/all/20261031114520.642476-1-wutengda@huaweicloud.com/ - Drop the redundant event->pending_work assignment. (Sashiko) Tengda Wu (2): perf/core: Prevent duplicate sigtrap task work enqueue perf/core: Disable context fast-swap for sigtrap events include/linux/perf_event.h | 8 +++---- kernel/events/core.c | 48 +++++++++++++++++++++++++------------- 2 files changed, 35 insertions(+), 21 deletions(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4 1/2] perf/core: Prevent duplicate sigtrap task work enqueue 2026-11-17 11:28 [PATCH v4 0/2] perf/core: Fix sigtrap task_work races Tengda Wu @ 2026-11-17 11:28 ` Tengda Wu 2026-11-17 11:47 ` sashiko-bot 2026-11-17 11:28 ` [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events Tengda Wu 1 sibling, 1 reply; 6+ messages in thread From: Tengda Wu @ 2026-11-17 11:28 UTC (permalink / raw) To: Peter Zijlstra, Sebastian Andrzej Siewior Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark, linux-perf-users, linux-kernel, Tengda Wu The sigtrap handling in __perf_event_overflow() checks event->pending_work before calling task_work_add(), but only sets pending_work after the task work has been queued. This leaves a window where an NMI can interrupt task_work_add() and re-enter __perf_event_overflow() for the same event. Since pending_work is still zero, the nested invocation can enqueue the same pending_task again. The re-entrant call path looks like this: __perf_event_overflow() task_work_add() kasan_record_aux_stack() <NMI> __perf_event_overflow() task_work_add() The nested invocation may enqueue pending_task before the outer invocation does. When the outer invocation resumes, it inserts the same task work entry again, potentially creating a cycle in the task work list. As a result, perf_pending_task() may be executed repeatedly, leading to unbalanced event reference counting. Fix this by atomically claiming pending_work with cmpxchg_acquire() before calling task_work_add(). This ensures that only one invocation can enqueue the task work, even when another overflow occurs re-entrantly from an NMI. If task_work_add() fails, clear the claim with smp_store_release() to allow a subsequent overflow to retry. In perf_pending_task(), defer clearing pending_work until after perf_sigtrap() has completed. Use smp_store_release() to ensure that a subsequent overflow cannot re-queue the task work before the previous invocation has finished handling it. Also use smp_load_acquire() when checking pending_work in the exclude_kernel warning path to ensure the read is properly ordered. Fixes: c5d93d23a260 ("perf: Enqueue SIGTRAP always via task_work.") Signed-off-by: Tengda Wu <wutengda@huaweicloud.com> --- kernel/events/core.c | 39 ++++++++++++++++++++++++++------------- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 614f9f0e6500..857230b023ae 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7775,10 +7775,14 @@ static void perf_pending_task(struct callback_head *head) */ rctx = perf_swevent_get_recursion_context(); - if (event->pending_work) { - event->pending_work = 0; + if (smp_load_acquire(&event->pending_work)) { perf_sigtrap(event); local_dec(&event->ctx->nr_no_switch_fast); + /* + * Ensure the pending work is fully handled before allowing + * another overflow to queue it. See __perf_event_overflow(). + */ + smp_store_release(&event->pending_work, 0); } put_event(event); @@ -10950,16 +10954,25 @@ static int __perf_event_overflow(struct perf_event *event, notify_mode = in_nmi() ? TWA_NMI_CURRENT : TWA_RESUME; - if (!event->pending_work && - !task_work_add(current, &event->pending_task, notify_mode)) { - event->pending_work = pending_id; - local_inc(&event->ctx->nr_no_switch_fast); - WARN_ON_ONCE(!atomic_long_inc_not_zero(&event->refcount)); - - event->pending_addr = 0; - if (valid_sample && (data->sample_flags & PERF_SAMPLE_ADDR)) - event->pending_addr = data->addr; - + /* + * Claim pending_work before queueing the task work to prevent + * another overflow from queueing it concurrently. + */ + if (cmpxchg_acquire(&event->pending_work, 0, pending_id) == 0) { + if (!task_work_add(current, &event->pending_task, notify_mode)) { + local_inc(&event->ctx->nr_no_switch_fast); + WARN_ON_ONCE(!atomic_long_inc_not_zero(&event->refcount)); + + event->pending_addr = 0; + if (valid_sample && (data->sample_flags & PERF_SAMPLE_ADDR)) + event->pending_addr = data->addr; + } else { + /* + * Publish the failed queueing attempt so + * a subsequent overflow can retry. + */ + smp_store_release(&event->pending_work, 0); + } } else if (event->attr.exclude_kernel && valid_sample) { /* * Should not be able to return to user space without @@ -10973,7 +10986,7 @@ static int __perf_event_overflow(struct perf_event *event, * To approximate progress (with false negatives), * check 32-bit hash of the current IP. */ - WARN_ON_ONCE(event->pending_work != pending_id); + WARN_ON_ONCE(smp_load_acquire(&event->pending_work) != pending_id); } } -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 1/2] perf/core: Prevent duplicate sigtrap task work enqueue 2026-11-17 11:28 ` [PATCH v4 1/2] perf/core: Prevent duplicate sigtrap task work enqueue Tengda Wu @ 2026-11-17 11:47 ` sashiko-bot 0 siblings, 0 replies; 6+ messages in thread From: sashiko-bot @ 2026-11-17 11:47 UTC (permalink / raw) To: Tengda Wu; +Cc: linux-perf-users > The sigtrap handling in __perf_event_overflow() checks > event->pending_work before calling task_work_add(), but only sets > pending_work after the task work has been queued. > > This leaves a window where an NMI can interrupt task_work_add() > and re-enter __perf_event_overflow() for the same event. Since > pending_work is still zero, the nested invocation can enqueue > the same pending_task again. > > The re-entrant call path looks like this: > > __perf_event_overflow() > task_work_add() > kasan_record_aux_stack() > <NMI> > [ ... ] > the exclude_kernel warning path to ensure the read is properly > ordered. > > Fixes: c5d93d23a260 ("perf: Enqueue SIGTRAP always via task_work.") > Signed-off-by: Tengda Wu <wutengda@huaweicloud.com> Sashiko has reviewed this patch and found no issues. -- Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794914794.git.wutengda@huaweicloud.com?part=1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events 2026-11-17 11:28 [PATCH v4 0/2] perf/core: Fix sigtrap task_work races Tengda Wu 2026-11-17 11:28 ` [PATCH v4 1/2] perf/core: Prevent duplicate sigtrap task work enqueue Tengda Wu @ 2026-11-17 11:28 ` Tengda Wu 2026-11-17 11:53 ` sashiko-bot 1 sibling, 1 reply; 6+ messages in thread From: Tengda Wu @ 2026-11-17 11:28 UTC (permalink / raw) To: Peter Zijlstra, Sebastian Andrzej Siewior Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark, linux-perf-users, linux-kernel, Tengda Wu perf_sigtrap() contains: WARN_ON_ONCE(event->ctx->task != current) The warning assumes that an event's ctx->task always matches the task that ends up running the pending task_work. That assumption can be broken by the context fast-swap path. The failure sequence is: 1. A -> B switch, perf_event_context_sched_out() takes the fast path and does WRITE_ONCE(ctx->task, next) / WRITE_ONCE(next_ctx->task, task). An NMI then hits while the context is swapped, and __perf_event_overflow() queues pending task_work on the *current* task (A), even though the event now belongs to B's swapped-in context view. 2. B -> A switch. Because A now has pending task_work, nr_no_switch_fast is non-zero, so the slow path is taken and ctx->task is *not* swapped back. 3. A returns to user mode, task_work runs perf_pending_task() -> perf_sigtrap(), and event->ctx->task no longer equals current, tripping the WARN_ON_ONCE(). The context fast-swap path was already excluded for events that need stable task association (inherit + sample read). sigtrap events have the same requirement: the SIGTRAP is targeted at ctx->task and must not be delivered after ctx->task has been swapped to another task. Fix this by also excluding events with attr->sigtrap from the fast-swap path, i.e. bump nr_no_switch_fast for sigtrap events in list_add_event()/list_del_event(), and update the comment describing the invariant accordingly. Fixes: c5d93d23a260 ("perf: Enqueue SIGTRAP always via task_work.") Signed-off-by: Tengda Wu <wutengda@huaweicloud.com> --- include/linux/perf_event.h | 8 +++----- kernel/events/core.c | 11 +++++++---- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index e1e11500df09..15d35b9bfd02 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -1066,11 +1066,9 @@ struct perf_event_context { * The count of events for which using the switch-out fast path * should be avoided. * - * Sum (event->pending_work + events with - * (attr->inherit && (attr->sample_type & PERF_SAMPLE_READ))) - * - * The SIGTRAP is targeted at ctx->task, as such it won't do changing - * that until the signal is delivered. + * Sum (events with + * (attr->inherit && (attr->sample_type & PERF_SAMPLE_READ)) + + * events with attr->sigtrap) */ local_t nr_no_switch_fast; }; diff --git a/kernel/events/core.c b/kernel/events/core.c index 857230b023ae..cb0ec8d51e50 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2009,7 +2009,7 @@ list_add_event(struct perf_event *event, struct perf_event_context *ctx) ctx->nr_user++; if (event->attr.inherit_stat) ctx->nr_stat++; - if (has_inherit_and_sample_read(&event->attr)) + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap) local_inc(&ctx->nr_no_switch_fast); if (event->state > PERF_EVENT_STATE_OFF) @@ -2235,7 +2235,7 @@ list_del_event(struct perf_event *event, struct perf_event_context *ctx) ctx->nr_user--; if (event->attr.inherit_stat) ctx->nr_stat--; - if (has_inherit_and_sample_read(&event->attr)) + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap) local_dec(&ctx->nr_no_switch_fast); list_del_rcu(&event->event_entry); @@ -3841,6 +3841,11 @@ perf_event_context_sched_out(struct task_struct *task, struct task_struct *next) * SAMPLE_READ events they should be switched * out using the slow path so that they are * treated as if they were distinct contexts. + * + * A context holding a sigtrap event must also + * take the slow path, even when nothing is + * pending, since the sigtrap delivery relies on + * the ctx->task relation as well. */ raw_spin_unlock(&next_ctx->lock); rcu_read_unlock(); @@ -7777,7 +7782,6 @@ static void perf_pending_task(struct callback_head *head) if (smp_load_acquire(&event->pending_work)) { perf_sigtrap(event); - local_dec(&event->ctx->nr_no_switch_fast); /* * Ensure the pending work is fully handled before allowing * another overflow to queue it. See __perf_event_overflow(). @@ -10960,7 +10964,6 @@ static int __perf_event_overflow(struct perf_event *event, */ if (cmpxchg_acquire(&event->pending_work, 0, pending_id) == 0) { if (!task_work_add(current, &event->pending_task, notify_mode)) { - local_inc(&event->ctx->nr_no_switch_fast); WARN_ON_ONCE(!atomic_long_inc_not_zero(&event->refcount)); event->pending_addr = 0; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events 2026-11-17 11:28 ` [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events Tengda Wu @ 2026-11-17 11:53 ` sashiko-bot 2026-11-18 2:52 ` Tengda Wu 0 siblings, 1 reply; 6+ messages in thread From: sashiko-bot @ 2026-11-17 11:53 UTC (permalink / raw) To: Tengda Wu; +Cc: linux-perf-users Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] perf/core: list_del_event() drops nr_no_switch_fast before perf_pending_task() -- commit a5820a5e4b514a31e08f42157caca3b1bf8abed1 Author: Tengda Wu <wutengda@huaweicloud.com> perf/core: Disable context fast-swap for sigtrap events This commit disables the context switch fast-swap path for contexts containing sigtrap events by accounting attr->sigtrap in nr_no_switch_fast during list_add_event() and list_del_event() instead of __perf_event_overflow() and perf_pending_task(). > diff --git a/kernel/events/core.c b/kernel/events/core.c > index da86bc6e8be94..9fc8db14c6b83 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -1999,7 +1999,7 @@ list_add_event(struct perf_event *event, struct perf_event_context *ctx) > ctx->nr_user++; > if (event->attr.inherit_stat) > ctx->nr_stat++; > - if (has_inherit_and_sample_read(&event->attr)) > + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap) > local_inc(&ctx->nr_no_switch_fast); > > if (event->state > PERF_EVENT_STATE_OFF) > @@ -2225,7 +2225,7 @@ list_del_event(struct perf_event *event, struct perf_event_context *ctx) > ctx->nr_user--; > if (event->attr.inherit_stat) > ctx->nr_stat--; > - if (has_inherit_and_sample_read(&event->attr)) > + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap) > local_dec(&ctx->nr_no_switch_fast); > > list_del_rcu(&event->event_entry); [ ... ] > @@ -7758,7 +7763,6 @@ static void perf_pending_task(struct callback_head *head) > > if (smp_load_acquire(&event->pending_work)) { > perf_sigtrap(event); > - local_dec(&event->ctx->nr_no_switch_fast); > /* > * Ensure the pending work is fully handled before allowing > * another overflow to queue it. See __perf_event_overflow(). > @@ -10935,7 +10939,6 @@ static int __perf_event_overflow(struct perf_event *event, > */ > if (cmpxchg_acquire(&event->pending_work, 0, pending_id) == 0) { > if (!task_work_add(current, &event->pending_task, notify_mode)) { > - local_inc(&event->ctx->nr_no_switch_fast); > WARN_ON_ONCE(!atomic_long_inc_not_zero(&event->refcount)); > > event->pending_addr = 0; [Severity: Medium] Can ctx->nr_no_switch_fast drop to zero while event->pending_task is still queued if the sigtrap event is detached before perf_pending_task() runs? Detaching an event does not cancel or flush event->pending_task; instead, pending_task holds a reference to the event until the task returns to user space. When a parent event with attr.inherit and attr.sigtrap is closed while a child event has pending_task queued, perf_event_release_kernel() detaches the child events from their cloned contexts without uncloning them: CPU0 (task A) CPU1 __perf_event_overflow(child_A) task_work_add(A, &child_A->pending_task) perf_event_release_kernel(parent) perf_remove_from_context(child_A, ...) list_del_event(child_A, ctx_A) local_dec(&ctx_A->nr_no_switch_fast) perf_remove_from_context(child_B, ...) list_del_event(child_B, ctx_B) local_dec(&ctx_B->nr_no_switch_fast) schedule() (A -> B) perf_event_context_sched_out(A, B) /* context_equiv(ctx_A, ctx_B) && nr_no_switch_fast == 0 */ WRITE_ONCE(ctx_A->task, B) ... perf_pending_task(&child_A->pending_task) perf_sigtrap(child_A) WARN_ON_ONCE(event->ctx->task != current) <-- trips WARN, drops SIGTRAP Keeping the increment in __perf_event_overflow() and decrement in perf_pending_task() alongside list_add_event() and list_del_event() would keep nr_no_switch_fast elevated until pending_task completes. Note that because list_add_event() and list_del_event() can run on a remote CPU under ctx->lock while __perf_event_overflow() or perf_pending_task() runs on ctx->task's CPU without ctx->lock, nr_no_switch_fast would also need to be atomic_t rather than CPU-local local_t. -- Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794914794.git.wutengda@huaweicloud.com?part=2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events 2026-11-17 11:53 ` sashiko-bot @ 2026-11-18 2:52 ` Tengda Wu 0 siblings, 0 replies; 6+ messages in thread From: Tengda Wu @ 2026-11-18 2:52 UTC (permalink / raw) To: sashiko-reviews, Sebastian Andrzej Siewior; +Cc: linux-perf-users On 2026/11/17 19:53, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential > issue to consider: > - [Medium] perf/core: list_del_event() drops nr_no_switch_fast before > perf_pending_task() > -- > > commit a5820a5e4b514a31e08f42157caca3b1bf8abed1 > Author: Tengda Wu <wutengda@huaweicloud.com> > > perf/core: Disable context fast-swap for sigtrap events > > This commit disables the context switch fast-swap path for contexts containing > sigtrap events by accounting attr->sigtrap in nr_no_switch_fast during > list_add_event() and list_del_event() instead of __perf_event_overflow() and > perf_pending_task(). > >> diff --git a/kernel/events/core.c b/kernel/events/core.c >> index da86bc6e8be94..9fc8db14c6b83 100644 >> --- a/kernel/events/core.c >> +++ b/kernel/events/core.c >> @@ -1999,7 +1999,7 @@ list_add_event(struct perf_event *event, struct perf_event_context *ctx) >> ctx->nr_user++; >> if (event->attr.inherit_stat) >> ctx->nr_stat++; >> - if (has_inherit_and_sample_read(&event->attr)) >> + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap) >> local_inc(&ctx->nr_no_switch_fast); >> >> if (event->state > PERF_EVENT_STATE_OFF) >> @@ -2225,7 +2225,7 @@ list_del_event(struct perf_event *event, struct perf_event_context *ctx) >> ctx->nr_user--; >> if (event->attr.inherit_stat) >> ctx->nr_stat--; >> - if (has_inherit_and_sample_read(&event->attr)) >> + if (has_inherit_and_sample_read(&event->attr) || event->attr.sigtrap) >> local_dec(&ctx->nr_no_switch_fast); >> >> list_del_rcu(&event->event_entry); > > [ ... ] > >> @@ -7758,7 +7763,6 @@ static void perf_pending_task(struct callback_head *head) >> >> if (smp_load_acquire(&event->pending_work)) { >> perf_sigtrap(event); >> - local_dec(&event->ctx->nr_no_switch_fast); >> /* >> * Ensure the pending work is fully handled before allowing >> * another overflow to queue it. See __perf_event_overflow(). >> @@ -10935,7 +10939,6 @@ static int __perf_event_overflow(struct perf_event *event, >> */ >> if (cmpxchg_acquire(&event->pending_work, 0, pending_id) == 0) { >> if (!task_work_add(current, &event->pending_task, notify_mode)) { >> - local_inc(&event->ctx->nr_no_switch_fast); >> WARN_ON_ONCE(!atomic_long_inc_not_zero(&event->refcount)); >> >> event->pending_addr = 0; > > [Severity: Medium] > Can ctx->nr_no_switch_fast drop to zero while event->pending_task is still > queued if the sigtrap event is detached before perf_pending_task() runs? > > Detaching an event does not cancel or flush event->pending_task; instead, > pending_task holds a reference to the event until the task returns to user > space. When a parent event with attr.inherit and attr.sigtrap is closed while > a child event has pending_task queued, perf_event_release_kernel() detaches the > child events from their cloned contexts without uncloning them: > > CPU0 (task A) CPU1 > __perf_event_overflow(child_A) > task_work_add(A, &child_A->pending_task) > perf_event_release_kernel(parent) > perf_remove_from_context(child_A, ...) > list_del_event(child_A, ctx_A) > local_dec(&ctx_A->nr_no_switch_fast) > perf_remove_from_context(child_B, ...) > list_del_event(child_B, ctx_B) > local_dec(&ctx_B->nr_no_switch_fast) > schedule() (A -> B) > perf_event_context_sched_out(A, B) > /* context_equiv(ctx_A, ctx_B) && nr_no_switch_fast == 0 */ > WRITE_ONCE(ctx_A->task, B) > ... > perf_pending_task(&child_A->pending_task) > perf_sigtrap(child_A) > WARN_ON_ONCE(event->ctx->task != current) <-- trips WARN, drops SIGTRAP > > Keeping the increment in __perf_event_overflow() and decrement in > perf_pending_task() alongside list_add_event() and list_del_event() would keep > nr_no_switch_fast elevated until pending_task completes. It does appear that such a scenario exists. The nr_no_switch_fast refcount distinguishes two types of states: 1. Whether the SIGTRAP event still has a pending_task that has not yet been executed. (Pre-existing) 2. Whether the SIGTRAP event is still attached to the context. (Newly added) Among them: Type 1 covers the scenario where nr_no_switch_fast goes from 1 to 0 at the end. Type 2 covers the scenario where nr_no_switch_fast goes from 0 to 1 at the beginning. Both have windows for taking the fast path, and an nr_no_switch_fast guard is needed. Deleting 1 in this patch does indeed seem incorrect. Hi Sebastian, what do you think? If there's no problem, I will roll back the deleted counter (i.e., the v3 version of this patch). Thanks, Tengda > Note that because > list_add_event() and list_del_event() can run on a remote CPU under ctx->lock > while __perf_event_overflow() or perf_pending_task() runs on ctx->task's CPU > without ctx->lock, nr_no_switch_fast would also need to be atomic_t rather than > CPU-local local_t. > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-18 2:52 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-17 11:28 [PATCH v4 0/2] perf/core: Fix sigtrap task_work races Tengda Wu 2026-11-17 11:28 ` [PATCH v4 1/2] perf/core: Prevent duplicate sigtrap task work enqueue Tengda Wu 2026-11-17 11:47 ` sashiko-bot 2026-11-17 11:28 ` [PATCH v4 2/2] perf/core: Disable context fast-swap for sigtrap events Tengda Wu 2026-11-17 11:53 ` sashiko-bot 2026-11-18 2:52 ` Tengda Wu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.