From: sashiko-bot@kernel.org
To: Roadbobek <admin@roadbobek.com>
Cc: linux-usb@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-phy@lists.infradead.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH 1/2] usb: musb: sunxi: Assert reset before deasserting on init
Date: Tue, 17 Nov 2026 13:09:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-218841@kernel.org> (raw)
In-Reply-To: <20261117-usb-sunxi-reset-fix-v1-1-c2b76e0e84e1@roadbobek.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] usb: musb: sunxi: Signed-off-by trailer uses single-word handle
Roadbobek
- [Low] usb: musb: sunxi: missing Fixes trailer for sunxi_musb_init()
reset fix
--
commit 6fb0d83bc22980ce7dcaa8d7c886a7bcf57b0905
Author: Roadbobek <admin@roadbobek.com>
> usb: musb: sunxi: Assert reset before deasserting on init
>
> When a bootloader such as U-Boot (for example with
> CONFIG_USB_MUSB_HOST=y) initializes MUSB and boots Linux
> without stopping USB first, the controller reset line is
> already deasserted at probe time.
>
> In that case reset_control_deassert() in sunxi_musb_init()
> is a no-op and stale MUSB register state persists across boot.
> On Allwinner A33, MUSB stays wedged in a_wait_bcon with
> DevCtl=0x99, Power=0xf0, and a frozen Frame counter even
> across hot-unplug and replug.
>
> Assert glue->rst briefly before deasserting it when
> SUNXI_MUSB_FL_HAS_RESET is set so MUSB starts cleanly.
> Tested on an Allwinner A33 Q8 tablet (Laser MID-786).
>
> Signed-off-by: Roadbobek <admin@roadbobek.com>
[Severity: High]
Per Documentation/process/submitting-patches.rst, the Author header and
Signed-off-by trailer must use a real full name rather than a single-word
handle or nickname.
[Severity: Low]
Since this fixes the reset initialization in sunxi_musb_init(), should it
include:
Fixes: 132e23775779 ("usb: musb: sunxi: Add support for musb controller in A31 SoC")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-usb-sunxi-reset-fix-v1-0-c2b76e0e84e1@roadbobek.com?part=1
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: Roadbobek <admin@roadbobek.com>
Cc: linux-usb@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-phy@lists.infradead.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH 1/2] usb: musb: sunxi: Assert reset before deasserting on init
Date: Tue, 17 Nov 2026 13:09:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-218841@kernel.org> (raw)
In-Reply-To: <20261117-usb-sunxi-reset-fix-v1-1-c2b76e0e84e1@roadbobek.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] usb: musb: sunxi: Signed-off-by trailer uses single-word handle
Roadbobek
- [Low] usb: musb: sunxi: missing Fixes trailer for sunxi_musb_init()
reset fix
--
commit 6fb0d83bc22980ce7dcaa8d7c886a7bcf57b0905
Author: Roadbobek <admin@roadbobek.com>
> usb: musb: sunxi: Assert reset before deasserting on init
>
> When a bootloader such as U-Boot (for example with
> CONFIG_USB_MUSB_HOST=y) initializes MUSB and boots Linux
> without stopping USB first, the controller reset line is
> already deasserted at probe time.
>
> In that case reset_control_deassert() in sunxi_musb_init()
> is a no-op and stale MUSB register state persists across boot.
> On Allwinner A33, MUSB stays wedged in a_wait_bcon with
> DevCtl=0x99, Power=0xf0, and a frozen Frame counter even
> across hot-unplug and replug.
>
> Assert glue->rst briefly before deasserting it when
> SUNXI_MUSB_FL_HAS_RESET is set so MUSB starts cleanly.
> Tested on an Allwinner A33 Q8 tablet (Laser MID-786).
>
> Signed-off-by: Roadbobek <admin@roadbobek.com>
[Severity: High]
Per Documentation/process/submitting-patches.rst, the Author header and
Signed-off-by trailer must use a real full name rather than a single-word
handle or nickname.
[Severity: Low]
Since this fixes the reset initialization in sunxi_musb_init(), should it
include:
Fixes: 132e23775779 ("usb: musb: sunxi: Add support for musb controller in A31 SoC")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-usb-sunxi-reset-fix-v1-0-c2b76e0e84e1@roadbobek.com?part=1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-11-17 13:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:00 [PATCH 0/2] usb/phy: sunxi: Assert reset before deasserting on init Roadbobek via B4 Relay
2026-11-17 13:00 ` Roadbobek via B4 Relay
2026-11-17 13:00 ` Roadbobek
2026-11-17 13:00 ` [PATCH 1/2] usb: musb: " Roadbobek via B4 Relay
2026-11-17 13:00 ` Roadbobek via B4 Relay
2026-11-17 13:00 ` Roadbobek
2026-11-17 13:05 ` Philipp Zabel
2026-11-17 13:05 ` Philipp Zabel
2026-11-17 13:09 ` sashiko-bot [this message]
2026-11-17 13:09 ` sashiko-bot
2026-11-17 13:00 ` [PATCH 2/2] phy: sun4i-usb: Assert reset before deasserting in phy init Roadbobek via B4 Relay
2026-11-17 13:00 ` Roadbobek via B4 Relay
2026-11-17 13:00 ` Roadbobek
2026-11-17 13:04 ` Philipp Zabel
2026-11-17 13:04 ` Philipp Zabel
2026-11-17 13:25 ` sashiko-bot
2026-11-17 13:25 ` sashiko-bot
2026-11-17 13:04 ` [PATCH 0/2] usb/phy: sunxi: Assert reset before deasserting on init Philipp Zabel
2026-11-17 13:04 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218841@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=admin@roadbobek.com \
--cc=linux-phy@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.