All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
	imx@lists.linux.dev, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: freescale: imx8q: Remove undocumented, unapproved aliases
Date: Tue, 17 Nov 2026 13:47:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-218903@kernel.org> (raw)
In-Reply-To: <20261117133842.245262-4-krzysztof.kozlowski@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: imx8q: removing vpu-core aliases breaks
  vpu_core_probe()
--

commit 385fa226f80390e2f0c1af946f31494af8162727
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

arm64: dts: freescale: imx8q: Remove undocumented, unapproved aliases

This commit removes the undocumented vpu-core aliases from the i.MX8QM and
i.MX8QXP devicetree files.

> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> index 9f9b34153ad54..f9d1c166bfccd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> @@ -29,9 +29,6 @@ aliases {
>  		spi1 = &lpspi1;
>  		spi2 = &lpspi2;
>  		spi3 = &lpspi3;
> -		vpu-core0 = &vpu_core0;
> -		vpu-core1 = &vpu_core1;
> -		vpu-core2 = &vpu_core2;
>  	};
>  
>  	cpus {
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 7c4a50e0ec9e9..82f640efc74e5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -50,8 +50,6 @@ aliases {
>  		spi1 = &lpspi1;
>  		spi2 = &lpspi2;
>  		spi3 = &lpspi3;
> -		vpu-core0 = &vpu_core0;
> -		vpu-core1 = &vpu_core1;
>  	};
>  
>  	cpus {

[Severity: High]
Does removing the vpu-core aliases before updating the in-tree Amphion VPU
driver break VPU probing on all i.MX8QM and i.MX8QXP boards?

drivers/media/platform/amphion/vpu_core.c:vpu_core_probe() {
	...
	core->id = of_alias_get_id(dev->of_node, "vpu-core");
	if (core->id < 0) {
		dev_err(dev, "can't get vpu core id\n");
		return core->id;
	}
	...
}

Without these aliases, of_alias_get_id() returns -ENODEV and vpu_core_probe()
fails unconditionally, whereas vpu_imx8q_set_system_cfg_common() and
vpu_imx8q_on_firmware_loaded() also rely on core->id to select the per-core
register base and populate the firmware boot header.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117133842.245262-3-krzysztof.kozlowski@oss.qualcomm.com?part=2

  reply	other threads:[~2026-11-17 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:38 [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
2026-11-17 13:47   ` sashiko-bot [this message]
2026-11-17 13:50 ` [PATCH 1/2] arm64: dts: freescale: fsl: " sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218903@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.