All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
	imx@lists.linux.dev, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases
Date: Tue, 17 Nov 2026 13:50:43 +0000	[thread overview]
Message-ID: <sashiko-outbox-218905@kernel.org> (raw)
In-Reply-To: <20261117133842.245262-3-krzysztof.kozlowski@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: freescale: incomplete alias cleanup in
  fsl-ls1046a-qds.dts
--

commit 54e57023b3aee0e459e326a808c4fb4cbc55b171
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases

This commit removes undocumented custom aliases such as dpmac, rtic-,
qsgmii-, sgmii-riser-, rgmii-, and emi1-slot* from several Freescale
Layerscape devicetree files.

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> index e850551b16acb..ea4863c9686c7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts
> @@ -24,22 +24,6 @@ aliases {
>  		serial1 = &duart1;
>  		serial2 = &duart2;
>  		serial3 = &duart3;
> -		sgmii-riser-s1-p1 = &sgmii_phy_s1_p1;
> -		sgmii-riser-s2-p1 = &sgmii_phy_s2_p1;
> -		sgmii-riser-s3-p1 = &sgmii_phy_s3_p1;
> -		sgmii-riser-s4-p1 = &sgmii_phy_s4_p1;
> -		qsgmii-s1-p1 = &qsgmii_phy_s1_p1;
> -		qsgmii-s1-p2 = &qsgmii_phy_s1_p2;
> -		qsgmii-s1-p3 = &qsgmii_phy_s1_p3;
> -		qsgmii-s1-p4 = &qsgmii_phy_s1_p4;
> -		qsgmii-s2-p1 = &qsgmii_phy_s2_p1;
> -		qsgmii-s2-p2 = &qsgmii_phy_s2_p2;
> -		qsgmii-s2-p3 = &qsgmii_phy_s2_p3;
> -		qsgmii-s2-p4 = &qsgmii_phy_s2_p4;
> -		emi1-slot1 = &ls1043mdio_s1;
> -		emi1-slot2 = &ls1043mdio_s2;
> -		emi1-slot3 = &ls1043mdio_s3;
> -		emi1-slot4 = &ls1043mdio_s4;
>  	};

[ ... ]

> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> index 48a6c08fcea82..8c095aafd5968 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts
> @@ -24,10 +24,6 @@ aliases {
>  		gpio1 = &gpio1;
>  		gpio2 = &gpio2;
>  		gpio3 = &gpio3;
> -		qsgmii-s2-p1 = &qsgmii_phy_s2_p1;
> -		qsgmii-s2-p2 = &qsgmii_phy_s2_p2;
> -		qsgmii-s2-p3 = &qsgmii_phy_s2_p3;
> -		qsgmii-s2-p4 = &qsgmii_phy_s2_p4;
>  		serial0 = &duart0;
>  		serial1 = &duart1;
>  		serial2 = &duart2;

[Severity: Low]
Should the emi1-slot* and sgmii-s* aliases in this node also be removed, as
was done for fsl-ls1043a-qds.dts above?

Because the aliases in fsl-ls1046a-qds.dts are sorted alphabetically around
gpio0..3 and serial0..3, only the middle qsgmii-s2-p* group was dropped,
leaving the other undocumented MDIO mux and PHY aliases introduced by
63c396414bfc ("arm64: dts: ls1046a-qds: add mmio based mdio-mux nodes for
FPGA"):

arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts:
	aliases {
		emi1-slot1 = &ls1046mdio_s1;
		emi1-slot2 = &ls1046mdio_s2;
		emi1-slot4 = &ls1046mdio_s4;
		...
		serial3 = &duart3;
		sgmii-s1-p1 = &sgmii_phy_s1_p1;
		sgmii-s1-p2 = &sgmii_phy_s1_p2;
		sgmii-s1-p3 = &sgmii_phy_s1_p3;
		sgmii-s1-p4 = &sgmii_phy_s1_p4;
		sgmii-s4-p1 = &sgmii_phy_s4_p1;
	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117133842.245262-3-krzysztof.kozlowski@oss.qualcomm.com?part=1

      parent reply	other threads:[~2026-11-17 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:38 [PATCH 1/2] arm64: dts: freescale: fsl: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: freescale: imx8q: " Krzysztof Kozlowski
2026-11-17 13:47   ` sashiko-bot
2026-11-17 13:50 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218905@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.