All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jun Yan" <jerrysteve1101@gmail.com>
Cc: devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: h6: taiqicat-a01: Enable Ethernet
Date: Tue, 17 Nov 2026 14:38:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-218973@kernel.org> (raw)
In-Reply-To: <20261117142122.246986-1-jerrysteve1101@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: allwinner: unresolved AC200 labels in
  sun50i-h6-taiqicat-a01.dts
--

commit e13407bcadeb9e661561721128883210b4a0461e
Author: Jun Yan <jerrysteve1101@gmail.com>

arm64: dts: allwinner: h6: taiqicat-a01: Enable Ethernet

This commit enables the EMAC, PWM, I2C3, and AC200 EPHY nodes in the
TaiqiCat A01 device tree to support the onboard 100 Mbit/s Ethernet port.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-taiqicat-a01.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-taiqicat-a01.dts
> index 225f42bd3b9e5..9b192caeecb23 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-taiqicat-a01.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-taiqicat-a01.dts

[ ... ]

> @@ -87,6 +88,10 @@ wifi_pwrseq: wifi-pwrseq {
>  	};
>  };
>  
> +&ac200_clk {
> +	status = "okay";
> +};
> +
>  &cpu0 {
>  	cpu-supply = <&reg_dcdca>;
>  };
> @@ -107,6 +112,14 @@ &ehci3 {
>  	status = "okay";
>  };
>  
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&rmii_pins>;
> +	phy-mode = "rmii";
> +	phy-handle = <&ac200_ephy>;
> +	status = "okay";
> +};
> +
>  &gpu {
>  	mali-supply = <&reg_dcdcc>;
>  	status = "okay";
> @@ -123,6 +136,29 @@ hdmi_out_con: endpoint {
>  	};
>  };
>  
> +&i2c3 {
> +	status = "okay";
> +};
> +
> +&mdio {
> +	ethernet-phy-package@1 {
> +		compatible = "x-powers,ac200-ephy-package";
> +		reg = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		vcc-supply = <&reg_aldo2>;
> +		nvmem-cells = <&ephy_calibration>;
> +		nvmem-cell-names = "configuration";
> +		x-powers,ac200 = <&ac200>;
> +		x-powers,xmii-rx-clock-inverted;
> +
> +		ac200_ephy: ethernet-phy@1 {
> +			compatible = "ethernet-phy-id0044.1400";
> +			reg = <1>;
> +		};
> +	};
> +};

[Severity: High]
Does building sun50i-h6-taiqicat-a01.dtb fail with unresolved phandle and
label references here?

arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi in this tree does not yet
define ac200_clk, rmii_pins, i2c3, ephy_calibration, or ac200, so dtbs
builds with CONFIG_ARCH_SUNXI enabled fail in dtc unless the prerequisite
sun50i-h6.dtsi changes are present.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117142122.246986-1-jerrysteve1101@gmail.com?part=1

  reply	other threads:[~2026-11-17 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:21 [PATCH] arm64: dts: allwinner: h6: taiqicat-a01: Enable Ethernet Jun Yan
2026-11-17 14:38 ` sashiko-bot [this message]
2026-11-17 16:37 ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218973@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jerrysteve1101@gmail.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.