All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org,
	vkoul@kernel.org, olteanv@gmail.com
Subject: Re: [PATCH 03/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node
Date: Tue, 17 Nov 2026 19:39:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-219508@kernel.org> (raw)
In-Reply-To: <20261117-meson-drm-create-hdmitx-phy-v1-3-9e0ac931381c@aliel.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: soc: amlogic: unwieldy conditionals in
  meson-gx-hhi-sysctrl.yaml
--

commit 2922cae8c47e87d6a0fd71e91e4a07690e4d0f66
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node

This commit adds an optional hdmi-phy child node to the Amlogic Meson
system controller binding for amlogic,meson-gx-hhi-sysctrl and forbids it
on the other system controller variants.

> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> index 285edac4c0821..97e47592aff2e 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> @@ -36,6 +36,9 @@ properties:
>    phy:
>      type: object
>  
> +  hdmi-phy:
> +    $ref: /schemas/phy/amlogic,meson-hdmi-tx-phy.yaml
> +
>  allOf:
>    - if:
>        properties:
> @@ -50,6 +53,7 @@ allOf:
>  
>          pinctrl: false
>          phy: false
> +        hdmi-phy: false
>  
>    - if:
>        properties:
> @@ -80,6 +84,7 @@ allOf:
>  
>          power-controller: false
>          phy: false
> +        hdmi-phy: false
>  
>    - if:
>        properties:
> @@ -104,6 +109,7 @@ allOf:
>            oneOf:
>              - $ref: /schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml
>              - $ref: /schemas/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> +        hdmi-phy: false

[Severity: Low]
Would it make sense to split these system controller variants into
separate schema documents instead of adding more per-compatible
exclusions here?

This schema covers five system controller compatibles across different SoC
families and register blocks (HHI and AO), where nearly every child node
property (clock-controller, power-controller, pinctrl, phy, and now
hdmi-phy) differs across variants and has to be overridden or forbidden in
overlapping allOf if-then branches.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-meson-drm-create-hdmitx-phy-v1-0-9e0ac931381c@aliel.fr?part=3

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org,
	vkoul@kernel.org, olteanv@gmail.com
Subject: Re: [PATCH 03/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node
Date: Tue, 17 Nov 2026 19:39:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-219508@kernel.org> (raw)
In-Reply-To: <20261117-meson-drm-create-hdmitx-phy-v1-3-9e0ac931381c@aliel.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: soc: amlogic: unwieldy conditionals in
  meson-gx-hhi-sysctrl.yaml
--

commit 2922cae8c47e87d6a0fd71e91e4a07690e4d0f66
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node

This commit adds an optional hdmi-phy child node to the Amlogic Meson
system controller binding for amlogic,meson-gx-hhi-sysctrl and forbids it
on the other system controller variants.

> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> index 285edac4c0821..97e47592aff2e 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> @@ -36,6 +36,9 @@ properties:
>    phy:
>      type: object
>  
> +  hdmi-phy:
> +    $ref: /schemas/phy/amlogic,meson-hdmi-tx-phy.yaml
> +
>  allOf:
>    - if:
>        properties:
> @@ -50,6 +53,7 @@ allOf:
>  
>          pinctrl: false
>          phy: false
> +        hdmi-phy: false
>  
>    - if:
>        properties:
> @@ -80,6 +84,7 @@ allOf:
>  
>          power-controller: false
>          phy: false
> +        hdmi-phy: false
>  
>    - if:
>        properties:
> @@ -104,6 +109,7 @@ allOf:
>            oneOf:
>              - $ref: /schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml
>              - $ref: /schemas/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> +        hdmi-phy: false

[Severity: Low]
Would it make sense to split these system controller variants into
separate schema documents instead of adding more per-compatible
exclusions here?

This schema covers five system controller compatibles across different SoC
families and register blocks (HHI and AO), where nearly every child node
property (clock-controller, power-controller, pinctrl, phy, and now
hdmi-phy) differs across variants and has to be overridden or forbidden in
overlapping allOf if-then branches.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-meson-drm-create-hdmitx-phy-v1-0-9e0ac931381c@aliel.fr?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org,
	vkoul@kernel.org, olteanv@gmail.com
Subject: Re: [PATCH 03/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node
Date: Tue, 17 Nov 2026 19:39:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-219508@kernel.org> (raw)
In-Reply-To: <20261117-meson-drm-create-hdmitx-phy-v1-3-9e0ac931381c@aliel.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: soc: amlogic: unwieldy conditionals in
  meson-gx-hhi-sysctrl.yaml
--

commit 2922cae8c47e87d6a0fd71e91e4a07690e4d0f66
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node

This commit adds an optional hdmi-phy child node to the Amlogic Meson
system controller binding for amlogic,meson-gx-hhi-sysctrl and forbids it
on the other system controller variants.

> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> index 285edac4c0821..97e47592aff2e 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml
> @@ -36,6 +36,9 @@ properties:
>    phy:
>      type: object
>  
> +  hdmi-phy:
> +    $ref: /schemas/phy/amlogic,meson-hdmi-tx-phy.yaml
> +
>  allOf:
>    - if:
>        properties:
> @@ -50,6 +53,7 @@ allOf:
>  
>          pinctrl: false
>          phy: false
> +        hdmi-phy: false
>  
>    - if:
>        properties:
> @@ -80,6 +84,7 @@ allOf:
>  
>          power-controller: false
>          phy: false
> +        hdmi-phy: false
>  
>    - if:
>        properties:
> @@ -104,6 +109,7 @@ allOf:
>            oneOf:
>              - $ref: /schemas/phy/amlogic,g12a-mipi-dphy-analog.yaml
>              - $ref: /schemas/phy/amlogic,meson-axg-mipi-pcie-analog.yaml
> +        hdmi-phy: false

[Severity: Low]
Would it make sense to split these system controller variants into
separate schema documents instead of adding more per-compatible
exclusions here?

This schema covers five system controller compatibles across different SoC
families and register blocks (HHI and AO), where nearly every child node
property (clock-controller, power-controller, pinctrl, phy, and now
hdmi-phy) differs across variants and has to be overridden or forbidden in
overlapping allOf if-then branches.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-meson-drm-create-hdmitx-phy-v1-0-9e0ac931381c@aliel.fr?part=3

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2026-11-17 19:39 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 19:33 [PATCH 00/10] phy/drm: amlogic: Extract Meson HDMI TX PHY into a dedicated driver Ronald Claveau
2026-11-17 19:33 ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 01/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Fix compatible matching in conditionals Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 02/10] dt-bindings: phy: amlogic: Add Meson HDMI TX PHY binding Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 03/10] dt-bindings: soc: amlogic: meson-gx-hhi-sysctrl: Add hdmi-phy child node Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:39   ` sashiko-bot [this message]
2026-11-17 19:39     ` sashiko-bot
2026-11-17 19:39     ` sashiko-bot
2026-11-17 19:33 ` [PATCH 04/10] phy: amlogic: Add Meson HDMI TX PHY driver Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:58   ` sashiko-bot
2026-11-17 19:58     ` sashiko-bot
2026-11-17 19:58     ` sashiko-bot
2026-11-17 19:33 ` [PATCH 05/10] dt-bindings: display: amlogic,meson-dw-hdmi: Add phys and phy-names Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 06/10] drm/meson: dw-hdmi: Drop manual HHI clock and memory PD setup Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 20:11   ` sashiko-bot
2026-11-17 20:11     ` sashiko-bot
2026-11-17 20:11     ` sashiko-bot
2026-11-17 19:33 ` [PATCH 07/10] drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 20:03   ` sashiko-bot
2026-11-17 20:03     ` sashiko-bot
2026-11-17 20:03     ` sashiko-bot
2026-11-17 19:33 ` [PATCH 08/10] arm64: dts: amlogic: Add HDMI TX PHY node for G12 Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 09/10] arm64: dts: amlogic: Add HDMI TX PHY node for GXBB Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33 ` [PATCH 10/10] arm64: dts: amlogic: Add HDMI TX PHY node for GXL Ronald Claveau
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay
2026-11-17 19:33   ` Ronald Claveau via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219508@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel-dev@aliel.fr \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.