All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Todd Freed" <toddfreed@meta.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v6 5/8] ipv6: icmpv6: don't quote decrypted payload in icmpv6 errors
Date: Tue, 17 Nov 2026 20:49:39 +0000	[thread overview]
Message-ID: <sashiko-outbox-219652@kernel.org> (raw)
In-Reply-To: <20261117203137.804424-6-toddfreed@meta.com>

> an icmpv6 error quotes as much of the invoking packet as fits in the
> minimum ipv6 mtu. if the device had decrypted the packet (as indicated
> by skb->decrypted) then the icmpv6 error is sending part of it back out
> onto the network in cleartext.
> 
> as in the previous patch for icmp, don't send an error about a received
> decrypted skb at all: psp also encrypts the l4 header, and telling it
> apart from ktls rx device offload would rely on SKB_EXT_PSP not being
> lost on the way. linux receivers would drop an error whose quote stops
> before the l4 header anyway (icmpv6_notify()). this covers ip6tables
> REJECT and nft reject in the ip6 and inet families; the netdev and
> bridge families are left to the nf-next patch, as for icmp.
> 
> on tx, skb->decrypted is also set. an error about a locally originated
> skb (skb_iif is 0) is sent in full as before, if its route goes to a
> local address (RTF_LOCAL), like RTCF_LOCAL in the previous patch.
> 
> an error about a received decrypted skb is dropped before the rate
> limit, so that it doesn't use up the peer's and the global icmpv6
> credit. the check of a locally originated skb needs the route of the
> error, which is looked up after the rate limit.
> 
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261023234640.1459291-1-toddfreed%40meta.com
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Suggested-by: Björn Töpel <bjorn@kernel.org>
> Fixes: 784abe24c903 ("net: Add decrypted field to skb")
> Cc: stable@vger.kernel.org
> Signed-off-by: Todd Freed <toddfreed@meta.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117203137.804424-1-toddfreed@meta.com?part=5


  reply	other threads:[~2026-11-17 20:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:31 [PATCH net v6 0/8] psp, tls: don't send offloaded contents in cleartext Todd Freed
2026-11-17 20:31 ` [PATCH net v6 1/8] net/mlx5e: ring the tx doorbell when an accel offload drops a packet Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 2/8] psp: don't encapsulate ipv6 packets with extension headers Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 3/8] net: don't fragment decrypted skbs Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 4/8] ipv4: icmp: don't quote decrypted payload in icmp errors Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 5/8] ipv6: icmpv6: don't quote decrypted payload in icmpv6 errors Todd Freed
2026-11-17 20:49   ` sashiko-bot [this message]
2026-11-17 20:31 ` [PATCH net v6 6/8] selftests: drv-net: psp: test ipv6 tcp socket with extension headers Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 7/8] selftests: drv-net: psp: test that ipv4 psp packets aren't fragmented Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 8/8] net/mlx5e: psp: tso: replace only the length in checksum seed Todd Freed
2026-11-17 20:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219652@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=toddfreed@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.