All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Todd Freed" <toddfreed@meta.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v6 7/8] selftests: drv-net: psp: test that ipv4 psp packets aren't fragmented
Date: Tue, 17 Nov 2026 20:49:41 +0000	[thread overview]
Message-ID: <sashiko-outbox-219654@kernel.org> (raw)
In-Reply-To: <20261117203137.804424-8-toddfreed@meta.com>

> make the ipv4 packets of a psp tcp socket need fragmenting, and check
> that they're dropped (IpFragFails) and not transmitted unencrypted.
> 
> tcp sizes its segments from the route mtu. with IP_PMTUDISC_OMIT, ip
> fragments them to the device mtu, and doesn't set df. so the test sets a
> route mtu of twice the larger of the two device mtus (at most 65535) on
> both ends (the peer's mss limits ours too), keeping the device and
> source address of the current route, and IP_PMTUDISC_OMIT on the socket.
> tcp mtu probing (tcp_mtu_probing 2, or 1 once a black hole is detected)
> can cap the mss at the probing base, so the test turns it off. if the
> peer isn't on-link, or the socket's mss doesn't need fragmenting, the
> test is skipped.
> 
> a software filter on the peer counts, and drops, the ipv4 fragments
> which reach it from the socket's address, and the test asserts there are
> [ ... ]
> without the fix in "net: don't fragment decrypted skbs", the packets are
> fragmented, and the fragments go out unencrypted. they reach the peer,
> IpFragFails doesn't move, and the test fails.
> 
> Signed-off-by: Todd Freed <toddfreed@meta.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117203137.804424-1-toddfreed@meta.com?part=7


  reply	other threads:[~2026-11-17 20:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:31 [PATCH net v6 0/8] psp, tls: don't send offloaded contents in cleartext Todd Freed
2026-11-17 20:31 ` [PATCH net v6 1/8] net/mlx5e: ring the tx doorbell when an accel offload drops a packet Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 2/8] psp: don't encapsulate ipv6 packets with extension headers Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 3/8] net: don't fragment decrypted skbs Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 4/8] ipv4: icmp: don't quote decrypted payload in icmp errors Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 5/8] ipv6: icmpv6: don't quote decrypted payload in icmpv6 errors Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 6/8] selftests: drv-net: psp: test ipv6 tcp socket with extension headers Todd Freed
2026-11-17 20:49   ` sashiko-bot
2026-11-17 20:31 ` [PATCH net v6 7/8] selftests: drv-net: psp: test that ipv4 psp packets aren't fragmented Todd Freed
2026-11-17 20:49   ` sashiko-bot [this message]
2026-11-17 20:31 ` [PATCH net v6 8/8] net/mlx5e: psp: tso: replace only the length in checksum seed Todd Freed
2026-11-17 20:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219654@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=toddfreed@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.