All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hwmon: (ads7871) Add error handle from spi_setup()
@ 2026-11-17 20:51 Vítor Hugo Silva
  2026-11-17 20:54 ` sashiko-bot
  2026-11-17 23:15 ` Guenter Roeck
  0 siblings, 2 replies; 3+ messages in thread
From: Vítor Hugo Silva @ 2026-11-17 20:51 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Vítor Hugo Silva

The ads7871 probe() ignores the spi_setup() error return value
and it attempts to write on registers even if spi_setup() fails or not

This patch returns the setup error before accessing any registers.

AI was used for peer-review the patch.

Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")

Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
---
 drivers/hwmon/ads7871.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index 36297bc6d047..a1ffc35d9272 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
 	/* Configure the SPI bus */
 	spi->mode = (SPI_MODE_0);
 	spi->bits_per_word = 8;
-	spi_setup(spi);
+	ret = spi_setup(spi);
+	if (ret)
+		return ret;
 
 	pdata = devm_kzalloc_obj(dev, *pdata);
 	if (!pdata)
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hwmon: (ads7871) Add error handle from spi_setup()
  2026-11-17 20:51 [PATCH] hwmon: (ads7871) Add error handle from spi_setup() Vítor Hugo Silva
@ 2026-11-17 20:54 ` sashiko-bot
  2026-11-17 23:15 ` Guenter Roeck
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-17 20:54 UTC (permalink / raw)
  To: Vítor Hugo Silva; +Cc: linux-hwmon

> The ads7871 probe() ignores the spi_setup() error return value
> and it attempts to write on registers even if spi_setup() fails or not
> 
> This patch returns the setup error before accessing any registers.
> 
> AI was used for peer-review the patch.
> 
> Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
> 
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117205132.141964-1-vitorhg20080@gmail.com?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hwmon: (ads7871) Add error handle from spi_setup()
  2026-11-17 20:51 [PATCH] hwmon: (ads7871) Add error handle from spi_setup() Vítor Hugo Silva
  2026-11-17 20:54 ` sashiko-bot
@ 2026-11-17 23:15 ` Guenter Roeck
  1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2026-11-17 23:15 UTC (permalink / raw)
  To: Vítor Hugo Silva; +Cc: linux-hwmon, linux-kernel

On 11/17/26 12:51, Vítor Hugo Silva wrote:
> The ads7871 probe() ignores the spi_setup() error return value
> and it attempts to write on registers even if spi_setup() fails or not
> 
or not what ?

> This patch returns the setup error before accessing any registers.
> 
s/This patch returns/Return/

(imperative mood, see Documentation/process/submitting-patches.rst)

Thanks,
Guenter

> AI was used for peer-review the patch.
> 
> Fixes: e0c70b8078629 ("hwmon: add TI ads7871 a/d converter driver")
> 
> Signed-off-by: Vítor Hugo Silva <vitorhg20080@gmail.com>
> ---
>   drivers/hwmon/ads7871.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> index 36297bc6d047..a1ffc35d9272 100644
> --- a/drivers/hwmon/ads7871.c
> +++ b/drivers/hwmon/ads7871.c
> @@ -187,7 +187,9 @@ static int ads7871_probe(struct spi_device *spi)
>   	/* Configure the SPI bus */
>   	spi->mode = (SPI_MODE_0);
>   	spi->bits_per_word = 8;
> -	spi_setup(spi);
> +	ret = spi_setup(spi);
> +	if (ret)
> +		return ret;
>   
>   	pdata = devm_kzalloc_obj(dev, *pdata);
>   	if (!pdata)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17 23:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 20:51 [PATCH] hwmon: (ads7871) Add error handle from spi_setup() Vítor Hugo Silva
2026-11-17 20:54 ` sashiko-bot
2026-11-17 23:15 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.