All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Diogo Ivo" <diogo.ivo.sx@renesas.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 3/7] serial: rsci: Enable transmit end interrupt in rsci_stop_tx()
Date: Tue, 17 Nov 2026 23:47:45 +0000	[thread overview]
Message-ID: <sashiko-outbox-219806@kernel.org> (raw)
In-Reply-To: <20261117-g2ul_sci-v5-3-30b58ea18923@renesas.com>

> Currently, rsci_stop_tx() clears CCR0.TIE without enabling CCR0.TEIE.
> If transmission is stopped while CCR0.TE is set (for example, via
> TCOOFF), the hardware FIFO drains and sets CSR.TDRE while CCR0.TIE is 0,
> and no TEI (Transmit End) interrupt is generated to clear CCR0.TE.
> 
> However, on RSCI setting TIE while TE is already set does not generate a
> TXI interrupt. Thus, if transmission is later resumed via rsci_start_tx(),
> setting CCR0.TIE while CCR0.TE and CSR.TDRE are already 1 fails to call
> into rsci_transmit_chars(), permanently stalling subsequent transmissions.
> 
> Fix this by setting CCR0.TEIE in rsci_stop_tx() whenever CCR0.TE is
> set, ensuring sci_tx_end_interrupt() fires once the hardware finishes
> shifting out in-flight data and clears CCR0.TE.
> 
> Fixes: 0666e3fe95ab ("serial: sh-sci: Add support for RZ/T2H SCI")
> Cc: stable@vger.kernel.org
> Signed-off-by: Diogo Ivo <diogo.ivo.sx@renesas.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-g2ul_sci-v5-0-30b58ea18923@renesas.com?part=3


  reply	other threads:[~2026-11-17 23:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 23:40 [PATCH v5 0/7] Fix transmit handling on SCI/RSCI ports Diogo Ivo
2026-11-17 23:40 ` [PATCH v5 1/7] serial: sh-sci: Drop TE disable at end of transmission on SCI Diogo Ivo
2026-11-17 23:46   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 2/7] serial: sh-sci: Keep TX enabled on TEI while data is pending Diogo Ivo
2026-11-18  0:04   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 3/7] serial: rsci: Enable transmit end interrupt in rsci_stop_tx() Diogo Ivo
2026-11-17 23:47   ` sashiko-bot [this message]
2026-11-17 23:40 ` [PATCH v5 4/7] serial: sh-sci: Do not kick TX from sci_er_interrupt() on RSCI Diogo Ivo
2026-11-17 23:48   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 5/7] serial: sh-sci: Skip TDxE clear when hardware clears it automatically Diogo Ivo
2026-11-17 23:48   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 6/7] serial: sh-sci: Toggle TE when restoring SCSCR in console write on SCI Diogo Ivo
2026-11-17 23:48   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 7/7] serial: rsci: Simplify rsci_transmit_chars() Diogo Ivo
2026-11-17 23:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219806@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=diogo.ivo.sx@renesas.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.