All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Diogo Ivo" <diogo.ivo.sx@renesas.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 2/7] serial: sh-sci: Keep TX enabled on TEI while data is pending
Date: Wed, 18 Nov 2026 00:04:28 +0000	[thread overview]
Message-ID: <sashiko-outbox-219827@kernel.org> (raw)
In-Reply-To: <20261117-g2ul_sci-v5-2-30b58ea18923@renesas.com>

> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> sci_tx_end_interrupt() clears TE and TEIE unconditionally on SCI and
> RSCI ports. If new data was queued or transmission restarted before the
> TEI handler runs, disabling the transmitter stalls or truncates output.
> 
> To fix truncations, verify that poll_sent_bits are set, and address
> stalls by checking for pending data (while the port is not suspended)
> before clearing TE and TEIE. The existing TE/TEIE teardown path only
> runs once nothing is left to send and we are sure that we are not still
> sending data.
> 
> While at it, make sure to also stop TX when the port is stopped with data
> queued.
> 
> Fixes: d61ae331d6f3 ("tty: serial: sh-sci: Add support for tx end interrupt handling")
> Cc: stable@vger.kernel.org
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Co-developed-by: Diogo Ivo <diogo.ivo.sx@renesas.com>
> Signed-off-by: Diogo Ivo <diogo.ivo.sx@renesas.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-g2ul_sci-v5-0-30b58ea18923@renesas.com?part=2


  reply	other threads:[~2026-11-18  0:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 23:40 [PATCH v5 0/7] Fix transmit handling on SCI/RSCI ports Diogo Ivo
2026-11-17 23:40 ` [PATCH v5 1/7] serial: sh-sci: Drop TE disable at end of transmission on SCI Diogo Ivo
2026-11-17 23:46   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 2/7] serial: sh-sci: Keep TX enabled on TEI while data is pending Diogo Ivo
2026-11-18  0:04   ` sashiko-bot [this message]
2026-11-17 23:40 ` [PATCH v5 3/7] serial: rsci: Enable transmit end interrupt in rsci_stop_tx() Diogo Ivo
2026-11-17 23:47   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 4/7] serial: sh-sci: Do not kick TX from sci_er_interrupt() on RSCI Diogo Ivo
2026-11-17 23:48   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 5/7] serial: sh-sci: Skip TDxE clear when hardware clears it automatically Diogo Ivo
2026-11-17 23:48   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 6/7] serial: sh-sci: Toggle TE when restoring SCSCR in console write on SCI Diogo Ivo
2026-11-17 23:48   ` sashiko-bot
2026-11-17 23:40 ` [PATCH v5 7/7] serial: rsci: Simplify rsci_transmit_chars() Diogo Ivo
2026-11-17 23:49   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219827@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=diogo.ivo.sx@renesas.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.