All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator
@ 2026-11-18  7:19 Lijo Lazar
  2026-11-18  7:28 ` sashiko-bot
  2026-11-18  7:52 ` Kamal, Asad
  0 siblings, 2 replies; 3+ messages in thread
From: Lijo Lazar @ 2026-11-18  7:19 UTC (permalink / raw)
  To: amd-gfx; +Cc: Hawking.Zhang, Alexander.Deucher, Asad.Kamal

The energy accumulator is a raw counter in 2^-16 units, not a Q10
fixed-point value. Report the counter as is.

Fixes: d1168b8cfbe6 ("drm/amd/pm: Fix metrics formatting in SMUv15.0.8")
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
index a9cd1837239f..051aaa203fe1 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
@@ -1966,8 +1966,7 @@ static ssize_t smu_v15_0_8_get_gpu_metrics(struct smu_context *smu, void **table
 	gpu_metrics->mem_max_bandwidth = SMUQ10_ROUND(metrics->MaxDramBandwidth);
 
 	/* Energy counter reported in 15.259uJ (2^-16) units */
-	gpu_metrics->energy_accumulator =
-		SMUQ10_ROUND(metrics->SocketEnergyAcc);
+	gpu_metrics->energy_accumulator = metrics->SocketEnergyAcc;
 
 	for (i = 0; i < NUM_XCC(adev->gfx.xcc_mask); ++i) {
 		xcc_id = GET_INST(GC, i);
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator
  2026-11-18  7:19 [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator Lijo Lazar
@ 2026-11-18  7:28 ` sashiko-bot
  2026-11-18  7:52 ` Kamal, Asad
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-18  7:28 UTC (permalink / raw)
  To: Lijo Lazar, amd-gfx

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amd/pm: unresolvable SHA d1168b8cfbe6 in Fixes trailer
--

commit 7bfc1b1729a32aa01f3585d9c539d253e7c105fe
Author: Lijo Lazar <lijo.lazar@amd.com>

> drm/amd/pm: Fix SMU v15.0.8 energy accumulator
>
> The energy accumulator is a raw counter in 2^-16 units, not a Q10
> fixed-point value. Report the counter as is.
>
> Fixes: d1168b8cfbe6 ("drm/amd/pm: Fix metrics formatting in SMUv15.0.8")
> Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>

[Severity: Low]
Commit d1168b8cfbe6 in the Fixes: tag does not exist in the repository.
Should this reference b7d7649f7d99 ("drm/amd/pm: Fix metrics formatting in
SMUv15.0.8") instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118071927.2149652-1-lijo.lazar@amd.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator
  2026-11-18  7:19 [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator Lijo Lazar
  2026-11-18  7:28 ` sashiko-bot
@ 2026-11-18  7:52 ` Kamal, Asad
  1 sibling, 0 replies; 3+ messages in thread
From: Kamal, Asad @ 2026-11-18  7:52 UTC (permalink / raw)
  To: Lazar, Lijo, amd-gfx@lists.freedesktop.org
  Cc: Zhang, Hawking, Deucher, Alexander

AMD General

Reviewed-by: Asad Kamal <asad.kamal@amd.com>

Thanks & Regards
Asad

-----Original Message-----
From: Lazar, Lijo <Lijo.Lazar@amd.com>
Sent: Wednesday, November 18, 2026 12:49 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Kamal, Asad <Asad.Kamal@amd.com>
Subject: [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator

The energy accumulator is a raw counter in 2^-16 units, not a Q10 fixed-point value. Report the counter as is.

Fixes: d1168b8cfbe6 ("drm/amd/pm: Fix metrics formatting in SMUv15.0.8")
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
index a9cd1837239f..051aaa203fe1 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
@@ -1966,8 +1966,7 @@ static ssize_t smu_v15_0_8_get_gpu_metrics(struct smu_context *smu, void **table
        gpu_metrics->mem_max_bandwidth = SMUQ10_ROUND(metrics->MaxDramBandwidth);

        /* Energy counter reported in 15.259uJ (2^-16) units */
-       gpu_metrics->energy_accumulator =
-               SMUQ10_ROUND(metrics->SocketEnergyAcc);
+       gpu_metrics->energy_accumulator = metrics->SocketEnergyAcc;

        for (i = 0; i < NUM_XCC(adev->gfx.xcc_mask); ++i) {
                xcc_id = GET_INST(GC, i);
--
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-18  7:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  7:19 [PATCH] drm/amd/pm: Fix SMU v15.0.8 energy accumulator Lijo Lazar
2026-11-18  7:28 ` sashiko-bot
2026-11-18  7:52 ` Kamal, Asad

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.