* [PATCH v2] mm/damon/paddr: skip non-LRU folios as a whole in pageout
@ 2026-11-17 16:24 Aveline Noir
2026-11-18 7:47 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Aveline Noir @ 2026-11-17 16:24 UTC (permalink / raw)
To: SJ Park
Cc: Andrew Morton, damon, linux-mm, linux-kernel, sashiko-bot,
sashiko-reviews
damon_pa_pageout() uses damon_get_folio(), which rejects folios that are
not on the LRU. For a large non-LRU folio such as a hugetlb folio, the
loop then looks up the same folio once per base page even though
pageout cannot reclaim it.
Use damon_get_monitor_folio() and skip any returned non-LRU folio as a
whole by advancing to its end. Do this before the filters, the
accounting and the last_applied check, so that adjacent regions within
the same non-LRU folio are not walked by base page either.
In an x86-64 KVM pageout microbenchmark, traversal time dropped by
about 99.7% for regions covering whole 2 MiB hugetlb folios. For
4 KiB regions within hugetlb folios, traversal took about 1 ns more
per region.
Signed-off-by: Aveline Noir <jm5905938@gmail.com>
---
Tested in x86-64 KVM guests. DAMON KUnit tests all passed. Ordinary-page
and THP controls passed the 3% non-inferiority bound in the microbenchmark.
Changes in v2:
- Drop the redundant hugetlb check and update the subject and description
as suggested by SJ.
---
mm/damon/paddr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
index 5b773012a876..0a205fa8d468 100644
--- a/mm/damon/paddr.c
+++ b/mm/damon/paddr.c
@@ -268,7 +268,9 @@ static unsigned long damon_pa_pageout(struct damon_region *r,
addr = damon_pa_phys_addr(r->ar.start, addr_unit);
while (addr < damon_pa_phys_addr(r->ar.end, addr_unit)) {
- folio = damon_get_folio(PHYS_PFN(addr));
+ folio = damon_get_monitor_folio(PHYS_PFN(addr));
+ if (folio && !folio_test_lru(folio))
+ goto put_folio;
if (damon_pa_invalid_damos_folio(folio, s)) {
addr += PAGE_SIZE;
continue;
---
base-commit: 67f3b04b277373438f17300e056306adbd9edf7b
change-id: 20261117-fix-damon-hugetlb-pageout-20261117-a4e03d9d5a5b
Best regards,
--
Aveline Noir <jm5905938@gmail.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-18 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 16:24 [PATCH v2] mm/damon/paddr: skip non-LRU folios as a whole in pageout Aveline Noir
2026-11-18 7:47 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.