From: sashiko-bot@kernel.org
To: pjh456 <147148383@qq.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: add Industio Purple Pi OH panel
Date: Wed, 18 Nov 2026 08:44:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-220483@kernel.org> (raw)
In-Reply-To: <tencent_4499382AA896319EAA2244D239B92371C207@qq.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/panel: ilitek-ili9881c: undocumented vendor prefix industio
in of_match
--
commit 84f034765df38c524342d56e58717a5a36f868df
Author: pjh456 <147148383@qq.com>
drm/panel: ilitek-ili9881c: add Industio Purple Pi OH panel
This commit adds an initialization sequence, display mode, and compatible
string for the 7-inch 800x1280 MIPI-DSI panel used on the Industio Purple
Pi OH board.
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 7bf38e96678ac..5f1270d780827 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
[ ... ]
> @@ -2708,6 +2929,7 @@ static const struct of_device_id ili9881c_of_match[] = {
> { .compatible = "wanchanglong,w552946aba", .data = &w552946aba_desc },
> { .compatible = "waveshare,7.0-dsi-touch-a", .data = &waveshare_7inch_a_desc },
> { .compatible = "ampire,am8001280g", .data = &am8001280g_desc },
> + { .compatible = "industio,purple-pi-oh-panel", .data = &ppoh_desc },
[Severity: Low]
Should the "industio" vendor prefix be documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml? Neither this
patch nor commit "dt-bindings: display: panel: ilitek, ili9881c: add
Industio Purple Pi OH panel" adds an entry for it, which triggers a
checkpatch UNDOCUMENTED_DT_STRING warning and a dt_binding_check failure.
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_74E280A130C68EAB42115FE6AE8E6809D109@qq.com?part=2
prev parent reply other threads:[~2026-11-18 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261118080338.523572-1-147148383@qq.com>
2026-11-18 8:03 ` [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel pjh456
2026-11-18 8:36 ` sashiko-bot
2026-11-18 8:52 ` [PATCH 1/2] dt-bindings: display: panel: ilitek,ili9881c: " Krzysztof Kozlowski
2026-11-18 8:03 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: " pjh456
2026-11-18 8:44 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220483@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=147148383@qq.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.