From: sashiko-bot@kernel.org
To: pjh456 <147148383@qq.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel
Date: Wed, 18 Nov 2026 08:36:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-220461@kernel.org> (raw)
In-Reply-To: <tencent_74E280A130C68EAB42115FE6AE8E6809D109@qq.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: display: panel: undocumented vendor prefix industio
- [Low] dt-bindings: display: panel: redundant width-mm and height-mm
properties
--
commit 7361c405de28bc487b0531418138b8282051250c
Author: pjh456 <147148383@qq.com>
dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel
This commit adds the industio,purple-pi-oh-panel compatible string and
the width-mm and height-mm properties to the Ilitek ILI9881C panel
binding.
> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
> index 42e35986fbf60..72d052ef2ccbc 100644
> --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
> @@ -20,6 +20,7 @@ properties:
> - bananapi,lhr050h41
> - bestar,bsd1218-a101kl68
> - feixin,k101-im2byl02
> + - industio,purple-pi-oh-panel
> - raspberrypi,dsi-5inch
> - raspberrypi,dsi-7inch
> - startek,kd050hdfia020
[Severity: Low]
Is the "industio" vendor prefix documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml? Adding
industio,purple-pi-oh-panel without registering the prefix triggers
checkpatch.pl and dtbs_check warnings for an undocumented vendor prefix.
> @@ -33,11 +34,13 @@ properties:
> maxItems: 1
>
> backlight: true
> + height-mm: true
> port: true
> power-supply: true
> iovcc-supply: true
> reset-gpios: true
> rotation: true
> + width-mm: true
>
> required:
> - compatible
[Severity: Low]
Are height-mm and width-mm needed in this binding? Each panel-specific
compatible already implies fixed physical dimensions, and
ili9881c_get_modes() in drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
populates connector->display_info.width_mm and height_mm from the static
mode descriptor rather than reading these properties from Devicetree.
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_74E280A130C68EAB42115FE6AE8E6809D109@qq.com?part=1
next prev parent reply other threads:[~2026-11-18 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261118080338.523572-1-147148383@qq.com>
2026-11-18 8:03 ` [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel pjh456
2026-11-18 8:36 ` sashiko-bot [this message]
2026-11-18 8:52 ` [PATCH 1/2] dt-bindings: display: panel: ilitek,ili9881c: " Krzysztof Kozlowski
2026-11-18 8:03 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: " pjh456
2026-11-18 8:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220461@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=147148383@qq.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.