All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel
       [not found] <20261118080338.523572-1-147148383@qq.com>
@ 2026-11-18  8:03 ` pjh456
  2026-11-18  8:36   ` sashiko-bot
  2026-11-18  8:52   ` [PATCH 1/2] dt-bindings: display: panel: ilitek,ili9881c: " Krzysztof Kozlowski
  2026-11-18  8:03 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: " pjh456
  1 sibling, 2 replies; 5+ messages in thread
From: pjh456 @ 2026-11-18  8:03 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: dri-devel, Jessica Zhang, Maxime Ripard, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley

The Purple Pi OH is shipped with an ILI9881C based 800x1280 MIPI-DSI
panel.  The module is marked ZC-700010BH and has a 94x151 mm active
area; the vendor device tree only describes it as a generic
"simple-panel-dsi", so no panel-vendor compatible is known.  Add a
board-specific compatible with ilitek,ili9881c as the fallback, and
allow the standard width-mm/height-mm properties.

Assisted-by: DeepSeek:deepseek-v4.1-flash
Assisted-by: Qwen:Qwen3.8-Flash-Next
Signed-off-by: pjh456 <147148383@qq.com>
---
 .../devicetree/bindings/display/panel/ilitek,ili9881c.yaml     | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
index 42e35986fbf6..72d052ef2ccb 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
@@ -20,6 +20,7 @@ properties:
           - bananapi,lhr050h41
           - bestar,bsd1218-a101kl68
           - feixin,k101-im2byl02
+          - industio,purple-pi-oh-panel
           - raspberrypi,dsi-5inch
           - raspberrypi,dsi-7inch
           - startek,kd050hdfia020
@@ -33,11 +34,13 @@ properties:
     maxItems: 1
 
   backlight: true
+  height-mm: true
   port: true
   power-supply: true
   iovcc-supply: true
   reset-gpios: true
   rotation: true
+  width-mm: true
 
 required:
   - compatible
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] drm/panel: ilitek-ili9881c: add Industio Purple Pi OH panel
       [not found] <20261118080338.523572-1-147148383@qq.com>
  2026-11-18  8:03 ` [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel pjh456
@ 2026-11-18  8:03 ` pjh456
  2026-11-18  8:44   ` sashiko-bot
  1 sibling, 1 reply; 5+ messages in thread
From: pjh456 @ 2026-11-18  8:03 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: dri-devel, Jessica Zhang, Maxime Ripard, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley

Add support for the 7-inch 800x1280 MIPI-DSI panel found on the Industio
Purple Pi OH (RK3566).  It is a 4-lane ILI9881C panel whose
initialisation sequence was taken from the vendor device tree.  The
module is marked ZC-700010BH and the vendor DTB only describes it as a
generic "simple-panel-dsi", so the init sequence is its only
provenance.

The existing am8001280g entry (another 7-inch 800x1280 ILI9881C panel)
was tested on this hardware and only lights the backlight without a
picture, so a dedicated entry with the vendor sequence is required.

The panel is reset through GPIO0_D6 and its backlight is driven by
PWM4.

The init sequence was mechanically converted from the vendor device
tree's panel-init-sequence property with the help of an AI coding
assistant; the resulting driver was reviewed and tested on hardware by
the submitter.

Assisted-by: DeepSeek:deepseek-v4.1-flash
Assisted-by: Qwen:Qwen3.8-Flash-Next
Signed-off-by: pjh456 <147148383@qq.com>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 222 ++++++++++++++++++
 1 file changed, 222 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 7bf38e96678a..5f1270d78082 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -1424,6 +1424,201 @@ static const struct ili9881c_instr am8001280g_init[] = {
 	ILI9881C_COMMAND_INSTR(MIPI_DCS_WRITE_POWER_SAVE, 0x00),
 };
 
+static const struct ili9881c_instr ppoh_init[] = {
+	ILI9881C_SWITCH_PAGE_INSTR(0x03),
+	ILI9881C_COMMAND_INSTR(0x01, 0x00),
+	ILI9881C_COMMAND_INSTR(0x02, 0x00),
+	ILI9881C_COMMAND_INSTR(0x03, 0x73),
+	ILI9881C_COMMAND_INSTR(0x04, 0x13),
+	ILI9881C_COMMAND_INSTR(0x05, 0x00),
+	ILI9881C_COMMAND_INSTR(0x06, 0x0a),
+	ILI9881C_COMMAND_INSTR(0x07, 0x05),
+	ILI9881C_COMMAND_INSTR(0x08, 0x00),
+	ILI9881C_COMMAND_INSTR(0x09, 0x28),
+	ILI9881C_COMMAND_INSTR(0x0a, 0x00),
+	ILI9881C_COMMAND_INSTR(0x0b, 0x00),
+	ILI9881C_COMMAND_INSTR(0x0c, 0x00),
+	ILI9881C_COMMAND_INSTR(0x0d, 0x28),
+	ILI9881C_COMMAND_INSTR(0x0e, 0x00),
+	ILI9881C_COMMAND_INSTR(0x0f, 0x28),
+	ILI9881C_COMMAND_INSTR(0x10, 0x28),
+	ILI9881C_COMMAND_INSTR(0x11, 0x00),
+	ILI9881C_COMMAND_INSTR(0x12, 0x00),
+	ILI9881C_COMMAND_INSTR(0x13, 0x00),
+	ILI9881C_COMMAND_INSTR(0x14, 0x00),
+	ILI9881C_COMMAND_INSTR(0x15, 0x00),
+	ILI9881C_COMMAND_INSTR(0x16, 0x00),
+	ILI9881C_COMMAND_INSTR(0x17, 0x00),
+	ILI9881C_COMMAND_INSTR(0x18, 0x00),
+	ILI9881C_COMMAND_INSTR(0x19, 0x00),
+	ILI9881C_COMMAND_INSTR(0x1a, 0x00),
+	ILI9881C_COMMAND_INSTR(0x1b, 0x00),
+	ILI9881C_COMMAND_INSTR(0x1c, 0x00),
+	ILI9881C_COMMAND_INSTR(0x1d, 0x00),
+	ILI9881C_COMMAND_INSTR(0x1e, 0x40),
+	ILI9881C_COMMAND_INSTR(0x1f, 0x80),
+	ILI9881C_COMMAND_INSTR(0x20, 0x06),
+	ILI9881C_COMMAND_INSTR(0x21, 0x01),
+	ILI9881C_COMMAND_INSTR(0x22, 0x00),
+	ILI9881C_COMMAND_INSTR(0x23, 0x00),
+	ILI9881C_COMMAND_INSTR(0x24, 0x00),
+	ILI9881C_COMMAND_INSTR(0x25, 0x00),
+	ILI9881C_COMMAND_INSTR(0x26, 0x00),
+	ILI9881C_COMMAND_INSTR(0x27, 0x00),
+	ILI9881C_COMMAND_INSTR(0x28, 0x33),
+	ILI9881C_COMMAND_INSTR(0x29, 0x33),
+	ILI9881C_COMMAND_INSTR(0x2a, 0x00),
+	ILI9881C_COMMAND_INSTR(0x2b, 0x00),
+	ILI9881C_COMMAND_INSTR(0x2c, 0x04),
+	ILI9881C_COMMAND_INSTR(0x2d, 0x04),
+	ILI9881C_COMMAND_INSTR(0x2e, 0x05),
+	ILI9881C_COMMAND_INSTR(0x2f, 0x05),
+	ILI9881C_COMMAND_INSTR(0x30, 0x00),
+	ILI9881C_COMMAND_INSTR(0x31, 0x00),
+	ILI9881C_COMMAND_INSTR(0x32, 0x31),
+	ILI9881C_COMMAND_INSTR(0x33, 0x00),
+	ILI9881C_COMMAND_INSTR(0x34, 0x00),
+	ILI9881C_COMMAND_INSTR(0x35, 0x0a),
+	ILI9881C_COMMAND_INSTR(0x36, 0x00),
+	ILI9881C_COMMAND_INSTR(0x37, 0x08),
+	ILI9881C_COMMAND_INSTR(0x38, 0x00),
+	ILI9881C_COMMAND_INSTR(0x39, 0x00),
+	ILI9881C_COMMAND_INSTR(0x3a, 0x00),
+	ILI9881C_COMMAND_INSTR(0x3b, 0x00),
+	ILI9881C_COMMAND_INSTR(0x3c, 0x00),
+	ILI9881C_COMMAND_INSTR(0x3d, 0x00),
+	ILI9881C_COMMAND_INSTR(0x3e, 0x00),
+	ILI9881C_COMMAND_INSTR(0x3f, 0x00),
+	ILI9881C_COMMAND_INSTR(0x40, 0x00),
+	ILI9881C_COMMAND_INSTR(0x41, 0x00),
+	ILI9881C_COMMAND_INSTR(0x42, 0x00),
+	ILI9881C_COMMAND_INSTR(0x43, 0x08),
+	ILI9881C_COMMAND_INSTR(0x44, 0x00),
+	ILI9881C_COMMAND_INSTR(0x50, 0x01),
+	ILI9881C_COMMAND_INSTR(0x51, 0x23),
+	ILI9881C_COMMAND_INSTR(0x52, 0x44),
+	ILI9881C_COMMAND_INSTR(0x53, 0x67),
+	ILI9881C_COMMAND_INSTR(0x54, 0x89),
+	ILI9881C_COMMAND_INSTR(0x55, 0xab),
+	ILI9881C_COMMAND_INSTR(0x56, 0x01),
+	ILI9881C_COMMAND_INSTR(0x57, 0x23),
+	ILI9881C_COMMAND_INSTR(0x58, 0x45),
+	ILI9881C_COMMAND_INSTR(0x59, 0x67),
+	ILI9881C_COMMAND_INSTR(0x5a, 0x89),
+	ILI9881C_COMMAND_INSTR(0x5b, 0xab),
+	ILI9881C_COMMAND_INSTR(0x5c, 0xcd),
+	ILI9881C_COMMAND_INSTR(0x5d, 0xef),
+	ILI9881C_COMMAND_INSTR(0x5e, 0x11),
+	ILI9881C_COMMAND_INSTR(0x5f, 0x02),
+	ILI9881C_COMMAND_INSTR(0x60, 0x08),
+	ILI9881C_COMMAND_INSTR(0x61, 0x0e),
+	ILI9881C_COMMAND_INSTR(0x62, 0x0f),
+	ILI9881C_COMMAND_INSTR(0x63, 0x0c),
+	ILI9881C_COMMAND_INSTR(0x64, 0x0d),
+	ILI9881C_COMMAND_INSTR(0x65, 0x17),
+	ILI9881C_COMMAND_INSTR(0x66, 0x01),
+	ILI9881C_COMMAND_INSTR(0x67, 0x01),
+	ILI9881C_COMMAND_INSTR(0x68, 0x02),
+	ILI9881C_COMMAND_INSTR(0x69, 0x02),
+	ILI9881C_COMMAND_INSTR(0x6a, 0x00),
+	ILI9881C_COMMAND_INSTR(0x6b, 0x00),
+	ILI9881C_COMMAND_INSTR(0x6c, 0x02),
+	ILI9881C_COMMAND_INSTR(0x6d, 0x02),
+	ILI9881C_COMMAND_INSTR(0x6e, 0x16),
+	ILI9881C_COMMAND_INSTR(0x6f, 0x16),
+	ILI9881C_COMMAND_INSTR(0x70, 0x06),
+	ILI9881C_COMMAND_INSTR(0x71, 0x06),
+	ILI9881C_COMMAND_INSTR(0x72, 0x07),
+	ILI9881C_COMMAND_INSTR(0x73, 0x07),
+	ILI9881C_COMMAND_INSTR(0x74, 0x02),
+	ILI9881C_COMMAND_INSTR(0x75, 0x02),
+	ILI9881C_COMMAND_INSTR(0x76, 0x08),
+	ILI9881C_COMMAND_INSTR(0x77, 0x0e),
+	ILI9881C_COMMAND_INSTR(0x78, 0x0f),
+	ILI9881C_COMMAND_INSTR(0x79, 0x0c),
+	ILI9881C_COMMAND_INSTR(0x7a, 0x0d),
+	ILI9881C_COMMAND_INSTR(0x7b, 0x17),
+	ILI9881C_COMMAND_INSTR(0x7c, 0x01),
+	ILI9881C_COMMAND_INSTR(0x7d, 0x01),
+	ILI9881C_COMMAND_INSTR(0x7e, 0x02),
+	ILI9881C_COMMAND_INSTR(0x7f, 0x02),
+	ILI9881C_COMMAND_INSTR(0x80, 0x00),
+	ILI9881C_COMMAND_INSTR(0x81, 0x00),
+	ILI9881C_COMMAND_INSTR(0x82, 0x02),
+	ILI9881C_COMMAND_INSTR(0x83, 0x02),
+	ILI9881C_COMMAND_INSTR(0x84, 0x16),
+	ILI9881C_COMMAND_INSTR(0x85, 0x16),
+	ILI9881C_COMMAND_INSTR(0x86, 0x06),
+	ILI9881C_COMMAND_INSTR(0x87, 0x06),
+	ILI9881C_COMMAND_INSTR(0x88, 0x07),
+	ILI9881C_COMMAND_INSTR(0x89, 0x07),
+	ILI9881C_COMMAND_INSTR(0x8a, 0x02),
+	ILI9881C_SWITCH_PAGE_INSTR(0x04),
+	ILI9881C_COMMAND_INSTR(0x6e, 0x1a),
+	ILI9881C_COMMAND_INSTR(0x6f, 0x37),
+	ILI9881C_COMMAND_INSTR(0x3a, 0xa4),
+	ILI9881C_COMMAND_INSTR(0x8d, 0x1f),
+	ILI9881C_COMMAND_INSTR(0x87, 0xba),
+	ILI9881C_COMMAND_INSTR(0xb2, 0xd1),
+	ILI9881C_COMMAND_INSTR(0x88, 0x0b),
+	ILI9881C_COMMAND_INSTR(0x38, 0x01),
+	ILI9881C_COMMAND_INSTR(0x39, 0x00),
+	ILI9881C_COMMAND_INSTR(0xb5, 0x02),
+	ILI9881C_COMMAND_INSTR(0x31, 0x25),
+	ILI9881C_COMMAND_INSTR(0x3b, 0x98),
+	ILI9881C_SWITCH_PAGE_INSTR(0x01),
+	ILI9881C_COMMAND_INSTR(0x22, 0x0a),
+	ILI9881C_COMMAND_INSTR(0x31, 0x00),
+	ILI9881C_COMMAND_INSTR(0x53, 0x5a),
+	ILI9881C_COMMAND_INSTR(0x55, 0x3d),
+	ILI9881C_COMMAND_INSTR(0x50, 0x9e),
+	ILI9881C_COMMAND_INSTR(0x51, 0x99),
+	ILI9881C_COMMAND_INSTR(0x60, 0x06),
+	ILI9881C_COMMAND_INSTR(0x62, 0x20),
+	ILI9881C_COMMAND_INSTR(0xa0, 0x00),
+	ILI9881C_COMMAND_INSTR(0xa1, 0x17),
+	ILI9881C_COMMAND_INSTR(0xa2, 0x26),
+	ILI9881C_COMMAND_INSTR(0xa3, 0x13),
+	ILI9881C_COMMAND_INSTR(0xa4, 0x16),
+	ILI9881C_COMMAND_INSTR(0xa5, 0x29),
+	ILI9881C_COMMAND_INSTR(0xa6, 0x1e),
+	ILI9881C_COMMAND_INSTR(0xa7, 0x1f),
+	ILI9881C_COMMAND_INSTR(0xa8, 0x8b),
+	ILI9881C_COMMAND_INSTR(0xa9, 0x1d),
+	ILI9881C_COMMAND_INSTR(0xaa, 0x2a),
+	ILI9881C_COMMAND_INSTR(0xab, 0x7b),
+	ILI9881C_COMMAND_INSTR(0xac, 0x1a),
+	ILI9881C_COMMAND_INSTR(0xad, 0x19),
+	ILI9881C_COMMAND_INSTR(0xae, 0x4e),
+	ILI9881C_COMMAND_INSTR(0xaf, 0x24),
+	ILI9881C_COMMAND_INSTR(0xb0, 0x29),
+	ILI9881C_COMMAND_INSTR(0xb1, 0x4f),
+	ILI9881C_COMMAND_INSTR(0xb2, 0x5c),
+	ILI9881C_COMMAND_INSTR(0xb3, 0x23),
+	ILI9881C_COMMAND_INSTR(0xc0, 0x00),
+	ILI9881C_COMMAND_INSTR(0xc1, 0x17),
+	ILI9881C_COMMAND_INSTR(0xc2, 0x26),
+	ILI9881C_COMMAND_INSTR(0xc3, 0x13),
+	ILI9881C_COMMAND_INSTR(0xc4, 0x16),
+	ILI9881C_COMMAND_INSTR(0xc5, 0x29),
+	ILI9881C_COMMAND_INSTR(0xc6, 0x1e),
+	ILI9881C_COMMAND_INSTR(0xc7, 0x1f),
+	ILI9881C_COMMAND_INSTR(0xc8, 0x8b),
+	ILI9881C_COMMAND_INSTR(0xc9, 0x1d),
+	ILI9881C_COMMAND_INSTR(0xca, 0x2a),
+	ILI9881C_COMMAND_INSTR(0xcb, 0x7b),
+	ILI9881C_COMMAND_INSTR(0xcc, 0x1a),
+	ILI9881C_COMMAND_INSTR(0xcd, 0x19),
+	ILI9881C_COMMAND_INSTR(0xce, 0x4e),
+	ILI9881C_COMMAND_INSTR(0xcf, 0x24),
+	ILI9881C_COMMAND_INSTR(0xd0, 0x29),
+	ILI9881C_COMMAND_INSTR(0xd1, 0x4f),
+	ILI9881C_COMMAND_INSTR(0xd2, 0x5c),
+	ILI9881C_COMMAND_INSTR(0xd3, 0x23),
+	ILI9881C_SWITCH_PAGE_INSTR(0x00),
+	ILI9881C_COMMAND_INSTR(0x35, 0x00),
+};
+
 static const struct ili9881c_instr rpi_5inch_init[] = {
 	ILI9881C_SWITCH_PAGE_INSTR(3),
 	ILI9881C_COMMAND_INSTR(0x01, 0x00),
@@ -2425,6 +2620,23 @@ static const struct drm_display_mode am8001280g_default_mode = {
 	.height_mm	= 151,
 };
 
+static const struct drm_display_mode ppoh_default_mode = {
+	.clock		= 73400,
+
+	.hdisplay	= 800,
+	.hsync_start	= 800 + 52,
+	.hsync_end	= 800 + 52 + 4,
+	.htotal		= 800 + 52 + 4 + 12,
+
+	.vdisplay	= 1280,
+	.vsync_start	= 1280 + 60,
+	.vsync_end	= 1280 + 60 + 18,
+	.vtotal		= 1280 + 60 + 18 + 50,
+
+	.width_mm	= 94,
+	.height_mm	= 151,
+};
+
 static const struct drm_display_mode rpi_5inch_default_mode = {
 	.clock		= 83333,
 
@@ -2664,6 +2876,15 @@ static const struct ili9881c_desc am8001280g_desc = {
 		      MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
 };
 
+static const struct ili9881c_desc ppoh_desc = {
+	.init = ppoh_init,
+	.init_length = ARRAY_SIZE(ppoh_init),
+	.mode = &ppoh_default_mode,
+	.lanes = 4,
+	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+		      MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_LPM,
+};
+
 static const struct ili9881c_desc rpi_5inch_desc = {
 	.init = rpi_5inch_init,
 	.init_length = ARRAY_SIZE(rpi_5inch_init),
@@ -2708,6 +2929,7 @@ static const struct of_device_id ili9881c_of_match[] = {
 	{ .compatible = "wanchanglong,w552946aba", .data = &w552946aba_desc },
 	{ .compatible = "waveshare,7.0-dsi-touch-a", .data = &waveshare_7inch_a_desc },
 	{ .compatible = "ampire,am8001280g", .data = &am8001280g_desc },
+	{ .compatible = "industio,purple-pi-oh-panel", .data = &ppoh_desc },
 	{ .compatible = "raspberrypi,dsi-5inch", &rpi_5inch_desc },
 	{ .compatible = "raspberrypi,dsi-7inch", &rpi_7inch_desc },
 	{ }
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel
  2026-11-18  8:03 ` [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel pjh456
@ 2026-11-18  8:36   ` sashiko-bot
  2026-11-18  8:52   ` [PATCH 1/2] dt-bindings: display: panel: ilitek,ili9881c: " Krzysztof Kozlowski
  1 sibling, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-11-18  8:36 UTC (permalink / raw)
  To: pjh456; +Cc: dri-devel

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: display: panel: undocumented vendor prefix industio
- [Low] dt-bindings: display: panel: redundant width-mm and height-mm
  properties
--

commit 7361c405de28bc487b0531418138b8282051250c
Author: pjh456 <147148383@qq.com>

dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel

This commit adds the industio,purple-pi-oh-panel compatible string and
the width-mm and height-mm properties to the Ilitek ILI9881C panel
binding.

> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
> index 42e35986fbf60..72d052ef2ccbc 100644
> --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml
> @@ -20,6 +20,7 @@ properties:
>            - bananapi,lhr050h41
>            - bestar,bsd1218-a101kl68
>            - feixin,k101-im2byl02
> +          - industio,purple-pi-oh-panel
>            - raspberrypi,dsi-5inch
>            - raspberrypi,dsi-7inch
>            - startek,kd050hdfia020

[Severity: Low]
Is the "industio" vendor prefix documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml?  Adding
industio,purple-pi-oh-panel without registering the prefix triggers
checkpatch.pl and dtbs_check warnings for an undocumented vendor prefix.

> @@ -33,11 +34,13 @@ properties:
>      maxItems: 1
>  
>    backlight: true
> +  height-mm: true
>    port: true
>    power-supply: true
>    iovcc-supply: true
>    reset-gpios: true
>    rotation: true
> +  width-mm: true
>  
>  required:
>    - compatible

[Severity: Low]
Are height-mm and width-mm needed in this binding?  Each panel-specific
compatible already implies fixed physical dimensions, and
ili9881c_get_modes() in drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
populates connector->display_info.width_mm and height_mm from the static
mode descriptor rather than reading these properties from Devicetree.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_74E280A130C68EAB42115FE6AE8E6809D109@qq.com?part=1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] drm/panel: ilitek-ili9881c: add Industio Purple Pi OH panel
  2026-11-18  8:03 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: " pjh456
@ 2026-11-18  8:44   ` sashiko-bot
  0 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-11-18  8:44 UTC (permalink / raw)
  To: pjh456; +Cc: dri-devel

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/panel: ilitek-ili9881c: undocumented vendor prefix industio
  in of_match
--

commit 84f034765df38c524342d56e58717a5a36f868df
Author: pjh456 <147148383@qq.com>

drm/panel: ilitek-ili9881c: add Industio Purple Pi OH panel

This commit adds an initialization sequence, display mode, and compatible
string for the 7-inch 800x1280 MIPI-DSI panel used on the Industio Purple
Pi OH board.

> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 7bf38e96678ac..5f1270d780827 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c

[ ... ]

> @@ -2708,6 +2929,7 @@ static const struct of_device_id ili9881c_of_match[] = {
>  	{ .compatible = "wanchanglong,w552946aba", .data = &w552946aba_desc },
>  	{ .compatible = "waveshare,7.0-dsi-touch-a", .data = &waveshare_7inch_a_desc },
>  	{ .compatible = "ampire,am8001280g", .data = &am8001280g_desc },
> +	{ .compatible = "industio,purple-pi-oh-panel", .data = &ppoh_desc },

[Severity: Low]
Should the "industio" vendor prefix be documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml?  Neither this
patch nor commit "dt-bindings: display: panel: ilitek, ili9881c: add
Industio Purple Pi OH panel" adds an entry for it, which triggers a
checkpatch UNDOCUMENTED_DT_STRING warning and a dt_binding_check failure.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_74E280A130C68EAB42115FE6AE8E6809D109@qq.com?part=2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: display: panel: ilitek,ili9881c: add Industio Purple Pi OH panel
  2026-11-18  8:03 ` [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel pjh456
  2026-11-18  8:36   ` sashiko-bot
@ 2026-11-18  8:52   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-11-18  8:52 UTC (permalink / raw)
  To: pjh456, Neil Armstrong
  Cc: dri-devel, Jessica Zhang, Maxime Ripard, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley

On 18/11/2026 09:03, pjh456 wrote:
> The Purple Pi OH is shipped with an ILI9881C based 800x1280 MIPI-DSI
> panel.  The module is marked ZC-700010BH and has a 94x151 mm active
> area; the vendor device tree only describes it as a generic
> "simple-panel-dsi", so no panel-vendor compatible is known.  Add a
> board-specific compatible with ilitek,ili9881c as the fallback, and
> allow the standard width-mm/height-mm properties.
> 
> Assisted-by: DeepSeek:deepseek-v4.1-flash
> Assisted-by: Qwen:Qwen3.8-Flash-Next
> Signed-off-by: pjh456 <147148383@qq.com>


Same problems as for other patches.

Additionally, on top of DCO:

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-18  8:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261118080338.523572-1-147148383@qq.com>
2026-11-18  8:03 ` [PATCH 1/2] dt-bindings: display: panel: ilitek, ili9881c: add Industio Purple Pi OH panel pjh456
2026-11-18  8:36   ` sashiko-bot
2026-11-18  8:52   ` [PATCH 1/2] dt-bindings: display: panel: ilitek,ili9881c: " Krzysztof Kozlowski
2026-11-18  8:03 ` [PATCH 2/2] drm/panel: ilitek-ili9881c: " pjh456
2026-11-18  8:44   ` sashiko-bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.