From: sashiko-bot@kernel.org
To: "Wang Yang" <yang.wang@deepcomputing.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 6/9] riscv: dts: spacemit: Add K3 eSPI pin group
Date: Wed, 18 Nov 2026 09:08:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-220532@kernel.org> (raw)
In-Reply-To: <20261118085742.1817536-7-yang.wang@deepcomputing.io>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] riscv: dts: spacemit: boolean bias-pull-up in espi0_2_cfg
selects strong pull
- [Low] riscv: dts: spacemit: espi0_2_cfg drive-strength 25 mA at 1.8V
selects DS10
--
commit 4a5d2c0bc1f2695686ef3889084fb07b26b11220
Author: Wang Yang <yang.wang@deepcomputing.io>
riscv: dts: spacemit: Add K3 eSPI pin group
This commit adds the espi0_2_cfg pin configuration group for eSPI0 on pads 91
through 98 in the SpacemiT K3 pinctrl device tree.
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> index cb4f4f4e33aff..5bae382fa7e15 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> @@ -11,6 +11,30 @@
> #define K3_GPIO(x) (x / 32) (x % 32)
>
> &pinctrl {
> + espi0_2_cfg: espi0-2-cfg {
> + espi0-0-pins {
> + pinmux = <K3_PADCONF(91, 4)>, /* espi0 d0 */
> + <K3_PADCONF(92, 4)>, /* espi0 d1 */
> + <K3_PADCONF(93, 4)>, /* espi0 d2 */
> + <K3_PADCONF(94, 4)>, /* espi0 d3 */
> + <K3_PADCONF(95, 4)>, /* espi0 cs */
> + <K3_PADCONF(97, 4)>, /* espi0 reset */
> + <K3_PADCONF(98, 4)>; /* espi0 alert */
> +
> + bias-pull-up; /* normal pull-up */
[Severity: Medium]
Should this be bias-pull-up = <0> instead of a boolean property?
Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml requires
an integer argument (0 for normal pull-up, 1 for strong pull-up), so a bare
bias-pull-up fails dtbs_check. At runtime, generic pinconf supplies a
default argument of 1 when no cell value is given, causing
spacemit_pinconf_generate_config() to set PAD_STRONG_PULL instead of normal
pull-up.
> + drive-strength = <25>; /* DS8 */
> + power-source = <1800>;
> + };
> +
> + espi0-1-pins {
> + pinmux = <K3_PADCONF(96, 4)>; /* espi0 clk */
> +
> + bias-pull-down; /* normal pull-down */
> + drive-strength = <25>; /* DS8 */
> + power-source = <1800>;
> + };
> + };
[Severity: Low]
Does drive-strength = <25> with power-source = <1800> select DS10 rather than
the DS8 noted in the comments?
In drivers/pinctrl/spacemit/pinctrl-k1.c, k3_drive_conf maps 25 mA to
register value 8 (DS8) only at 3.3V (ds_3v3_tbl). For 1.8V pads
(ds_1v8_tbl), 25 mA maps to register value 10 (DS10), while DS8 corresponds
to 21 mA.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118085742.1817536-1-yang.wang@deepcomputing.io?part=6
next prev parent reply other threads:[~2026-11-18 9:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:57 [PATCH 0/9] Add SpacemiT K3 FML13V05 EC keyboard support Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 1/9] dt-bindings: bus: Add SpacemiT K3 eSPI controller Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:18 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 2/9] dt-bindings: embedded-controller: Add SpacemiT K3 EC window Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 3/9] bus: Add SpacemiT K3 eSPI controller support Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:23 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 4/9] platform/chrome: Allow ChromeOS platform support on RISC-V Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 5/9] platform/chrome: Add SpacemiT K3 eSPI EC transport Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 6/9] riscv: dts: spacemit: Add K3 eSPI pin group Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:08 ` sashiko-bot [this message]
2026-11-18 8:57 ` [PATCH 7/9] riscv: dts: spacemit: Describe the K3 eSPI controller Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:25 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 8/9] riscv: dts: spacemit: Enable the FML13V05 EC keyboard Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:20 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 9/9] riscv: defconfig: Enable the FML13V05 EC keyboard modules Wang Yang
2026-11-18 8:57 ` Wang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220532@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yang.wang@deepcomputing.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.