From: sashiko-bot@kernel.org
To: "Wang Yang" <yang.wang@deepcomputing.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/9] dt-bindings: bus: Add SpacemiT K3 eSPI controller
Date: Wed, 18 Nov 2026 09:18:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-220540@kernel.org> (raw)
In-Reply-To: <20261118085742.1817536-2-yang.wang@deepcomputing.io>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: bus: spacemit,k3-espi: unprefixed vendor properties
and MHz units
--
commit d42a1666765549829c0c9df0a5e923d2f92c4eb4
Author: Wang Yang <yang.wang@deepcomputing.io>
dt-bindings: bus: Add SpacemiT K3 eSPI controller
This commit adds the Devicetree binding schema for the SpacemiT K3 eSPI
controller, describing its peripheral memory translation window, clocks,
resets, and link configuration properties.
> diff --git a/Documentation/devicetree/bindings/bus/spacemit,k3-espi.yaml b/Documentation/devicetree/bindings/bus/spacemit,k3-espi.yaml
> new file mode 100644
> index 0000000000000..30985ee0a61a1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/spacemit,k3-espi.yaml
> @@ -0,0 +1,146 @@
[ ... ]
> + pr-mem-base0:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: First peripheral memory translation base.
> +
> + pr-mem-base1:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Second peripheral memory translation base.
> +
> + operating-frequency:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Requested link clock frequency in MHz.
> + enum: [20, 25, 33, 50, 66]
> + default: 20
> +
> + io-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: Requested number of eSPI data lines.
> + enum: [single, dual, quad]
> + default: single
> +
> + alert-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: Use the shared IO1 line or the dedicated alert pin.
> + enum: [io1, pin]
> + default: io1
> +
> + alert-type:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: Electrical mode of the dedicated alert pin.
> + enum: [open-drain, push-pull]
> + default: open-drain
> +
> + watchdog-timeout:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Controller watchdog counter value.
> + maximum: 65535
> + default: 65535
> +
> + crc-enable:
> + type: boolean
> + description: Enable link CRC checking.
> +
> + auto-gating-enable:
> + type: boolean
> + description: Enable automatic controller clock gating.
> +
> + peripheral-channel-enable:
> + type: boolean
> + description: Enable the peripheral channel.
> +
> + vwire-channel-enable:
> + type: boolean
> + description: Enable the virtual-wire channel.
> +
> + oob-channel-enable:
> + type: boolean
> + description: Enable the out-of-band channel.
> +
> + flash-channel-enable:
> + type: boolean
> + description: Enable the flash access channel.
[Severity: Low]
Should these controller-specific properties use the spacemit, vendor
prefix or standard Devicetree properties and unit suffixes?
Defining pr-mem-base0 through flash-channel-enable without a vendor prefix
puts 13 device-specific property names into the global DT property
namespace, contrary to Documentation/devicetree/bindings/writing-bindings.rst.
In addition, operating-frequency uses bare MHz numbers instead of a
standard frequency property in Hz (such as max-frequency or a -hz suffix),
and pr-mem-base0 and pr-mem-base1 encode raw peripheral memory base
addresses that duplicate the address translation already described by
ranges.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118085742.1817536-1-yang.wang@deepcomputing.io?part=1
next prev parent reply other threads:[~2026-11-18 9:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:57 [PATCH 0/9] Add SpacemiT K3 FML13V05 EC keyboard support Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 1/9] dt-bindings: bus: Add SpacemiT K3 eSPI controller Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:18 ` sashiko-bot [this message]
2026-11-18 8:57 ` [PATCH 2/9] dt-bindings: embedded-controller: Add SpacemiT K3 EC window Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 3/9] bus: Add SpacemiT K3 eSPI controller support Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:23 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 4/9] platform/chrome: Allow ChromeOS platform support on RISC-V Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 5/9] platform/chrome: Add SpacemiT K3 eSPI EC transport Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 8:57 ` [PATCH 6/9] riscv: dts: spacemit: Add K3 eSPI pin group Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:08 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 7/9] riscv: dts: spacemit: Describe the K3 eSPI controller Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:25 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 8/9] riscv: dts: spacemit: Enable the FML13V05 EC keyboard Wang Yang
2026-11-18 8:57 ` Wang Yang
2026-11-18 9:20 ` sashiko-bot
2026-11-18 8:57 ` [PATCH 9/9] riscv: defconfig: Enable the FML13V05 EC keyboard modules Wang Yang
2026-11-18 8:57 ` Wang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220540@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yang.wang@deepcomputing.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.