All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information
@ 2026-11-19 10:25 Max Merchel
  2026-11-19 10:37 ` sashiko-bot
  0 siblings, 1 reply; 3+ messages in thread
From: Max Merchel @ 2026-11-19 10:25 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: Max Merchel, linux, devicetree, imx, linux-arm-kernel

MBa6x has board-information (mac address, serialnumber, board)
located in EEPROM at offset 0x20.

Signed-off-by: Max Merchel <Max.Merchel@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi | 4 ++++
 arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
index aca320ee8f476..9b199b277c220 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
@@ -29,6 +29,10 @@ nvmem-layout {
 			#address-cells = <1>;
 			#size-cells = <1>;
 
+			board_info: board-info@20 {
+				reg = <0x20 0x60>;
+			};
+
 			mba_mac_address: mac-address@20 {
 				reg = <0x20 0x6>;
 			};
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
index c7bbd6195fef1..517913abbc66d 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
@@ -39,6 +39,10 @@ nvmem-layout {
 			#address-cells = <1>;
 			#size-cells = <1>;
 
+			board_info: board-info@20 {
+				reg = <0x20 0x60>;
+			};
+
 			mba_mac_address: mac-address@20 {
 				reg = <0x20 0x6>;
 			};

base-commit: e8017d29067fd1310a65c3494ce1a1b492adbac6
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information
  2026-11-19 10:25 [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information Max Merchel
@ 2026-11-19 10:37 ` sashiko-bot
  2026-11-19 12:13   ` Max Merchel
  0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-11-19 10:37 UTC (permalink / raw)
  To: Max Merchel; +Cc: devicetree, imx, robh, conor+dt, Frank.Li

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: imx6qdl-mba6: duplicate @20 unit-address in
  nvmem-layout
--

commit b5a0ac272fe3356ca3f0ff5cbf739f7f5d760dab
Author: Max Merchel <Max.Merchel@ew.tq-group.com>

ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information

This commit adds an EEPROM fixed-layout nvmem cell at offset 0x20 covering
board information on MBa6a and MBa6b carrier boards.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> index aca320ee8f476..9b199b277c220 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
> @@ -29,6 +29,10 @@ nvmem-layout {
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> +			board_info: board-info@20 {
> +				reg = <0x20 0x60>;
> +			};
> +
>  			mba_mac_address: mac-address@20 {
>  				reg = <0x20 0x6>;
>  			};
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> index c7bbd6195fef1..517913abbc66d 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
> @@ -39,6 +39,10 @@ nvmem-layout {
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> +			board_info: board-info@20 {
> +				reg = <0x20 0x60>;
> +			};
> +
>  			mba_mac_address: mac-address@20 {
>  				reg = <0x20 0x6>;
>  			};

[Severity: Low]
Does adding board-info@20 alongside mac-address@20 under the same
nvmem-layout parent in both dtsi files cause duplicate unit-address dtc
warnings?

Because both enabled sibling nodes share the @20 unit-address and overlap
at offset 0x20, building the MBa6x DTBs with W=1 or W=2 triggers
unique_unit_address_if_enabled and unique_unit_address warnings.  Could the
fields be defined as non-overlapping cells at their respective offsets, or
exposed through a dedicated nvmem layout?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119102531.2995127-1-Max.Merchel@ew.tq-group.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information
  2026-11-19 10:37 ` sashiko-bot
@ 2026-11-19 12:13   ` Max Merchel
  0 siblings, 0 replies; 3+ messages in thread
From: Max Merchel @ 2026-11-19 12:13 UTC (permalink / raw)
  To: sashiko-reviews; +Cc: devicetree, imx, robh, conor+dt, Frank.Li, linux


On 11/19/26 11:37, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] ARM: dts: imx6qdl-mba6: duplicate @20 unit-address in
>    nvmem-layout
> --
>
> commit b5a0ac272fe3356ca3f0ff5cbf739f7f5d760dab
> Author: Max Merchel <Max.Merchel@ew.tq-group.com>
>
> ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information
>
> This commit adds an EEPROM fixed-layout nvmem cell at offset 0x20 covering
> board information on MBa6a and MBa6b carrier boards.
>
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
>> index aca320ee8f476..9b199b277c220 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6a.dtsi
>> @@ -29,6 +29,10 @@ nvmem-layout {
>>   			#address-cells = <1>;
>>   			#size-cells = <1>;
>>   
>> +			board_info: board-info@20 {
>> +				reg = <0x20 0x60>;
>> +			};
>> +
>>   			mba_mac_address: mac-address@20 {
>>   				reg = <0x20 0x6>;
>>   			};
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
>> index c7bbd6195fef1..517913abbc66d 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-mba6b.dtsi
>> @@ -39,6 +39,10 @@ nvmem-layout {
>>   			#address-cells = <1>;
>>   			#size-cells = <1>;
>>   
>> +			board_info: board-info@20 {
>> +				reg = <0x20 0x60>;
>> +			};
>> +
>>   			mba_mac_address: mac-address@20 {
>>   				reg = <0x20 0x6>;
>>   			};
> [Severity: Low]
> Does adding board-info@20 alongside mac-address@20 under the same
> nvmem-layout parent in both dtsi files cause duplicate unit-address dtc
> warnings?
>
> Because both enabled sibling nodes share the @20 unit-address and overlap
> at offset 0x20, building the MBa6x DTBs with W=1 or W=2 triggers
> unique_unit_address_if_enabled and unique_unit_address warnings.  Could the
> fields be defined as non-overlapping cells at their respective offsets, or
> exposed through a dedicated nvmem layout?
>
Hello,

the MAC address is the first part of the TQ-EEPROM structure for 
module/board data (MAC, serial number, type).

The function “nvmem_get_mac_address” in “net/ethernet/eth.c” retrieves 
an nvmem cell containing the MAC address and compares its length to 
ETH_ALEN. Therefore, it is not possible to use the same nvmem layout.

Consequently, two nvmem layouts are required, both starting at the same 
offset.

I have not found a way to use only the first part of an “nvmem layout” 
or to create sub layouts for sections of an existing layout.


-- 
Best regards,
Max

TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19 12:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 10:25 [PATCH] ARM: dts: imx6qdl-mba6: Add EEPROM nvmem cell for all board information Max Merchel
2026-11-19 10:37 ` sashiko-bot
2026-11-19 12:13   ` Max Merchel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.