From: sashiko-bot@kernel.org
To: "Geert Uytterhoeven" <geert+renesas@glider.be>
Cc: mfd@lists.linux.dev, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, lee@kernel.org
Subject: Re: [PATCH 2/4] input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC
Date: Thu, 19 Nov 2026 13:57:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-223227@kernel.org> (raw)
In-Reply-To: <27990d37c1b7854d9d5f0d0a0f45193af4b9ec51.1795095742.git.geert+renesas@glider.be>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] Input: missing I2C dependency causes build failure in
asus_ec_keys_probe()
--
commit fd9324a9324e26f4ff25ae83d8027b69e04951cd
Author: Geert Uytterhoeven <geert+renesas@glider.be>
input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC
This commit relaxes the Kconfig dependency for
KEYBOARD_ASUS_TRANSFORMER_EC to allow compile-testing when
MFD_ASUS_TRANSFORMER_EC is disabled.
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 728bc068667e7..2709cff6d00bc 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -91,7 +91,7 @@ config KEYBOARD_APPLESPI
>
> config KEYBOARD_ASUS_TRANSFORMER_EC
> tristate "Asus Transformer's Mobile Dock multimedia keys"
> - depends on MFD_ASUS_TRANSFORMER_EC
> + depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST
[Severity: Medium]
Does KEYBOARD_ASUS_TRANSFORMER_EC also need to depend on I2C?
asus_ec_keys_probe() calls i2c_adapter_id(), which is only declared in
include/linux/i2c.h when CONFIG_I2C is enabled and has no fallback stub.
With COMPILE_TEST=y and I2C=n, building this driver fails with an
implicit function declaration error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795095742.git.geert+renesas@glider.be?part=2
next prev parent reply other threads:[~2026-11-19 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 13:52 [PATCH 0/4] Improve MFD_ASUS_TRANSFORMER_EC dependencies Geert Uytterhoeven
2026-11-19 13:52 ` [PATCH 1/4] mfd: MFD_ASUS_TRANSFORMER_EC should depend on ARCH_TEGRA Geert Uytterhoeven
2026-11-19 13:52 ` [PATCH 2/4] input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:57 ` sashiko-bot [this message]
2026-11-19 13:52 ` [PATCH 3/4] input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:57 ` sashiko-bot
2026-11-19 13:52 ` [PATCH 4/4] power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:59 ` sashiko-bot
2026-11-19 14:51 ` [PATCH 0/4] Improve MFD_ASUS_TRANSFORMER_EC dependencies Svyatoslav Ryhel
2026-11-20 8:45 ` Geert Uytterhoeven
2026-11-20 15:14 ` Svyatoslav Ryhel
2026-11-20 15:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223227@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.