All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Geert Uytterhoeven" <geert+renesas@glider.be>
Cc: mfd@lists.linux.dev, linux-input@vger.kernel.org,
	dmitry.torokhov@gmail.com, lee@kernel.org
Subject: Re: [PATCH 4/4] power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC
Date: Thu, 19 Nov 2026 13:59:57 +0000	[thread overview]
Message-ID: <sashiko-outbox-223232@kernel.org> (raw)
In-Reply-To: <8258f896cccf3c27d3034a6eb9bb6f7becfbc1dc.1795095742.git.geert+renesas@glider.be>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] power: supply: missing I2C dependency on
  BATTERY_ASUS_TRANSFORMER_EC
--

commit 08aa893cb21ca94a6803c481fce373ce94bd11f3
Author: Geert Uytterhoeven <geert+renesas@glider.be>

power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC

This commit relaxes the MFD_ASUS_TRANSFORMER_EC dependency on
BATTERY_ASUS_TRANSFORMER_EC when COMPILE_TEST is enabled.

> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 16d0a38b41b7e..ace0c4ae721ae 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -124,7 +124,7 @@ config BATTERY_CHAGALL
>  
>  config BATTERY_ASUS_TRANSFORMER_EC
>  	tristate "Asus Transformer's battery driver"
> -	depends on MFD_ASUS_TRANSFORMER_EC
> +	depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST

[Severity: Medium]
Does BATTERY_ASUS_TRANSFORMER_EC also need to depend on I2C?

MFD_ASUS_TRANSFORMER_EC depends on I2C, so relaxing the dependency with
"|| COMPILE_TEST" allows BATTERY_ASUS_TRANSFORMER_EC to be built with
CONFIG_I2C=n or built-in with CONFIG_I2C=m.  Because
asus_ec_battery_refresh() calls i2c_smbus_read_i2c_block_data(), which is
only declared and built when CONFIG_I2C is enabled, those configurations
fail to compile or link.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795095742.git.geert+renesas@glider.be?part=4

  reply	other threads:[~2026-11-19 13:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:52 [PATCH 0/4] Improve MFD_ASUS_TRANSFORMER_EC dependencies Geert Uytterhoeven
2026-11-19 13:52 ` [PATCH 1/4] mfd: MFD_ASUS_TRANSFORMER_EC should depend on ARCH_TEGRA Geert Uytterhoeven
2026-11-19 13:52 ` [PATCH 2/4] input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:57   ` sashiko-bot
2026-11-19 13:52 ` [PATCH 3/4] input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:57   ` sashiko-bot
2026-11-19 13:52 ` [PATCH 4/4] power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:59   ` sashiko-bot [this message]
2026-11-19 14:51 ` [PATCH 0/4] Improve MFD_ASUS_TRANSFORMER_EC dependencies Svyatoslav Ryhel
2026-11-20  8:45   ` Geert Uytterhoeven
2026-11-20 15:14     ` Svyatoslav Ryhel
2026-11-20 15:33       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223232@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.