All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/color: Program the 3D LUT on the plane's own pipe with joiner
@ 2026-11-19 16:59 Chaitanya Kumar Borah
  2026-11-19 17:36 ` sashiko-bot
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Chaitanya Kumar Borah @ 2026-11-19 16:59 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: Chaitanya Kumar Borah, Uma Shankar

With joiner, a secondary pipe plane's uapi.crtc points at the primary
CRTC. intel_color_load_3dlut() and intel_color_plane_commit_arm() use
it, so the 3D LUT is loaded and enabled twice on the primary pipe and
never on the secondary, leaving the secondary pipe's part of the screen
without it.

Use hw.crtc, the CRTC the plane is actually on.

Cc: Uma Shankar <uma.shankar@intel.com>
Fixes: 65db7a1f9cf7 ("drm/i915/color: Add 3D LUT to color pipeline")
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
 drivers/gpu/drm/i915/display/intel_color.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index 4070dc8d97d9..9060c29de533 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -4278,7 +4278,7 @@ void intel_color_plane_commit_arm(struct intel_dsb *dsb,
 				  const struct intel_plane_state *plane_state)
 {
 	struct intel_display *display = to_intel_display(plane_state);
-	struct intel_crtc *crtc = to_intel_crtc(plane_state->uapi.crtc);
+	struct intel_crtc *crtc = to_intel_crtc(plane_state->hw.crtc);
 
 	if (crtc && intel_color_crtc_has_3dlut(display, crtc->pipe))
 		glk_lut_3d_commit(dsb, crtc, !!plane_state->hw.lut_3d);
@@ -4318,7 +4318,7 @@ intel_color_load_3dlut(struct intel_dsb *dsb,
 		       const struct intel_plane_state *plane_state)
 {
 	struct intel_display *display = to_intel_display(plane_state);
-	struct intel_crtc *crtc = to_intel_crtc(plane_state->uapi.crtc);
+	struct intel_crtc *crtc = to_intel_crtc(plane_state->hw.crtc);
 
 	if (crtc && intel_color_crtc_has_3dlut(display, crtc->pipe))
 		glk_load_lut_3d(dsb, crtc, plane_state->hw.lut_3d);
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-20  0:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 16:59 [PATCH] drm/i915/color: Program the 3D LUT on the plane's own pipe with joiner Chaitanya Kumar Borah
2026-11-19 17:36 ` sashiko-bot
2026-11-19 23:34 ` ✓ i915.CI.BAT: success for " Patchwork
2026-11-19 23:39 ` ✓ CI.KUnit: " Patchwork
2026-11-20  0:15 ` ✓ Xe.CI.BAT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.