From: sashiko-bot@kernel.org
To: "Enzo Adriano" <enzo.adriano.code@gmail.com>
Cc: devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board
Date: Thu, 19 Nov 2026 18:26:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-223768@kernel.org> (raw)
In-Reply-To: <448e7551a6f560d8b8ede245ccfbc74101c76ef4.1795034153.git.enzo.adriano.code@gmail.com>
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] arm64: dts: allwinner: unbound x-powers,axp318w PMIC defers
uart0 and mmc0
- [High] arm64: dts: allwinner: cubie-a7s sets 1.8V vcc-pf-supply for
3.3V-only mmc0
- [Low] arm64: dts: allwinner: undocumented allwinner,sun60i-a733-uart
compatible
--
commit 3e2ac1a2ecf97dc48633ea46df0bd68b383bb1c3
Author: Enzo Adriano <enzo.adriano.code@gmail.com>
arm64: dts: allwinner: add Radxa Cubie A7S board
This commit adds initial Devicetree support for the Radxa Cubie A7S board,
enabling UART0, the AXP318W PMIC on R-I2C0, CPU and GPIO bank supplies, and
MMC0.
> diff --git a/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts
> new file mode 100644
> index 0000000000000..9af9a68950d83
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun60i-a733-cubie-a7s.dts
> @@ -0,0 +1,287 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> +/dts-v1/;
> +
> +#include "sun60i-a733.dtsi"
[ ... ]
> +&mmc0 {
> + bus-width = <4>;
> + cap-sd-highspeed;
> + cd-gpios = <&pio 5 6 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>;
> + disable-wp;
> + max-frequency = <50000000>;
> + no-1-8-v;
> + vmmc-supply = <®_swout2>;
> + /* The 3.3 V path uses VCC-IO; no Port F voltage switching yet. */
> + vqmmc-supply = <®_swout2>;
> +
> + status = "okay";
> +};
> +
> +&osc {
> + clock-frequency = <26000000>;
> +};
> +
> +&pio {
> + vcc-pb-supply = <®_swout2>;
> + vcc-pc-supply = <®_cldo5>;
> + vcc-pd-supply = <®_swout1>;
> + vcc-pe-supply = <®_bldo1>;
> + vcc-pf-supply = <®_cldo5>;
> + vcc-pg-supply = <®_aldo1>;
> + vcc-ph-supply = <®_swout2>;
> + vcc-pj-supply = <®_swout1>;
> + vcc-pk-supply = <®_bldo1>;
> +};
[Severity: High]
Does setting vcc-pf-supply to reg_cldo5 (1.8 V) conflict with mmc0
operating Port F at 3.3 V via reg_swout2?
When mmc0 requests PF0-PF6, sunxi_pmx_request() ->
sunxi_pinctrl_set_io_bias_cfg() reads 1800000 uV from reg_cldo5 and
programs Port F's PIO_POW_MOD_SEL bit for 1.8 V operation instead of the
active 3.3 V signaling rail. In addition,
drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c currently sets
.io_bias_cfg_variant = BIAS_VOLTAGE_PIO_POW_MODE_SEL rather than
BIAS_VOLTAGE_PIO_POW_MODE_CTL_INV, so connecting vcc-p*-supply on &pio
without that pinctrl change programs inverted IO bias mode bits across the
supplied PIO banks.
> +
> +&r_i2c0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&r_i2c0_pl_pins>;
> +
> + status = "okay";
> +
> + axp318w: pmic@36 {
> + compatible = "x-powers,axp318w";
> + reg = <0x36>;
> + interrupt-parent = <&nmi_intc>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> + #interrupt-cells = <1>;
> +
> + aldo156in-supply = <®_ps>;
> + aldo234in-supply = <®_aldo1>;
> + bldoin-supply = <®_ldo_input>;
> + cldoin-supply = <®_ldo_input>;
> + dldoin-supply = <®_ps>;
> + eldoin-supply = <®_dcdc9>;
> + ips-supply = <®_ps>;
> + vin19-supply = <®_ps>;
> + vin23-supply = <®_ps>;
> + vin45-supply = <®_ps>;
> + vin678-supply = <®_ps>;
[Severity: High]
Will axp318w fail to bind and leave uart0, mmc0, pio, and r_pio deferred?
Neither the Devicetree bindings nor the axp20x MFD and regulator drivers
have support for "x-powers,axp318w" (or its grouped input supplies and
dcdc8, dcdc9, swout1, and swout2 regulator nodes), so pmic@36 never probes
and dtbs_check fails validation. Because the supply phandles on &pio,
&r_pio, &mmc0, and &cpu0..&cpu7 point to present DT nodes under axp318w
whose regulators never register, of_regulator_dev_lookup() returns
-EPROBE_DEFER instead of falling back to the dummy regulator, causing
sunxi_pmx_request() for uart0 (PB9/PB10) and mmc0 (PF0-PF6) as well as
mmc_regulator_get_supply() to defer indefinitely.
[ ... ]
> +&uart0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pb_pins>;
> +
> + status = "okay";
> +};
[Severity: Low]
sun60i-a733.dtsi declares uart0..uart6 and r_uart0..r_uart1 with
compatible = "allwinner,sun60i-a733-uart", "snps,dw-apb-uart", but
"allwinner,sun60i-a733-uart" is not documented in
Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml, causing
dtbs_check validation failures on sun60i-a733-cubie-a7s.dtb.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795034153.git.enzo.adriano.code@gmail.com?part=3
prev parent reply other threads:[~2026-11-19 18:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 18:09 [PATCH v4 0/3] arm64: dts: allwinner: add A733/Cubie A7S support Enzo Adriano
2026-11-19 18:09 ` [PATCH v4 1/3] dt-bindings: arm: sunxi: document Radxa Cubie A7S Enzo Adriano
2026-11-19 18:09 ` [PATCH v4 2/3] arm64: dts: allwinner: add A733 SoC description Enzo Adriano
2026-11-19 18:30 ` sashiko-bot
2026-11-19 18:09 ` [PATCH v4 3/3] arm64: dts: allwinner: add Radxa Cubie A7S board Enzo Adriano
2026-11-19 18:26 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223768@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=enzo.adriano.code@gmail.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.