From: sashiko-bot@kernel.org
To: "Aibing Chen" <chenaibing@cmss.chinamobile.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] net: hso: cap the MTU and drop oversized frames
Date: Fri, 20 Nov 2026 01:28:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-224305@kernel.org> (raw)
In-Reply-To: <20261120012309.19-1-chenaibing@cmss.chinamobile.com>
> hso_net_start_xmit() copies skb->len bytes into odev->mux_bulk_tx_buf,
> which is a fixed MUX_BULK_TX_BUF_SIZE (2048) allocation made by
> hso_create_net_device(), and passes the same length to
> usb_fill_bulk_urb(). Nothing bounds skb->len today: the net device does
> not set max_mtu, and even with max_mtu set the core does not clamp the
> length of the frames handed to ndo_start_xmit(), so AF_PACKET with
> PACKET_VNET_HDR, tpacket_snd() with a vnet header and an IPv4 route MTU
> metric above the device MTU can all deliver larger skbs.
>
> Cap the MTU at the buffer size and drop oversized frames in
> hso_net_start_xmit() instead of copying them past the end of the buffer.
>
> Fixes: 72dc1c096c70 ("HSO: add option hso driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Aibing Chen <chenaibing@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120012309.19-1-chenaibing@cmss.chinamobile.com?part=1
prev parent reply other threads:[~2026-11-20 1:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 1:49 [PATCH] net: hso: cap the MTU to the mux tx buffer size Aibing Chen
2026-11-16 1:53 ` netdev-bot+sinfo
2026-11-16 2:58 ` Aibing Chen
2026-11-16 1:58 ` sashiko-bot
2026-11-19 19:50 ` netdev-bot+sashiko
2026-11-20 1:23 ` [PATCH v2] net: hso: cap the MTU and drop oversized frames Aibing Chen
2026-11-20 1:26 ` netdev-bot+sinfo
2026-11-20 9:53 ` Aibing Chen
2026-11-20 1:28 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224305@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=chenaibing@cmss.chinamobile.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.