All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Changyul Lee" <lcy8047@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2] net/mlx5e: IPsec, Fix RX mapped ID leak when adding a rule fails
Date: Fri, 20 Nov 2026 03:04:32 +0000	[thread overview]
Message-ID: <sashiko-outbox-224390@kernel.org> (raw)
In-Reply-To: <20261120025501.1675212-1-lcy8047@gmail.com>

> In switchdev mode, rx_add_rule() calls
> mlx5_esw_ipsec_rx_setup_modify_header(), which allocates a mapped ID for
> the SA in ipsec->ipsec_obj_id_map. If a later step fails, the error path
> frees the modify header but leaves the ID in the XArray, and
> mlx5e_xfrm_add_state() then frees the SA entry. Each failed inbound
> packet offload SA leaks one of the 2047 IDs. Once they are used up, no
> new inbound SA can be offloaded until the IPsec context is cleaned up.
> 
> Release the ID on the error path under the same condition that maps it.
> This label is reached only after the mapping succeeded and stored the
> new ID in rx_mapped_id, so the copy that mlx5e_accel_ipsec_fs_modify()
> passes in never loses the ID of the original SA.
> 
> Fixes: 91bafc638ed4 ("net/mlx5e: Handle IPsec offload for RX datapath in switchdev mode")
> Signed-off-by: Changyul Lee <lcy8047@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120025501.1675212-1-lcy8047@gmail.com?part=1


      reply	other threads:[~2026-11-20  3:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  2:55 [PATCH net v2] net/mlx5e: IPsec, Fix RX mapped ID leak when adding a rule fails Changyul Lee
2026-11-20  3:04 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224390@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lcy8047@gmail.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.