All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net v2] net/mlx5e: IPsec, Fix RX mapped ID leak when adding a rule fails
@ 2026-11-20  2:55 Changyul Lee
  2026-11-20  3:04 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Changyul Lee @ 2026-11-20  2:55 UTC (permalink / raw)
  To: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch,
	Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: Boris Pismenny, Jianbo Liu, netdev, linux-rdma, linux-kernel,
	Changyul Lee

In switchdev mode, rx_add_rule() calls
mlx5_esw_ipsec_rx_setup_modify_header(), which allocates a mapped ID for
the SA in ipsec->ipsec_obj_id_map. If a later step fails, the error path
frees the modify header but leaves the ID in the XArray, and
mlx5e_xfrm_add_state() then frees the SA entry. Each failed inbound
packet offload SA leaks one of the 2047 IDs. Once they are used up, no
new inbound SA can be offloaded until the IPsec context is cleaned up.

Release the ID on the error path under the same condition that maps it.
This label is reached only after the mapping succeeded and stored the
new ID in rx_mapped_id, so the copy that mlx5e_accel_ipsec_fs_modify()
passes in never loses the ID of the original SA.

Fixes: 91bafc638ed4 ("net/mlx5e: Handle IPsec offload for RX datapath in switchdev mode")
Signed-off-by: Changyul Lee <lcy8047@gmail.com>
---
Changes in v2:
 - Release the ID under the same condition that maps it, as suggested
   by Jianbo.

v1: https://lore.kernel.org/all/20261118051247.3885308-1-lcy8047@gmail.com/

Found with a static analysis tool we are developing.

Jianbo tested the same change on ConnectX-7 in switchdev mode with fault
injection on one RX SA add: 46 of the 2047 IDs were lost without the
fix, none with it:
https://lore.kernel.org/all/96a5ce67-89c8-4010-bfc4-4553e1aefe87@nvidia.com/

On our side it is compile-tested only, with x86_64_defconfig plus
MLX5_CORE_EN, MLX5_ESWITCH, MLX5_EN_IPSEC and W=1.

 drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c
index 5c69e89b13a7..1f0ed8ab75d5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c
@@ -2163,6 +2163,8 @@ static int rx_add_rule(struct mlx5e_ipsec_sa_entry *sa_entry)
 err_pkt_reformat:
 	if (flow_act.modify_hdr)
 		mlx5_modify_header_dealloc(mdev, flow_act.modify_hdr);
+	if (!attrs->drop && rx == ipsec->rx_esw)
+		mlx5_esw_ipsec_rx_id_mapping_remove(sa_entry);
 err_mod_header:
 	kvfree(spec);
 err_alloc:

base-commit: 2a324a58a084c5cfd7e5a2f55e0786bee170a4a5
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-20  3:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20  2:55 [PATCH net v2] net/mlx5e: IPsec, Fix RX mapped ID leak when adding a rule fails Changyul Lee
2026-11-20  3:04 ` sashiko-bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.