All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@flipper.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 Ethernet PHYs by their ID
Date: Fri, 20 Nov 2026 10:56:00 +0000	[thread overview]
Message-ID: <sashiko-outbox-224974@kernel.org> (raw)
In-Reply-To: <20261120-rk3576-phys-v1-2-6382cd14e3dc@flipper.net>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: rockchip: Fixes tag cites board addition instead of
  63136c6fecf4
--

commit 5dc14b4c5e3f94d0bf427bf2ff5dad981d4f435e
Author: Alexey Charkov <alchark@flipper.net>

> arm64: dts: rockchip: Describe Sige5 Ethernet PHYs by their ID
>
> Both Sige5 GMACs connect to an RTL8211F PHY (ID 0x001cc916) with its
> reset line in the PHY node. With only the generic C22 compatible, an OS
> has to read the PHY ID registers before it can bind a driver, and only
> that driver releases the reset line. Unless an earlier boot stage has
> already released it, the PHY stays in reset, never answers on MDIO, and
> neither Ethernet port comes up. Booting straight from U-Boot SPL in
> Falcon mode hits exactly that.
>
> Name the PHY by its ID, so it binds without the ID read and comes out of
> reset as it does. Name the node ethernet-phy@1 as well, as the Realtek
> PHY binding the ID compatible selects requires.
>
> Fixes: 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board")
> Signed-off-by: Alexey Charkov <alchark@flipper.net>

[Severity: Low]
In 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board"),
the PHY reset lines were described via snps,reset-gpio on the gmac0 and
gmac1 nodes, which stmmac_mdio_reset() deasserts before probing the MDIO
bus for PHY IDs.  Commit 63136c6fecf4 ("arm64: dts: rockchip: Use standard
PHY reset properties for RK3576 ArmSoM Sige5") moved those reset lines into
reset-gpios on rgmii_phy0 and rgmii_phy1 while keeping the generic C22
compatible.

Should the Fixes tag instead be:

  Fixes: 63136c6fecf4 ("arm64: dts: rockchip: Use standard PHY reset properties for RK3576 ArmSoM Sige5")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rk3576-phys-v1-0-6382cd14e3dc@flipper.net?part=2

  reply	other threads:[~2026-11-20 10:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
2026-11-20 10:48 ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 " Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:56   ` sashiko-bot [this message]
2026-11-20 11:24     ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 3/7] arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 4/7] arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 5/7] arm64: dts: rockchip: Enable ALDPS on Sige5 " Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 11:01   ` sashiko-bot
2026-11-20 11:34     ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 7/7] arm64: dts: rockchip: Shorten Sige5 " Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224974@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alchark@flipper.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.