All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alexey Charkov" <alchark@flipper.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing
Date: Fri, 20 Nov 2026 11:01:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-224978@kernel.org> (raw)
In-Reply-To: <20261120-rk3576-phys-v1-6-6382cd14e3dc@flipper.net>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: rockchip: RTL8211F reset-deassert-us below 72ms
  minimum
--

commit 0900c61dff0b0908a212846ea06a953d5d033faf
Author: Alexey Charkov <alchark@flipper.net>

arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing

This commit reduces reset-assert-us and reset-deassert-us for the two
RTL8211F Ethernet PHYs on the FriendlyElec NanoPi M5 from 20ms/100ms to
10ms/30ms.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
> index 638e00b6e1658..3444198b6cf66 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-nanopi-m5.dts
> @@ -809,8 +809,8 @@ rgmii_phy0: ethernet-phy@1 {
>  		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&gmac0_int>, <&gmac0_rst>;
> -		reset-assert-us = <20000>;
> -		reset-deassert-us = <100000>;
> +		reset-assert-us = <10000>;
> +		reset-deassert-us = <30000>;
>  		reset-gpios = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>;
>  		realtek,aldps-enable;
>  	};
> @@ -824,8 +824,8 @@ rgmii_phy1: ethernet-phy@1 {
>  		interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&gmac1_int>, <&gmac1_rst>;
> -		reset-assert-us = <20000>;
> -		reset-deassert-us = <100000>;
> +		reset-assert-us = <10000>;
> +		reset-deassert-us = <30000>;
>  		reset-gpios = <&gpio3 RK_PA3 GPIO_ACTIVE_LOW>;
>  		realtek,aldps-enable;
>  	};

[Severity: High]
Is 30000 us for reset-deassert-us on rgmii_phy0 and rgmii_phy1 below the
minimum post-reset settling time required by newer revisions of the
RTL8211F datasheet?

Revision 1.9 of the RTL8211F datasheet increased the post-reset wait after
PHYRSTB deassertion from 30 ms to at least 72 ms for internal circuit
settling before accessing PHY registers.  Because phy_init_hw() accesses
MDIO registers immediately after waiting reset-deassert-us in
phy_device_reset(phydev, 0), a 30 ms delay can cause PHY initialization or
stmmac_hw_setup() DMA reset failures during probe or ip link down/up
cycles, as seen in 1c7412530d5d ("arm64: dts: meson: g12b: odroid-n2: fix
PHY deassert timing requirements").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rk3576-phys-v1-0-6382cd14e3dc@flipper.net?part=6

  reply	other threads:[~2026-11-20 11:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:48 [PATCH 0/7] arm64: dts: rockchip: Updates to RGMII PHYs on Sige5 and NanoPi M5 Alexey Charkov
2026-11-20 10:48 ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 1/7] arm64: dts: rockchip: Describe NanoPi M5 Ethernet PHYs by their ID Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 2/7] arm64: dts: rockchip: Describe Sige5 " Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:56   ` sashiko-bot
2026-11-20 11:24     ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 3/7] arm64: dts: rockchip: Drop NanoPi M5 PHY reference clocks Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 4/7] arm64: dts: rockchip: Enable ALDPS on NanoPi M5 Ethernet PHYs Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 5/7] arm64: dts: rockchip: Enable ALDPS on Sige5 " Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 6/7] arm64: dts: rockchip: Shorten NanoPi M5 Ethernet PHY reset to datasheet timing Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov
2026-11-20 11:01   ` sashiko-bot [this message]
2026-11-20 11:34     ` Alexey Charkov
2026-11-20 10:48 ` [PATCH 7/7] arm64: dts: rockchip: Shorten Sige5 " Alexey Charkov
2026-11-20 10:48   ` Alexey Charkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224978@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alchark@flipper.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.