* [PATCH v4] dt-bindings: rtc: haoyu,hym8563: document vdd-supply
@ 2026-11-20 11:35 pjh456
2026-11-20 11:44 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: pjh456 @ 2026-11-20 11:35 UTC (permalink / raw)
To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-rtc, devicetree, linux-kernel
The HYM8563 is supplied through its VDD pin. Add an optional
vdd-supply property so a board can describe the regulator connected
to it.
The property is optional because some boards connect VDD to an
always-on rail. Describing the supply also lets fw_devlink order the
RTC probe after its regulator.
Signed-off-by: pjh456 <pengjunhao409@gmail.com>
---
v4: rewrite the commit message, move the AI disclosure below --- and
drop the version links. No code changes.
v3: use the generic "vdd-supply: true" form and show the supply in the
example; reword the rationale around the hardware instead of the
fw_devlink ordering; replace the non-standard "Assisted-by:"
trailers with a disclosure paragraph in the commit message.
v2: rename vcc-supply to vdd-supply, matching the datasheet pin name.
The patch was tested on the Purple Pi OH: cold boot, same kernel Image,
only the DTB changed. With vdd-supply, 3/3 boots registered hym8563
as rtc0 at ~0.6 s. Without it, 2/2 boots failed with -110 at ~1.37 s
because the RTC probed before the i2c3 pull-up rail (vccio_acodec)
reached 3.3 V at ~1.60 s.
AI assistance: I used the HYM8563 datasheet and the board schematic as
inputs, and drafted this change with help from Qwen3.8 Flash Next and
DeepSeek V4.1 Flash through the OpenCode coding agent; Gemini 4
Hydrogen was used to cross-check the schematic in Google AI Studio.
I reviewed the result, ran dt_binding_check, and tested it on the board.
Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
index 0b9f39ef0edc..ce9712e2c406 100644
--- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
+++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
@@ -29,6 +29,8 @@ properties:
wakeup-source:
description: Enables wake up of host system on alarm.
+ vdd-supply: true
+
allOf:
- $ref: rtc.yaml
@@ -52,5 +54,6 @@ examples:
reg = <0x51>;
interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
#clock-cells = <0>;
+ vdd-supply = <&rtc_vdd>;
};
};
base-commit: 7e1392a42ea288d70a266f6553fe06f57f8647ea
--
2.56.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] dt-bindings: rtc: haoyu,hym8563: document vdd-supply
2026-11-20 11:35 [PATCH v4] dt-bindings: rtc: haoyu,hym8563: document vdd-supply pjh456
@ 2026-11-20 11:44 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-20 11:44 UTC (permalink / raw)
To: pjh456; +Cc: linux-rtc, Alexandre Belloni
> The HYM8563 is supplied through its VDD pin. Add an optional
> vdd-supply property so a board can describe the regulator connected
> to it.
>
> The property is optional because some boards connect VDD to an
> always-on rail. Describing the supply also lets fw_devlink order the
> RTC probe after its regulator.
>
> Signed-off-by: pjh456 <pengjunhao409@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120113502.563894-1-pengjunhao409@gmail.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 11:35 [PATCH v4] dt-bindings: rtc: haoyu,hym8563: document vdd-supply pjh456
2026-11-20 11:44 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.