All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maxime Ripard" <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 19/42] drm/atomic_sro: Provide helpers to implement hardware state readout
Date: Fri, 20 Nov 2026 13:17:22 +0000	[thread overview]
Message-ID: <sashiko-outbox-225214@kernel.org> (raw)
In-Reply-To: <20261120-drm-state-readout-v9-19-a67c2b45b8ec@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/atomic_sro: out-of-bounds write in
  drm_atomic_sro_set_connector_state()
--

commit b5d5ae4218e75eb40be891ff0550153b170b927a
Author: Maxime Ripard <mripard@kernel.org>

drm/atomic_sro: Provide helpers to implement hardware state readout

This commit adds helpers to read out hardware state across KMS objects,
build a drm_atomic_sro_state container, and install the read-out states.

> diff --git a/drivers/gpu/drm/drm_atomic_state_readout_helper.c b/drivers/gpu/drm/drm_atomic_state_readout_helper.c
> new file mode 100644
> index 0000000000000..f290d2fe5496e
> --- /dev/null
> +++ b/drivers/gpu/drm/drm_atomic_state_readout_helper.c

[ ... ]

> +static int
> +drm_atomic_helper_sro_readout_connector_state(struct drm_device *dev,
> +					      struct drm_atomic_sro_state *state,
> +					      struct drm_connector *connector)
> +{
> +	const struct drm_connector_funcs *conn_funcs = connector->funcs;
> +	struct drm_connector_state *conn_state;
> +	int ret;
> +
> +	if (!conn_funcs->atomic_sro_readout_state) {
> +		/*
> +		 * Missing readout implementations are only allowed
> +		 * when drm.atomic_readout skips them, but the object
> +		 * still needs a valid state: fall back to a pristine
> +		 * state, like drm_mode_config_create_state() would.
> +		 */
> +		drm_warn(dev, "No connector readout implementation.");
> +
> +		conn_state = conn_funcs->atomic_create_state(connector);
> +		if (drm_WARN_ON(dev, IS_ERR(conn_state)))
> +			return PTR_ERR(conn_state);
> +
> +		drm_atomic_sro_set_connector_state(state, connector, conn_state);
> +		return 0;
> +	}
> +
> +	drm_dbg_kms(dev, "Initializing connector %s state.\n",
> +		    connector->name);
> +
> +	conn_state = conn_funcs->atomic_create_state(connector);
> +	if (drm_WARN_ON(dev, IS_ERR(conn_state)))
> +		return PTR_ERR(conn_state);
> +
> +	ret = conn_funcs->atomic_sro_readout_state(connector, state,
> +						   conn_state);
> +	if (ret) {
> +		drm_dbg_kms(dev, "Connector %s readout failed: %pe\n",
> +			    connector->name, ERR_PTR(ret));
> +		conn_funcs->atomic_destroy_state(connector, conn_state);
> +		return ret;
> +	}
> +
> +	drm_atomic_sro_set_connector_state(state, connector, conn_state);
> +
> +	return 0;
> +}

[ ... ]

> +int
> +drm_atomic_helper_sro_readout_connectors_state(struct drm_device *dev,
> +					       struct drm_atomic_sro_state *state,
> +					       struct drm_atomic_commit *commit)
> +{
> +	struct drm_connector_list_iter conn_iter;
> +	struct drm_connector *connector;
> +	int ret;
> +
> +	might_alloc(GFP_KERNEL);
> +
> +	if (commit)
> +		return drm_atomic_helper_sro_readout_commit_connectors_state(dev, state, commit);
> +
> +	drm_connector_list_iter_begin(dev, &conn_iter);
> +	drm_for_each_connector_iter(connector, &conn_iter) {
> +		ret = drm_atomic_helper_sro_readout_connector_state(dev, state, connector);

[Severity: Medium]
Can this write out of bounds of state->connectors[] if a dynamic connector
is registered after drm_atomic_sro_state_alloc()?

drm_atomic_sro_state_alloc() sizes state->connectors to
state->max_connector_index + 1, and the kerneldoc for max_connector_index
notes that connectors registered afterwards have no entry in
state->connectors.  However, drm_connector_dynamic_register() adds new
connectors under config->connector_list_lock without taking modeset locks.
If a DP MST hotplug worker registers a connector between
drm_atomic_sro_state_alloc() and
drm_atomic_helper_sro_readout_connectors_state(), the connector list
iterator visits it with drm_connector_index(connector) >
state->max_connector_index, and drm_atomic_sro_set_connector_state()
writes past the end of state->connectors[]:

drivers/gpu/drm/drm_atomic_state_readout.c:drm_atomic_sro_set_connector_state() {
	unsigned int index = drm_connector_index(conn);

	drm_connector_get(conn);
	state->connectors[index].ptr = conn;
	state->connectors[index].state = conn_state;
    ...
}

Because drm_atomic_helper_sro_install_state() and
drm_atomic_sro_state_free() only iterate up to state->max_connector_index,
this also leaks the connector reference and conn_state.  Should
drm_atomic_helper_sro_readout_connector_state() skip connectors with
drm_connector_index(connector) > state->max_connector_index?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-drm-state-readout-v9-0-a67c2b45b8ec@kernel.org?part=19

  reply	other threads:[~2026-11-20 13:17 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:54 [PATCH v9 00/42] drm: Implement state readout support Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 01/42] drm/atomic: Add drm_atomic_get_connector_for_encoder_locked() Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 02/42] drm/bridge-helper: Don't unlock the connection mutex after a backoff Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 03/42] drm/tests: hdmi-state-helper: Handle EDEADLK in the 420-only test Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 04/42] drm/tests: hdmi-state-helper: Handle EDEADLK in the color format test Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 05/42] drm/colorop: Export drm_atomic_helper_colorop_create_state() Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 06/42] drm/atomic: Fix private obj error handling Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 07/42] drm/atomic: Add drm_private_obj name Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 08/42] drm/bridge: Switch print_state to use bridge name Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 09/42] drm/bridge: Add drm_private_obj_is_bridge() Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 10/42] drm/fb-dma-helper: Handle framebuffers without a GEM object Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 11/42] drm/gem-atomic-helper: " Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 12/42] drm/atomic: Export drm_atomic_*_print_state Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 13/42] drm/atomic_sro: Create drm_atomic_sro_state container Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 14/42] drm/atomic_sro: Create kernel parameter to force or disable readout Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 15/42] drm/atomic_sro: Add atomic state readout infrastructure Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 16/42] drm/atomic_sro: Create documentation Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 17/42] drm/bridge: Handle bridges with hardware state readout Maxime Ripard
2026-11-20 13:18   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 18/42] drm/mode-config: Read out hardware state in drm_mode_config_create_initial_state Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 19/42] drm/atomic_sro: Provide helpers to implement hardware state readout Maxime Ripard
2026-11-20 13:17   ` sashiko-bot [this message]
2026-11-20 12:55 ` [PATCH v9 20/42] drm/mode-config: Introduce hw_reset hook Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 21/42] drm/modeset-helper: Add drm_mode_config_helper_hw_reset() Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 22/42] drm/atomic_helper: Compare actual and readout states once the commit is done Maxime Ripard
2026-11-20 13:17   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 23/42] drm/atomic-state-helper: Provide comparison macros Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 24/42] drm/atomic-state-helper: Provide atomic_compare_state helpers Maxime Ripard
2026-11-20 13:14   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 25/42] drm/atomic-helper: Document State Read-Out as a state initialization approach Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 26/42] drm/tests: kunit: Add a drm_printer helper Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 27/42] drm/tests: Add tests for the atomic state readout Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 28/42] drm/encoder: Create atomic_sro_get_current_crtc hook Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 29/42] drm/bridge: display-connector: Implement readout support Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 30/42] drm/bridge_connector: Implement hw readout for connector Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 31/42] drm/tidss: Implement hw_reset Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 32/42] drm/tidss: crtc: Implement hardware state readout Maxime Ripard
2026-11-20 13:14   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 33/42] drm/tidss: encoder: " Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 34/42] drm/tidss: kms: Hook up " Maxime Ripard
2026-11-20 13:25   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 35/42] drm/tidss: plane: Implement " Maxime Ripard
2026-11-20 13:28   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 36/42] drm/tidss: dispc: Add hardware state readout helpers Maxime Ripard
2026-11-20 13:17   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 37/42] drm/tidss: encoder: Implement atomic_sro_get_current_crtc Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 38/42] drm/bridge: sii902x: Implement hw state readout Maxime Ripard
2026-11-20 13:26   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 39/42] drm/panel: Implement state readout support Maxime Ripard
2026-11-20 12:55 ` [PATCH DO NOT MERGE v9 40/42] fixup! drm/tidss: dispc: Add hardware state readout helpers Maxime Ripard
2026-11-20 12:55 ` [PATCH DO NOT MERGE v9 41/42] drm/tidss: oldi: Implement hardware state readout Maxime Ripard
2026-11-20 13:34   ` sashiko-bot
2026-11-20 12:55 ` [PATCH HACK v9 42/42] drm/panel: Prepare and enable panels read out as active Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225214@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.