All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maxime Ripard" <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 22/42] drm/atomic_helper: Compare actual and readout states once the commit is done
Date: Fri, 20 Nov 2026 13:17:46 +0000	[thread overview]
Message-ID: <sashiko-outbox-225216@kernel.org> (raw)
In-Reply-To: <20261120-drm-state-readout-v9-22-a67c2b45b8ec@kernel.org>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] drm/bridge: drm_bridge_attach() disables readout if compare
  hook is unset
- [Low] drm/atomic_sro: duplicated line in DOC: overview comment
--

commit 00233166cd25376785bc177974713d5ccca22687
Author: Maxime Ripard <mripard@kernel.org>

drm/atomic_helper: Compare actual and readout states once the commit is done

This commit introduces atomic_sro_compare_state callbacks for KMS objects
and adds drm_atomic_sro_readout_and_compare() to read back and compare
hardware state against the committed state after blocking atomic commits.

> diff --git a/drivers/gpu/drm/drm_atomic_state_readout.c b/drivers/gpu/drm/drm_atomic_state_readout.c
> index 3e50b0796cbec..4b6512ef1aae7 100644
> --- a/drivers/gpu/drm/drm_atomic_state_readout.c
> +++ b/drivers/gpu/drm/drm_atomic_state_readout.c
> @@ -26,7 +26,7 @@
>   * firmware already configured the display, the first userspace
>   * modeset can be skipped when the requested mode matches.
>   *
> - * The SRO lifecycle has two phases. The first phase is the readout
> + * The SRO lifecycle has three phases. The first phase is the readout
>   * itself: at driver registration time, each KMS object (CRTCs, planes,
>   * connectors, bridges, private objects) has its
>   * atomic_sro_readout_state hook called to populate a
> @@ -46,7 +46,17 @@
>   * state active, such as power domains, clocks, or interrupts. This hook
>   * cannot fail.
>   *
> - * Drivers integrate with SRO by implementing the readout hooks in their
> + * The third phase is the comparison. Because getting access to every
> + * firmware variation is hard, and most firmware setups will be fairly
> + * basic, the framework also provides a way to verify the readout
> + * implementation during normal operation. After every blocking commit,
> + * the framework reads out a fresh state from hardware and compares it
> + * to the committed state using the atomic_sro_compare_state hooks. Any
> + * mismatch is reported, which allows to catch readout bugs without
> + * needing specific firmware configurations.
> + *
> + * Drivers integrate with SRO by implementing the readout and compare
> + * hooks in their object funcs vtables and setting the
>   * object funcs vtables and setting the
>   * &drm_mode_config_funcs.atomic_sro_readout_state,
>   * &drm_mode_config_helper_funcs.atomic_sro_install_state, and

[Severity: Low]
This isn't a bug, but "object funcs vtables and setting the" is duplicated
in the overview comment.

[ ... ]

> diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
> index 868558a09f951..fe9b535d02bd5 100644
> --- a/drivers/gpu/drm/drm_bridge.c
> +++ b/drivers/gpu/drm/drm_bridge.c
> @@ -798,7 +798,8 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,
>  	}
>  
>  	if (bridge->funcs &&
> -	    bridge->funcs->atomic_sro_readout_state)
> +	    bridge->funcs->atomic_sro_readout_state &&
> +	    bridge->funcs->atomic_sro_compare_state)
>  		ret = drm_atomic_private_obj_init(bridge->dev, &bridge->base,
>  						  bridge->name,
>  						  &drm_bridge_priv_state_funcs_with_sro);

[Severity: Medium]
Does requiring bridge->funcs->atomic_sro_compare_state here break bridge
state readout when atomic_readout is set to
DRM_ATOMIC_READOUT_SKIP_MISSING_COMPARE or
DRM_ATOMIC_READOUT_SKIP_MISSING_READOUT?

If a bridge implements atomic_sro_readout_state without
atomic_sro_compare_state, drm_bridge_attach() falls back to
drm_bridge_priv_state_funcs, which leaves
privobj->funcs->atomic_sro_readout_state and
privobj->funcs->atomic_sro_install_state NULL.
drm_atomic_sro_can_readout() then rejects the device under
DRM_ATOMIC_READOUT_SKIP_MISSING_COMPARE, and
drm_atomic_helper_sro_readout_bridge_state() skips the bridge's readout
hook under DRM_ATOMIC_READOUT_SKIP_MISSING_READOUT.

Also, at this point in the series, drm_bridge_priv_state_funcs_with_sro
does not yet set .atomic_sro_compare_state (wired in the later commit
"drm/atomic-state-helper: Provide atomic_compare_state helpers"), so
drm_atomic_sro_can_compare() returns false under
DRM_ATOMIC_READOUT_ENABLED for any device with an attached bridge until
that commit.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-drm-state-readout-v9-0-a67c2b45b8ec@kernel.org?part=22

  reply	other threads:[~2026-11-20 13:18 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:54 [PATCH v9 00/42] drm: Implement state readout support Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 01/42] drm/atomic: Add drm_atomic_get_connector_for_encoder_locked() Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 02/42] drm/bridge-helper: Don't unlock the connection mutex after a backoff Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 03/42] drm/tests: hdmi-state-helper: Handle EDEADLK in the 420-only test Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 04/42] drm/tests: hdmi-state-helper: Handle EDEADLK in the color format test Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 05/42] drm/colorop: Export drm_atomic_helper_colorop_create_state() Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 06/42] drm/atomic: Fix private obj error handling Maxime Ripard
2026-11-20 12:54 ` [PATCH v9 07/42] drm/atomic: Add drm_private_obj name Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 08/42] drm/bridge: Switch print_state to use bridge name Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 09/42] drm/bridge: Add drm_private_obj_is_bridge() Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 10/42] drm/fb-dma-helper: Handle framebuffers without a GEM object Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 11/42] drm/gem-atomic-helper: " Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 12/42] drm/atomic: Export drm_atomic_*_print_state Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 13/42] drm/atomic_sro: Create drm_atomic_sro_state container Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 14/42] drm/atomic_sro: Create kernel parameter to force or disable readout Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 15/42] drm/atomic_sro: Add atomic state readout infrastructure Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 16/42] drm/atomic_sro: Create documentation Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 17/42] drm/bridge: Handle bridges with hardware state readout Maxime Ripard
2026-11-20 13:18   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 18/42] drm/mode-config: Read out hardware state in drm_mode_config_create_initial_state Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 19/42] drm/atomic_sro: Provide helpers to implement hardware state readout Maxime Ripard
2026-11-20 13:17   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 20/42] drm/mode-config: Introduce hw_reset hook Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 21/42] drm/modeset-helper: Add drm_mode_config_helper_hw_reset() Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 22/42] drm/atomic_helper: Compare actual and readout states once the commit is done Maxime Ripard
2026-11-20 13:17   ` sashiko-bot [this message]
2026-11-20 12:55 ` [PATCH v9 23/42] drm/atomic-state-helper: Provide comparison macros Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 24/42] drm/atomic-state-helper: Provide atomic_compare_state helpers Maxime Ripard
2026-11-20 13:14   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 25/42] drm/atomic-helper: Document State Read-Out as a state initialization approach Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 26/42] drm/tests: kunit: Add a drm_printer helper Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 27/42] drm/tests: Add tests for the atomic state readout Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 28/42] drm/encoder: Create atomic_sro_get_current_crtc hook Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 29/42] drm/bridge: display-connector: Implement readout support Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 30/42] drm/bridge_connector: Implement hw readout for connector Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 31/42] drm/tidss: Implement hw_reset Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 32/42] drm/tidss: crtc: Implement hardware state readout Maxime Ripard
2026-11-20 13:14   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 33/42] drm/tidss: encoder: " Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 34/42] drm/tidss: kms: Hook up " Maxime Ripard
2026-11-20 13:25   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 35/42] drm/tidss: plane: Implement " Maxime Ripard
2026-11-20 13:28   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 36/42] drm/tidss: dispc: Add hardware state readout helpers Maxime Ripard
2026-11-20 13:17   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 37/42] drm/tidss: encoder: Implement atomic_sro_get_current_crtc Maxime Ripard
2026-11-20 12:55 ` [PATCH v9 38/42] drm/bridge: sii902x: Implement hw state readout Maxime Ripard
2026-11-20 13:26   ` sashiko-bot
2026-11-20 12:55 ` [PATCH v9 39/42] drm/panel: Implement state readout support Maxime Ripard
2026-11-20 12:55 ` [PATCH DO NOT MERGE v9 40/42] fixup! drm/tidss: dispc: Add hardware state readout helpers Maxime Ripard
2026-11-20 12:55 ` [PATCH DO NOT MERGE v9 41/42] drm/tidss: oldi: Implement hardware state readout Maxime Ripard
2026-11-20 13:34   ` sashiko-bot
2026-11-20 12:55 ` [PATCH HACK v9 42/42] drm/panel: Prepare and enable panels read out as active Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225216@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.