All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 01/29] drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp()
Date: Fri, 20 Nov 2026 14:32:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-225381@kernel.org> (raw)
In-Reply-To: <20261120140729.466177-2-ankit.k.nautiyal@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/i915/hdmi: misleading loop comment left in
  get_dsc_min_max_bpp()
--

commit 4124d2f34b7c42a6bd777db7dfc5a6ab748c239c
Author: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp()

This commit splits intel_hdmi_dsc_get_bpp() into get_dsc_min_max_bpp() and
get_dsc_compressed_bpp() and updates the comments inside the helpers.

> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index b6fa1a1558b82..205c55522bca7 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -3325,61 +3325,49 @@ intel_hdmi_dsc_get_num_slices(const struct drm_display_mode *mode,
>  	return target_slices;
>  }
>  
> -/*
> - * intel_hdmi_dsc_get_bpp - get the appropriate compressed bits_per_pixel based on
> - * source and sink capabilities.
> - *
> - * @src_fraction_bpp: fractional bpp supported by the source
> - * @slice_width: dsc slice width supported by the source and sink
> - * @num_slices: num of slices supported by the source and sink
> - * @output_format: video output format
> - * @bpc: bits per color
> - * @hdmi_all_bpp: sink supports decoding of 1/16th bpp setting
> - * @hdmi_max_chunk_bytes: max bytes in a line of chunks supported by sink
> - *
> - * @return: compressed bits_per_pixel in step of 1/16 of bits_per_pixel
> - */
> -int
> -intel_hdmi_dsc_get_bpp(int src_fractional_bpp, int slice_width, int num_slices,
> -		       enum intel_output_format output_format, int bpc,
> -		       bool hdmi_all_bpp, int hdmi_max_chunk_bytes)
> +static void
> +get_dsc_min_max_bpp(enum intel_output_format output_format, u8 bpc,
> +		    bool hdmi_all_bpp, int *min_dsc_bpp, int *max_dsc_bpp)
>  {
> -	int max_dsc_bpp, min_dsc_bpp;
> -	int target_bytes;
> -	bool bpp_found = false;
> -	int bpp_decrement_x16;
> -	int bpp_target;
> -	int bpp_target_x16;
> -
>  	/*
> -	 * Get min bpp and max bpp as per Table 7.23, in HDMI2.1 spec
> +	 * Get min bpp and max bpp that can be supported for a
> +	 * given bpc and output format.
>  	 * Start with the max bpp and keep on decrementing with
> -	 * fractional bpp, if supported by PCON DSC encoder
> +	 * fractional bpp, if supported by the DSC encoder
>  	 *
>  	 * for each bpp we check if no of bytes can be supported by HDMI sink
>  	 */

[Severity: Low]
This isn't a bug, but the second part of this comment describes the
fractional bpp decrement and sink chunk-byte check loop that was moved into
get_dsc_compressed_bpp() below, while get_dsc_min_max_bpp() only computes
the min and max bpp bounds.  The edits to the comments in
get_dsc_min_max_bpp() also drop the HDMI 2.1 Table 7.23 and Section 7.7.34
references that documented where these limits come from.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120140729.466177-1-ankit.k.nautiyal@intel.com?part=1

  reply	other threads:[~2026-11-20 14:32 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 14:07 [PATCH 00/29] DP-HDMI PCON DSC fixes Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 01/29] drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp() Ankit Nautiyal
2026-11-20 14:32   ` sashiko-bot [this message]
2026-11-20 14:07 ` [PATCH 02/29] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP Ankit Nautiyal
2026-11-20 14:34   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 03/29] drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 04/29] drm/i915/dp: Use the common downstream bw check in compute_bpc Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 05/29] drm/i915/hdmi: Expose DSC min/max bpp helpers Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 06/29] drm/i915/hdmi: Add helper to check if DSC chunksize fits the sink limits Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 07/29] drm/i915/hdmi: Pass pixel clock to DSC slice helper Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 08/29] drm/i915/dp: Account for FRL 16b/18b encoding overhead Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 09/29] drm/i915/hdmi: Clamp the target_bpp only when it equals the link bpp Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 10/29] drm/i915/dp: Add PCON DSC state to crtc_state Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 11/29] drm/dp: Add a helper to disable the PCON DSC encoder Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 12/29] drm/i915/dp: Compute the PCON DSC operation Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 13/29] drm/i915/dp: Disable the PCON DSC encoder unless it is needed Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 14/29] drm/i915/dp: Clamp PCON DSC bpp to the FRL link bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 15/29] drm/i915/dp: Add a helper for the DSC stream version Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 16/29] drm/i915/dp: Add a helper for the FRL payload bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 17/29] drm/i915/dp: Compute the PCON DSC encoder parameters Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 18/29] drm/i915/dp: Retrain the PCON FRL link from the link check work Ankit Nautiyal
2026-11-20 14:46   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 19/29] drm/i915/dp: Store the PCON FRL rate in the crtc state Ankit Nautiyal
2026-11-20 14:39   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 20/29] drm/i915/dp: Use the FRL rate of the stream on the HDMI link Ankit Nautiyal
2026-11-20 14:43   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 21/29] drm/i915/dp: Allow PCON DSC modes through the FRL bw check Ankit Nautiyal
2026-11-20 14:48   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 22/29] drm/i915/dp: Enable DSC pass-through in the PCON Ankit Nautiyal
2026-11-20 14:38   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 23/29] drm/i915/dp: Limit the DP link bpp for DSC pass-through to the FRL bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 24/29] drm/i915/dp: Select DSC pass-through in the PCON for DSC 1.2a streams Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 25/29] drm/i915/dp: Allow limiting the DSC slice count for the downstream device Ankit Nautiyal
2026-11-20 14:41   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 26/29] drm/i915/dp: Check the HDMI sink slice limits for DSC pass-through Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 27/29] drm/i915/dp: Pick the DSC slice count for pass-through within the HDMI limits Ankit Nautiyal
2026-11-20 14:48   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 28/29] drm/i915/dp: Limit the compressed bpp for pass-through to the HDMI sink Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 29/29] drm/i915/dp: Accept DSC 1.2a pass-through modes in the PCON mode check Ankit Nautiyal
2026-11-20 14:33 ` ✗ CI.checkpatch: warning for DP-HDMI PCON DSC fixes (rev4) Patchwork
2026-11-20 14:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 15:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-20 17:31 ` ✓ i915.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225381@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.