All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ankit Nautiyal" <ankit.k.nautiyal@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 22/29] drm/i915/dp: Enable DSC pass-through in the PCON
Date: Fri, 20 Nov 2026 14:38:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-225396@kernel.org> (raw)
In-Reply-To: <20261120140729.466177-23-ankit.k.nautiyal@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/i915/dp: stale DP_DSC_ENABLE bits in
  intel_dp_sink_disable_decompression()
--

commit 2433da6ae530a721973aa8e15cc125c351ed4832
Author: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

drm/i915/dp: Enable DSC pass-through in the PCON

This commit adds helpers to enable and disable DSC pass-through in a PCON
instead of enabling sink decompression when pcon_config.dsc_op is set to
INTEL_PCON_DSC_PASSTHROUGH.

> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7b66cd82b065e..5bfbcf91d7add 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3998,6 +3998,18 @@ intel_dp_sink_set_dsc_passthrough(const struct intel_connector *connector,
>  			    str_enable_disable(enable));
>  }
>  
> +static void
> +intel_dp_pcon_set_dsc_passthrough(struct intel_connector *connector, bool enable)
> +{
> +	struct intel_display *display = to_intel_display(connector);
> +
> +	if (write_dsc_decompression_flag(connector->dp.dsc_decompression_aux,
> +					 DP_DSC_PASSTHROUGH_EN, enable) < 0)
> +		drm_dbg_kms(display->drm,
> +			    "Failed to %s PCON DSC pass-through\n",
> +			    str_enable_disable(enable));
> +}
> +
>  static int intel_dp_dsc_aux_ref_count(struct intel_atomic_state *state,
>  				      const struct intel_connector *connector,
>  				      bool for_get_ref)
> @@ -4068,7 +4080,8 @@ static bool intel_dp_dsc_aux_put_ref(struct intel_atomic_state *state,
>   * sink device, whereas on MST based on each device's DSC capabilities it's
>   * either the last branch device (enabling decompression in it) or both the
>   * last branch device (enabling passthrough in it) and the sink device
> - * (enabling decompression in it).
> + * (enabling decompression in it). A PCON passing a DSC stream through to
> + * the HDMI sink gets passthrough enabled instead of decompression.
>   */
>  void intel_dp_sink_enable_decompression(struct intel_atomic_state *state,
>  					struct intel_connector *connector,
> @@ -4087,6 +4100,12 @@ void intel_dp_sink_enable_decompression(struct intel_atomic_state *state,
>  	if (!intel_dp_dsc_aux_get_ref(state, connector))
>  		return;
>  
> +	/* A PCON passing the DSC stream through to the HDMI sink doesn't decode it */
> +	if (new_crtc_state->pcon_config.dsc_op == INTEL_PCON_DSC_PASSTHROUGH) {
> +		intel_dp_pcon_set_dsc_passthrough(connector, true);
> +		return;
> +	}
> +
>  	intel_dp_sink_set_dsc_passthrough(connector, true);
>  	intel_dp_sink_set_dsc_decompression(connector, true);
>  }
> @@ -4118,6 +4137,11 @@ void intel_dp_sink_disable_decompression(struct intel_atomic_state *state,
>  	if (!intel_dp_dsc_aux_put_ref(state, connector))
>  		return;
>  
> +	if (old_crtc_state->pcon_config.dsc_op == INTEL_PCON_DSC_PASSTHROUGH) {
> +		intel_dp_pcon_set_dsc_passthrough(connector, false);
> +		return;
> +	}

[Severity: Medium]
Can this leave DP_DSC_PASSTHROUGH_EN and DP_DECOMPRESSION_EN stale or both
set in the PCON's DP_DSC_ENABLE register?

pcon_config.dsc_op is not read out from the hardware during initial probe
or resume:

drivers/gpu/drm/i915/display/intel_display_types.h:intel_crtc_state {
    ...
	/*
	 * Configuration of a DP->HDMI PCON. Only used for state computation,
	 * not read out from the HW.
	 */
	struct {
		enum intel_pcon_dsc_op dsc_op;
    ...
}

When taking over a DSC mode where the PCON had DP_DSC_PASSTHROUGH_EN set,
old_crtc_state->pcon_config.dsc_op is INTEL_PCON_NO_DSC during the disable
phase of the initial modeset.  intel_dp_sink_disable_decompression() then
calls intel_dp_sink_set_dsc_decompression(connector, false), which only
clears DP_DECOMPRESSION_EN via write_dsc_decompression_flag(), while
intel_dp_sink_set_dsc_passthrough(connector, false) is a no-op on SST
because connector->mst.port is NULL.

As a result, DP_DSC_PASSTHROUGH_EN stays set in the PCON for a following
uncompressed mode, or gets combined with DP_DECOMPRESSION_EN (0x03) if the
next mode enables PCON DSC decoding.  Likewise, because
intel_dp_pcon_set_dsc_passthrough(connector, true) only sets
DP_DSC_PASSTHROUGH_EN via write_dsc_decompression_flag(), any pre-existing
DP_DECOMPRESSION_EN bit in DP_DSC_ENABLE is not cleared when enabling
pass-through.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120140729.466177-1-ankit.k.nautiyal@intel.com?part=22

  reply	other threads:[~2026-11-20 14:38 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 14:07 [PATCH 00/29] DP-HDMI PCON DSC fixes Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 01/29] drm/i915/hdmi: Split the intel_hdmi_dsc_get_bpp() Ankit Nautiyal
2026-11-20 14:32   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 02/29] drm/i915/dp: Fix FRL BW check for HDMI2.1 DFP Ankit Nautiyal
2026-11-20 14:34   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 03/29] drm/i915/dp: Add a wrapper to check frl/tmds downstream constraints Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 04/29] drm/i915/dp: Use the common downstream bw check in compute_bpc Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 05/29] drm/i915/hdmi: Expose DSC min/max bpp helpers Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 06/29] drm/i915/hdmi: Add helper to check if DSC chunksize fits the sink limits Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 07/29] drm/i915/hdmi: Pass pixel clock to DSC slice helper Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 08/29] drm/i915/dp: Account for FRL 16b/18b encoding overhead Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 09/29] drm/i915/hdmi: Clamp the target_bpp only when it equals the link bpp Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 10/29] drm/i915/dp: Add PCON DSC state to crtc_state Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 11/29] drm/dp: Add a helper to disable the PCON DSC encoder Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 12/29] drm/i915/dp: Compute the PCON DSC operation Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 13/29] drm/i915/dp: Disable the PCON DSC encoder unless it is needed Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 14/29] drm/i915/dp: Clamp PCON DSC bpp to the FRL link bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 15/29] drm/i915/dp: Add a helper for the DSC stream version Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 16/29] drm/i915/dp: Add a helper for the FRL payload bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 17/29] drm/i915/dp: Compute the PCON DSC encoder parameters Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 18/29] drm/i915/dp: Retrain the PCON FRL link from the link check work Ankit Nautiyal
2026-11-20 14:46   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 19/29] drm/i915/dp: Store the PCON FRL rate in the crtc state Ankit Nautiyal
2026-11-20 14:39   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 20/29] drm/i915/dp: Use the FRL rate of the stream on the HDMI link Ankit Nautiyal
2026-11-20 14:43   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 21/29] drm/i915/dp: Allow PCON DSC modes through the FRL bw check Ankit Nautiyal
2026-11-20 14:48   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 22/29] drm/i915/dp: Enable DSC pass-through in the PCON Ankit Nautiyal
2026-11-20 14:38   ` sashiko-bot [this message]
2026-11-20 14:07 ` [PATCH 23/29] drm/i915/dp: Limit the DP link bpp for DSC pass-through to the FRL bandwidth Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 24/29] drm/i915/dp: Select DSC pass-through in the PCON for DSC 1.2a streams Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 25/29] drm/i915/dp: Allow limiting the DSC slice count for the downstream device Ankit Nautiyal
2026-11-20 14:41   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 26/29] drm/i915/dp: Check the HDMI sink slice limits for DSC pass-through Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 27/29] drm/i915/dp: Pick the DSC slice count for pass-through within the HDMI limits Ankit Nautiyal
2026-11-20 14:48   ` sashiko-bot
2026-11-20 14:07 ` [PATCH 28/29] drm/i915/dp: Limit the compressed bpp for pass-through to the HDMI sink Ankit Nautiyal
2026-11-20 14:07 ` [PATCH 29/29] drm/i915/dp: Accept DSC 1.2a pass-through modes in the PCON mode check Ankit Nautiyal
2026-11-20 14:33 ` ✗ CI.checkpatch: warning for DP-HDMI PCON DSC fixes (rev4) Patchwork
2026-11-20 14:35 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 15:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-20 17:31 ` ✓ i915.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225396@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.