* [PATCH] rust: put C helper exports in a dedicated namespace
@ 2026-11-20 16:32 ` Peder Bergan via B4 Relay
0 siblings, 0 replies; 3+ messages in thread
From: Peder Bergan @ 2026-11-20 16:32 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
Daniel Almeida, Tamir Duberstein, Alexandre Courbot,
Onur Özkan, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, rust-for-linux, linux-kernel,
linux-modules, Wedson Almeida Filho
The rust_helper_ prefix marks these C wrappers as Rust implementation
details. Their exports use the default namespace, so GPL-compatible
modules can link against them without an explicit import.
Export the wrappers in RUST_HELPERS so modpost can detect accidental
dependencies at build time by flagging a missing namespace import.
Have module! supply the import when the helpers are exported, since
inlining and generic instantiation can introduce calls through ordinary
Rust abstractions.
External modules that call these helpers without module! need to
declare the import explicitly.
Suggested-by: Wedson Almeida Filho <wedsonaf@gmail.com>
Link: https://github.com/Rust-for-Linux/linux/issues/216
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
The two Rust sample modules loaded and unloaded under x86-64 QEMU
with namespace enforcement enabled. Removing the import made modpost
reject the sample. The exports and imports were also checked with helper
inlining enabled and disabled.
OpenAI Codex assisted with coding and testing.
---
rust/Makefile | 4 +++-
rust/exports.c | 2 ++
rust/macros/module.rs | 5 +++++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/rust/Makefile b/rust/Makefile
index 0165626decbe7..17c559052e936 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -569,9 +569,10 @@ $(obj)/helpers/helpers.bc $(obj)/helpers/helpers_module.bc: $(src)/helpers/helpe
rust_exports = $(NM) -p --defined-only $(1) | awk '$$2~/(T|R|D|B)/ && $$3!~/__(pfx|cfi|odr_asan)/ { printf $(2),$$3 }'
+rust_export_macro = EXPORT_SYMBOL_RUST_GPL
quiet_cmd_exports = EXPORTS $@
cmd_exports = \
- $(call rust_exports,$<,"EXPORT_SYMBOL_RUST_GPL(%s);\n") > $@
+ $(call rust_exports,$<,"$(rust_export_macro)(%s);\n") > $@
$(obj)/exports_core_generated.h: $(obj)/core.o FORCE
$(call if_changed,exports)
@@ -585,6 +586,7 @@ $(obj)/exports_core_generated.h: $(obj)/core.o FORCE
# function either. Therefore, we export all symbols from helpers and bindings.
# In the future, this may be revisited to reduce the number of exports after
# the compiler is informed about the places codegen is required.
+$(obj)/exports_helpers_generated.h: private rust_export_macro = EXPORT_SYMBOL_RUST_HELPER_GPL
$(obj)/exports_helpers_generated.h: $(obj)/helpers/helpers.o FORCE
$(call if_changed,exports)
diff --git a/rust/exports.c b/rust/exports.c
index 1b52460b0f4ee..fde2a52d2a1ae 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -14,6 +14,8 @@
#include <linux/export.h>
#define EXPORT_SYMBOL_RUST_GPL(sym) extern int sym; EXPORT_SYMBOL_GPL(sym)
+#define EXPORT_SYMBOL_RUST_HELPER_GPL(sym) \
+ extern int sym; EXPORT_SYMBOL_NS_GPL(sym, "RUST_HELPERS")
#include "exports_core_generated.h"
#include "exports_bindings_generated.h"
diff --git a/rust/macros/module.rs b/rust/macros/module.rs
index 0a7b9e24c9600..ac3376fa8fb85 100644
--- a/rust/macros/module.rs
+++ b/rust/macros/module.rs
@@ -467,6 +467,11 @@ pub(crate) fn module(info: ModuleInfo) -> Result<TokenStream> {
}
}
+ // Inlined kernel code can introduce calls to C helpers in any Rust module.
+ if !cfg!(CONFIG_RUST_INLINE_HELPERS) {
+ modinfo.emit_only_loadable("import_ns", "RUST_HELPERS", false);
+ }
+
// Built-in modules also export the `file` modinfo string.
let file =
std::env::var("RUST_MODFILE").expect("Unable to fetch RUST_MODFILE environmental variable");
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261120-rust-helper-namespace-57e8c37ee7df
Best regards,
--
Peder Bergan <peder.bergan@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] rust: put C helper exports in a dedicated namespace
@ 2026-11-20 16:32 ` Peder Bergan via B4 Relay
0 siblings, 0 replies; 3+ messages in thread
From: Peder Bergan via B4 Relay @ 2026-11-20 16:32 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
Daniel Almeida, Tamir Duberstein, Alexandre Courbot,
Onur Özkan, Luis Chamberlain, Petr Pavlu, Daniel Gomez,
Sami Tolvanen, Aaron Tomlin, rust-for-linux, linux-kernel,
linux-modules, Wedson Almeida Filho
From: Peder Bergan <peder.bergan@gmail.com>
The rust_helper_ prefix marks these C wrappers as Rust implementation
details. Their exports use the default namespace, so GPL-compatible
modules can link against them without an explicit import.
Export the wrappers in RUST_HELPERS so modpost can detect accidental
dependencies at build time by flagging a missing namespace import.
Have module! supply the import when the helpers are exported, since
inlining and generic instantiation can introduce calls through ordinary
Rust abstractions.
External modules that call these helpers without module! need to
declare the import explicitly.
Suggested-by: Wedson Almeida Filho <wedsonaf@gmail.com>
Link: https://github.com/Rust-for-Linux/linux/issues/216
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
The two Rust sample modules loaded and unloaded under x86-64 QEMU
with namespace enforcement enabled. Removing the import made modpost
reject the sample. The exports and imports were also checked with helper
inlining enabled and disabled.
OpenAI Codex assisted with coding and testing.
---
rust/Makefile | 4 +++-
rust/exports.c | 2 ++
rust/macros/module.rs | 5 +++++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/rust/Makefile b/rust/Makefile
index 0165626decbe7..17c559052e936 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -569,9 +569,10 @@ $(obj)/helpers/helpers.bc $(obj)/helpers/helpers_module.bc: $(src)/helpers/helpe
rust_exports = $(NM) -p --defined-only $(1) | awk '$$2~/(T|R|D|B)/ && $$3!~/__(pfx|cfi|odr_asan)/ { printf $(2),$$3 }'
+rust_export_macro = EXPORT_SYMBOL_RUST_GPL
quiet_cmd_exports = EXPORTS $@
cmd_exports = \
- $(call rust_exports,$<,"EXPORT_SYMBOL_RUST_GPL(%s);\n") > $@
+ $(call rust_exports,$<,"$(rust_export_macro)(%s);\n") > $@
$(obj)/exports_core_generated.h: $(obj)/core.o FORCE
$(call if_changed,exports)
@@ -585,6 +586,7 @@ $(obj)/exports_core_generated.h: $(obj)/core.o FORCE
# function either. Therefore, we export all symbols from helpers and bindings.
# In the future, this may be revisited to reduce the number of exports after
# the compiler is informed about the places codegen is required.
+$(obj)/exports_helpers_generated.h: private rust_export_macro = EXPORT_SYMBOL_RUST_HELPER_GPL
$(obj)/exports_helpers_generated.h: $(obj)/helpers/helpers.o FORCE
$(call if_changed,exports)
diff --git a/rust/exports.c b/rust/exports.c
index 1b52460b0f4ee..fde2a52d2a1ae 100644
--- a/rust/exports.c
+++ b/rust/exports.c
@@ -14,6 +14,8 @@
#include <linux/export.h>
#define EXPORT_SYMBOL_RUST_GPL(sym) extern int sym; EXPORT_SYMBOL_GPL(sym)
+#define EXPORT_SYMBOL_RUST_HELPER_GPL(sym) \
+ extern int sym; EXPORT_SYMBOL_NS_GPL(sym, "RUST_HELPERS")
#include "exports_core_generated.h"
#include "exports_bindings_generated.h"
diff --git a/rust/macros/module.rs b/rust/macros/module.rs
index 0a7b9e24c9600..ac3376fa8fb85 100644
--- a/rust/macros/module.rs
+++ b/rust/macros/module.rs
@@ -467,6 +467,11 @@ pub(crate) fn module(info: ModuleInfo) -> Result<TokenStream> {
}
}
+ // Inlined kernel code can introduce calls to C helpers in any Rust module.
+ if !cfg!(CONFIG_RUST_INLINE_HELPERS) {
+ modinfo.emit_only_loadable("import_ns", "RUST_HELPERS", false);
+ }
+
// Built-in modules also export the `file` modinfo string.
let file =
std::env::var("RUST_MODFILE").expect("Unable to fetch RUST_MODFILE environmental variable");
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261120-rust-helper-namespace-57e8c37ee7df
Best regards,
--
Peder Bergan <peder.bergan@gmail.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rust: put C helper exports in a dedicated namespace
2026-11-20 16:32 ` Peder Bergan via B4 Relay
(?)
@ 2026-11-20 16:46 ` sashiko-bot
-1 siblings, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-20 16:46 UTC (permalink / raw)
To: Peder Bergan; +Cc: linux-modules, Petr Pavlu, ojeda, gary
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] rust: missing RUST_HELPERS namespace import in kasan_test
module
--
commit 42a51ff367154ba548e8d27e3154503fd972371b
Author: Peder Bergan <peder.bergan@gmail.com>
rust: put C helper exports in a dedicated namespace
This commit moves exported Rust C helpers into the RUST_HELPERS symbol
namespace and makes the Rust module! macro import that namespace when
helper inlining is disabled.
Link: https://github.com/Rust-for-Linux/linux/issues/216
> diff --git a/rust/macros/module.rs b/rust/macros/module.rs
> index 0a7b9e24c9600..ac3376fa8fb85 100644
> --- a/rust/macros/module.rs
> +++ b/rust/macros/module.rs
> @@ -467,6 +467,11 @@ pub(crate) fn module(info: ModuleInfo) -> Result<TokenStream> {
> }
> }
>
> + // Inlined kernel code can introduce calls to C helpers in any Rust module.
> + if !cfg!(CONFIG_RUST_INLINE_HELPERS) {
> + modinfo.emit_only_loadable("import_ns", "RUST_HELPERS", false);
> + }
> +
> // Built-in modules also export the `file` modinfo string.
> let file =
> std::env::var("RUST_MODFILE").expect("Unable to fetch RUST_MODFILE environmental variable");
[Severity: Medium]
Does this break the build of kasan_test.ko when CONFIG_KASAN_KUNIT_TEST=m,
CONFIG_RUST=y, and CONFIG_RUST_INLINE_HELPERS=n?
kasan_test is a composite C and Rust module (kasan_test_c.o and
kasan_test_rust.o in mm/kasan/Makefile) that defines its module metadata
in mm/kasan/kasan_test_c.c rather than with module!.
kasan_test_rust_uaf() in mm/kasan/kasan_test_rust.rs uses KVec::push() and
drops the vector, which inline into calls to
rust_helper_krealloc_node_align. Because neither mm/kasan/kasan_test_c.c
nor mm/kasan/kasan_test_rust.rs imports RUST_HELPERS, modpost rejects
kasan_test.ko for using a symbol from RUST_HELPERS without importing the
namespace.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rust-helper-namespace-v1-1-3b9a05553ff6@gmail.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 16:32 [PATCH] rust: put C helper exports in a dedicated namespace Peder Bergan
2026-11-20 16:32 ` Peder Bergan via B4 Relay
2026-11-20 16:46 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.