From: sashiko-bot@kernel.org
To: tumic@gpxsee.org
Cc: dmaengine@vger.kernel.org, vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v3 1/1] dmaengine: xilinx: xdma: Fix broken PM suspend/resume
Date: Fri, 20 Nov 2026 17:32:51 +0000 [thread overview]
Message-ID: <sashiko-outbox-225678@kernel.org> (raw)
In-Reply-To: <20261120172356.5858-2-tumic@gpxsee.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: xilinx: xdma: excess @xdev kernel-doc on
xdma_reconfig_channels()
--
commit a64f0416a1ecd1d433bba480228119fa8fc96611
Author: Martin Tůma <martin.tuma@digiteqautomotive.com>
dmaengine: xilinx: xdma: Fix broken PM suspend/resume
This commit adds noireq PM suspend and resume callbacks to save interrupt
masks and reconfigure the XDMA channels and interrupt registers across
suspend and resume.
> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
> index 9d827c9a12674..d6772b38d8f7c 100644
> --- a/drivers/dma/xilinx/xdma.c
> +++ b/drivers/dma/xilinx/xdma.c
[ ... ]
> @@ -398,6 +400,27 @@ static int xdma_xfer_stop(struct xdma_chan *xchan)
> CHAN_CTRL_RUN_STOP);
> }
>
> +/**
> + * xdma_reconfig_channels - Reconfigure DMA channels
> + * @xdev: DMA device pointer
> + * @chans: channels configuration
> + * @chan_num: number of channels
> + */
> +static int xdma_reconfig_channels(struct xdma_chan *chans,
> + u32 chan_num)
[Severity: Low]
The kernel-doc comment for xdma_reconfig_channels() documents @xdev, which
is not a parameter of the function and causes a kernel-doc warning with
W=1.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120172356.5858-1-tumic@gpxsee.org?part=1
prev parent reply other threads:[~2026-11-20 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:23 [PATCH v3 0/1] dmaengine: xilinx: xdma: Fix broken PM suspend/resume tumic
2026-11-20 17:23 ` [PATCH v3 1/1] " tumic
2026-11-20 17:32 ` Frank Li
2026-11-20 17:50 ` Martin Tůma
2026-11-20 17:32 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225678@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tumic@gpxsee.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.