All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/3] usb: dwc2: Add Siflower SF19A2890 support
@ 2026-11-20 20:31 ` Joseph Telaak
  0 siblings, 0 replies; 9+ messages in thread
From: Joseph Telaak via B4 Relay @ 2026-11-20 20:31 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Thinh Nguyen
  Cc: Chuanhong Guo, linux-mips, linux-usb, devicetree, linux-kernel,
	Conor Dooley, Joseph Telaak

The Siflower SF19A2890, a MIPS SoC for home routers, has a DWC OTG 3.30a.
This series adds its compatible and parameters, and handles an
interrupt it raises without flagging it: with battery charger support
enabled, the core sets MultValIpChng in GOTGINT but not OTGINT in GINTSTS,
so the interrupt is never cleared. Chuanhong saw the line disabled with
"nobody cares"; on the GL-SFT1200 the system stalls instead (below).

The two driver patches are Chuanhong Guo's, from OpenWrt and his
SF19A2890 branch. The OTG one handled GOTGINT on every interrupt for
every core; here it does so only for cores that set the new
otg_int_unflagged parameter, which only the SF19A2890 does.

Tested on a GL.iNet GL-SFT1200 with the USB PHY driver: a USB stick
enumerates at 480 Mb/s, reads at 5.6 MB/s and comes back cleanly after
two replugs. Without patch 3, a couple of replugs leave the system
stuck, the console repeating its last message with the same timestamp
until a power cycle; no "nobody cares" message appears first.

---
Changes in v3:
- Send to Thinh Nguyen, who took over dwc2 in commit 688bee95b423
  ("MAINTAINERS: take over dwc2 maintainership") after v7.4-rc1 (Greg).
- No code changes.
- Link to v2: https://patch.msgid.link/20261111-sf19a2890-dwc2-v2-0-cba9dd4a4256@telaak.dev

Changes in v2:
- Write my notes on Chuanhong's patches as lists, with Co-developed-by
  on the OTG interrupt patch.
- Sort the new compatible in the binding and in the match table.
- Describe the OTG interrupt fix as it is now in its commit message.
- Patch 1: add Conor's Ack.
- Link to v1: https://patch.msgid.link/20261104-sf19a2890-dwc2-v1-0-d959375e26ab@telaak.dev

---
Chuanhong Guo (2):
      usb: dwc2: Add Siflower SF19A2890 support
      usb: dwc2: Handle OTG interrupts that GINTSTS does not flag

Joseph Telaak (1):
      dt-bindings: usb: dwc2: Add Siflower SF19A2890

 Documentation/devicetree/bindings/usb/dwc2.yaml |  1 +
 drivers/usb/dwc2/core.h                         |  6 ++++++
 drivers/usb/dwc2/core_intr.c                    |  5 ++++-
 drivers/usb/dwc2/params.c                       | 11 +++++++++++
 4 files changed, 22 insertions(+), 1 deletion(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261102-sf19a2890-dwc2-87573f7cebed

Best regards,
--  
Joseph Telaak <joseph@telaak.dev>



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-20 20:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 20:31 [PATCH v3 0/3] usb: dwc2: Add Siflower SF19A2890 support Joseph Telaak via B4 Relay
2026-11-20 20:31 ` Joseph Telaak
2026-11-20 20:31 ` [PATCH v3 1/3] dt-bindings: usb: dwc2: Add Siflower SF19A2890 Joseph Telaak via B4 Relay
2026-11-20 20:31   ` Joseph Telaak
2026-11-20 20:31 ` [PATCH v3 2/3] usb: dwc2: Add Siflower SF19A2890 support Joseph Telaak via B4 Relay
2026-11-20 20:31   ` Joseph Telaak
2026-11-20 20:31 ` [PATCH v3 3/3] usb: dwc2: Handle OTG interrupts that GINTSTS does not flag Joseph Telaak via B4 Relay
2026-11-20 20:31   ` Joseph Telaak
2026-11-20 20:39 ` [PATCH v3 0/3] usb: dwc2: Add Siflower SF19A2890 support sashiko-bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.