From: sashiko-bot@kernel.org
To: "Jarkko Sakkinen" <jarkko@kernel.org>
Cc: linux-mm@kvack.org, linux-security-module@vger.kernel.org,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Alexandre Ghiti" <alex@ghiti.fr>,
"Andreas Larsson" <andreas@gaisler.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Andy Lutomirski" <luto@amacapital.net>,
"Andy Lutomirski" <luto@kernel.org>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Ben Segall" <bsegall@google.com>,
"Borislav Petkov" <bp@alien8.de>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Christian Brauner" <brauner@kernel.org>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Chris Zankel" <chris@zankel.net>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David Hildenbrand" <david@kernel.org>,
"David Howells" <dhowells@redhat.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"David S. Miller" <davem@davemloft.net>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Hallgrimur H. Gunnarsson" <halg@google.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Helge Deller" <deller@gmx.de>, "H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Jan Kara" <jack@suse.cz>,
"John Johansen" <john.johansen@canonical.com>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Josef Bacik" <josef@toxicpanda.com>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Kees Cook" <kees@kernel.org>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Liam R. Howlett" <liam@infradead.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Magnus Lindholm" <linmag7@gmail.com>,
"Manfred Spraul" <manfred@colorfullife.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Matt Turner" <mattst88@gmail.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Mel Gorman" <mgorman@suse.de>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michal Hocko" <mhocko@suse.com>,
"Michal Simek" <monstr@monstr.eu>,
"Mike Rapoport" <rppt@kernel.org>, "Neal Gompa" <neal@gompa.dev>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Moore" <paul@paul-moore.com>,
"Paul Walmsley" <pjw@kernel.org>,
"Pavel Tikhomirov" <ptikhomirov@virtuozzo.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Rich Felker" <dalias@libc.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Serge Hallyn" <sergeh@kernel.org>,
"Shrikanth Hegde" <sshegde@linux.ibm.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@kernel.org>,
"Valentin Schneider" <vschneid@redhat.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Will Deacon" <will@kernel.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Zygmunt Krynicki" <zygmunt.krynicki@canonical.com>
Subject: Re: [RFC PATCH v4 13/14] selftests/rootns: Add root namespace test suite
Date: Fri, 20 Nov 2026 22:44:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-226305@kernel.org> (raw)
In-Reply-To: <20261119224312.1037966-14-jarkko@kernel.org>
Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Medium] selftests/rootns: wrong _IOC_NONE direction in _io() on
wide-ioc archs
- [Low] selftests/rootns: non-blocking accepted socket in
CellService._on_accept()
- [Low] selftests/rootns: resource leaks on Cell init and test setUp()
failures
--
commit 646cdbb1cf35062e2a914f151927bb968fe747a7
Author: Jarkko Sakkinen <jarkko@kernel.org>
selftests/rootns: Add root namespace test suite
This commit adds a kselftest suite for the rootns and mount-namespace
configuration uAPI, covering privileged, unprivileged, and edge-case
scenarios.
> diff --git a/tools/testing/selftests/rootns/rootns_cells.py b/tools/testing/selftests/rootns/rootns_cells.py
> new file mode 100755
> index 0000000000000..b690ed71a5211
> --- /dev/null
> +++ b/tools/testing/selftests/rootns/rootns_cells.py
[ ... ]
> +def _io(magic: int, nr: int) -> int:
> + return _ioc(0, magic, nr, 0)
> +
> +
> +def _iowr(magic: int, nr: int, size: int) -> int:
> + rw = 6 if _is_wide_ioc_arch() else 3
> + return _ioc(rw, magic, nr, size)
[Severity: Medium]
Should _io() pass direction 1 instead of 0 when _is_wide_ioc_arch() is
True?
On PowerPC, SPARC, Alpha, and MIPS, _IOC_NONE is 1U rather than 0U, so
_IO() sets bit 29. Passing 0 encodes the wrong ioctl numbers for
ROOTNS_GET_NSFD, ROOTNS_KILL, and NS_GET_*, causing the kernel to reject
them with ENOTTY.
[ ... ]
> +@dataclass
> +class Cell:
> + name: str
> + flags: int = ROOTNS_KILL_ON_CLOSE | ROOTNS_CLOSE_ON_EXEC
> + cfd: int = field(init=False, default=-1)
> + mntns_fd: int = field(init=False, default=-1)
> + root_dfd: int = field(init=False, default=-1)
> + init_pid: int | None = field(init=False, default=None)
> + exit_status: int | None = field(init=False, default=None)
> +
> + def __post_init__(self) -> None:
> + self.cfd = rootns(self.flags)
> + self.mntns_fd = rootns_get_nsfd(self.cfd, CLONE_NEWNS)
[Severity: Low]
Does Cell.__post_init__() leak self.cfd and the namespaces it pins if
rootns_get_nsfd() raises OSError?
Similarly, in rootns_test.py, unittest does not run tearDown() when
setUp() fails or raises an exception, so CellServiceTest.setUp() leaks
self.daemon_pid and self.tmpdir if the daemon readiness loop calls
self.fail(), and RootnsUapiTest.setUp() leaks self.cell's file descriptors
if setup_rootfs() fails.
[ ... ]
> +class CellService:
> + def __init__(self, sock_path: str) -> None:
[ ... ]
> + self.srv.setblocking(False)
> + self.sel.register(self.srv, selectors.EVENT_READ, self._on_accept)
[ ... ]
> + def _on_accept(self) -> None:
> + conn, _ = self.srv.accept()
> + with conn:
> + data = b""
> + while not data.endswith(b"\n"):
> + chunk = conn.recv(4096)
> + if not chunk:
> + break
> + data += chunk
[Severity: Low]
Can conn.recv(4096) raise an uncaught BlockingIOError here?
In Python, socket.accept() on a non-blocking listening socket returns a
non-blocking client socket. If _on_accept() runs after connect() wakes the
listening socket but before the client sends its request line, conn.recv()
fails with EAGAIN and crashes serve_forever() unless conn.setblocking(True)
is called first.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119224312.1037966-1-jarkko@kernel.org?part=13
next prev parent reply other threads:[~2026-11-20 22:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 22:42 [RFC PATCH v4 00/14] Namespace for namespace roots Jarkko Sakkinen
2026-11-19 22:42 ` [RFC PATCH v4 01/14] nsproxy: Pass nsproxy to create_new_namespaces() Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 02/14] rootns: Add core infrastructure for root namespaces Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 03/14] rootns: Track init lifecycle via copy_process() and pid_namespace Jarkko Sakkinen
2026-11-20 13:18 ` Alexander Mikhalitsyn
2026-11-20 13:30 ` Jarkko Sakkinen
2026-11-20 15:24 ` Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 04/14] rootns: Add rootns() system call Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 05/14] rootns: Add ROOTNS_WAIT ioctl Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 06/14] rootns: Add ROOTNS_KILL ioctl Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 07/14] fork: Support CLONE_INTO_ROOTNS in clone3() Jarkko Sakkinen
2026-11-20 10:33 ` Jarkko Sakkinen
2026-11-20 12:47 ` Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 08/14] fs: Support FSCONFIG_SET_ROOTNS in fsconfig() Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 09/14] fs: Support MOVE_MOUNT_T_MNTNS in move_mount() Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
2026-11-19 22:43 ` [RFC PATCH v4 10/14] security: Add rootns LSM hooks Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 11/14] arch: Wire up rootns() system call Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 12/14] docs: Document root namespace uAPI Jarkko Sakkinen
2026-11-19 22:43 ` [RFC PATCH v4 13/14] selftests/rootns: Add root namespace test suite Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot [this message]
2026-11-19 22:43 ` [RFC PATCH v4 14/14] MAINTAINERS: Add entry for ROOT NAMESPACE Jarkko Sakkinen
2026-11-20 5:58 ` [RFC PATCH v4 00/14] Namespace for namespace roots Jarkko Sakkinen
2026-11-20 10:10 ` Jarkko Sakkinen
2026-11-20 10:24 ` Jarkko Sakkinen
2026-11-20 22:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226305@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=andreas@gaisler.com \
--cc=anna-maria@linutronix.de \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=casey@schaufler-ca.com \
--cc=catalin.marinas@arm.com \
--cc=chleroy@kernel.org \
--cc=chris@zankel.net \
--cc=corbet@lwn.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=halg@google.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jack@suse.cz \
--cc=jarkko@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=john.johansen@canonical.com \
--cc=josef@toxicpanda.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=liam@infradead.org \
--cc=linmag7@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ljs@kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=manfred@colorfullife.com \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=neal@gompa.dev \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@paul-moore.com \
--cc=peterz@infradead.org \
--cc=pjw@kernel.org \
--cc=ptikhomirov@virtuozzo.com \
--cc=rdunlap@infradead.org \
--cc=richard.henderson@linaro.org \
--cc=ritesh.list@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sergeh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=sshegde@linux.ibm.com \
--cc=surenb@google.com \
--cc=svens@linux.ibm.com \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vincenzo.frascino@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
--cc=zygmunt.krynicki@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.