From: sashiko-bot@kernel.org
To: "Cody Kang" <codykang.hk@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v3 01/17] dt-bindings: display: spacemit: add K3 Saturn DPU controller
Date: Sat, 21 Nov 2026 07:44:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-226790@kernel.org> (raw)
In-Reply-To: <20261121-k3-display-v3-1-ec419e8e96b8@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: spacemit: interrupts ordered before clocks
in K3 DPU
--
commit 5cacd6c3de4c42a0a1e84fc0f0f6938c6990b78e
Author: Cody Kang <codykang@vsit.ai>
dt-bindings: display: spacemit: add K3 Saturn DPU controller
This commit adds the Device Tree binding schema for the Saturn display
processing unit found on the SpacemiT K3 SoC.
> diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-saturn-dpu.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-saturn-dpu.yaml
> new file mode 100644
> index 0000000000000..97ea9da4b68e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-saturn-dpu.yaml
> @@ -0,0 +1,132 @@
[ ... ]
> +properties:
> + compatible:
> + const: spacemit,k3-saturn-dpu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Online (live display) compose path.
> + - description: Offline (writeback) compose path.
> +
> + interrupt-names:
> + items:
> + - const: online
> + - const: offline
> +
> + clocks:
> + items:
> + - description: Pixel clock.
> + - description: Memory clock for the compose pipeline.
> + - description: AXI bus clock.
> + - description: DSI escape clock.
> + - description: DSC clock.
> +
> + clock-names:
> + items:
> + - const: pxclk
> + - const: mclk
> + - const: aclk
> + - const: escclk
> + - const: dscclk
[ ... ]
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - ports
[ ... ]
> + dpu@c0340000 {
> + compatible = "spacemit,k3-saturn-dpu";
> + reg = <0x0 0xc0340000 0x0 0x54000>;
> + interrupts = <90 IRQ_TYPE_LEVEL_HIGH>,
> + <89 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "online", "offline";
> + clocks = <&syscon_apmu CLK_APMU_LCD_PXCLK>,
> + <&syscon_apmu CLK_APMU_LCD_MCLK>,
> + <&syscon_apmu CLK_APMU_DPU_ACLK>,
> + <&syscon_apmu CLK_APMU_DSI_ESC>,
> + <&syscon_apmu CLK_APMU_LCD_DSC>;
> + clock-names = "pxclk", "mclk", "aclk", "escclk", "dscclk";
[Severity: Low]
This isn't a bug, but in Device Tree binding schemas, clocks and clock-names
should be listed before interrupts and interrupt-names in the properties,
required, and examples sections to follow the canonical property order
(compatible, reg, clocks, clock-names, interrupts, interrupt-names).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-k3-display-v3-0-ec419e8e96b8@gmail.com?part=1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Cody Kang" <codykang.hk@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, linux-clk@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v3 01/17] dt-bindings: display: spacemit: add K3 Saturn DPU controller
Date: Sat, 21 Nov 2026 07:44:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-226790@kernel.org> (raw)
In-Reply-To: <20261121-k3-display-v3-1-ec419e8e96b8@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: spacemit: interrupts ordered before clocks
in K3 DPU
--
commit 5cacd6c3de4c42a0a1e84fc0f0f6938c6990b78e
Author: Cody Kang <codykang@vsit.ai>
dt-bindings: display: spacemit: add K3 Saturn DPU controller
This commit adds the Device Tree binding schema for the Saturn display
processing unit found on the SpacemiT K3 SoC.
> diff --git a/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-saturn-dpu.yaml b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-saturn-dpu.yaml
> new file mode 100644
> index 0000000000000..97ea9da4b68e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/spacemit/spacemit,k3-saturn-dpu.yaml
> @@ -0,0 +1,132 @@
[ ... ]
> +properties:
> + compatible:
> + const: spacemit,k3-saturn-dpu
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Online (live display) compose path.
> + - description: Offline (writeback) compose path.
> +
> + interrupt-names:
> + items:
> + - const: online
> + - const: offline
> +
> + clocks:
> + items:
> + - description: Pixel clock.
> + - description: Memory clock for the compose pipeline.
> + - description: AXI bus clock.
> + - description: DSI escape clock.
> + - description: DSC clock.
> +
> + clock-names:
> + items:
> + - const: pxclk
> + - const: mclk
> + - const: aclk
> + - const: escclk
> + - const: dscclk
[ ... ]
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - ports
[ ... ]
> + dpu@c0340000 {
> + compatible = "spacemit,k3-saturn-dpu";
> + reg = <0x0 0xc0340000 0x0 0x54000>;
> + interrupts = <90 IRQ_TYPE_LEVEL_HIGH>,
> + <89 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "online", "offline";
> + clocks = <&syscon_apmu CLK_APMU_LCD_PXCLK>,
> + <&syscon_apmu CLK_APMU_LCD_MCLK>,
> + <&syscon_apmu CLK_APMU_DPU_ACLK>,
> + <&syscon_apmu CLK_APMU_DSI_ESC>,
> + <&syscon_apmu CLK_APMU_LCD_DSC>;
> + clock-names = "pxclk", "mclk", "aclk", "escclk", "dscclk";
[Severity: Low]
This isn't a bug, but in Device Tree binding schemas, clocks and clock-names
should be listed before interrupts and interrupt-names in the properties,
required, and examples sections to follow the canonical property order
(compatible, reg, clocks, clock-names, interrupts, interrupt-names).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-k3-display-v3-0-ec419e8e96b8@gmail.com?part=1
next prev parent reply other threads:[~2026-11-21 7:44 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 7:40 [PATCH v3 00/17] drm/spacemit: add SpacemiT K3 display support Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 01/17] dt-bindings: display: spacemit: add K3 Saturn DPU controller Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:44 ` sashiko-bot [this message]
2026-11-21 7:44 ` sashiko-bot
2026-11-21 7:40 ` [PATCH v3 02/17] dt-bindings: phy: add SpacemiT K3 Innosilicon DP PHY Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 03/17] dt-bindings: display: spacemit: add K3 Innosilicon DP/eDP controller Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:45 ` sashiko-bot
2026-11-21 7:45 ` sashiko-bot
2026-11-21 7:40 ` [PATCH v3 04/17] dt-bindings: soc: spacemit: allow eDP/DP PHY PLL pixel clocks on K3 APMU Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 05/17] phy: spacemit: add Innosilicon DP TX PHY driver Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 06/17] clk: spacemit: k3: parent eDP/DP pixel clock to the PHY PLL Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 07/17] drm/spacemit: add Saturn DPU register model Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` [PATCH v3 08/17] drm/spacemit: add Saturn DPU core types, cmdlist and display MMU Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 09/17] drm/spacemit: add Saturn DPU hardware backend Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 10/17] drm/spacemit: add Saturn DPU KMS pipeline Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 11/17] drm/spacemit: add Saturn DPU DRM device driver Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 12/17] drm/spacemit: add Innosilicon DP/eDP controller bridge driver Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` [PATCH v3 13/17] MAINTAINERS: add SpacemiT K3 display driver entry Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 14/17] riscv: dts: spacemit: k3: add display nodes Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 15/17] riscv: dts: spacemit: k3-pico-itx: enable the DisplayPort output Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 16/17] riscv: dts: spacemit: k3-com260-ifx: " Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` [PATCH v3 17/17] riscv: defconfig: spacemit: k3: enable display driver Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang via B4 Relay
2026-11-21 7:40 ` Cody Kang
2026-11-21 7:40 ` Cody Kang via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226790@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=codykang.hk@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.